From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE4333806D8 for ; Wed, 1 Apr 2026 16:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775061189; cv=none; b=kupoNwgzAWwaqA/VBW3zEhVSj27IIGwXo+SW+Lsfr/uYlGhMkwzwW2wbaScsXhFFmCqYx/kHpHqWakIOFRBUBLYP02yOqZZiEIcGRxCmzb8jnTp3DyZlRb55PPc9G6V6m8fIoX9k+qoQiVuwLWbFolOjaidKFQn0p5Qg638Geq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775061189; c=relaxed/simple; bh=CpXR9nt9c61PJDkkfpO3xexyQRNDtnOTUDGrui1/Y8o=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=rz5X8PzakyGyJbUIuqsn3/jOM478EJ91geh8Zy21Gk+hYfQjV5wx9Tbt5HH1f3SEc6uK3uQln94IC0cT6T65B7Xu/hgck4Kvb/pI8Mh8cC2vaH47JbEKwYGUHAhTqwA0QPI/5WNDYukHXDtk8WrgtpHRM5atr7K8eahsJG7hbB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=XCm5TfGB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="XCm5TfGB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE62AC4CEF7; Wed, 1 Apr 2026 16:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1775061189; bh=CpXR9nt9c61PJDkkfpO3xexyQRNDtnOTUDGrui1/Y8o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XCm5TfGBy7rnkeVLgFrdJCNBCDZg1lntmtS0oVLe0ooeGPi8CBputtc1a3r8juteK JmwIfDylvBzApJmjtdB6iWKFGJJQSST3qj4Ot4adg/1p6bjJwjst2OZdEuHl6U+YHS CazdhFqSv09CkA75lBwQVW8oXI3TB1yhfqm1zrYE= Date: Wed, 1 Apr 2026 09:33:08 -0700 From: Andrew Morton To: "David Hildenbrand (Arm)" Cc: Muchun Song , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Petr Tesarik , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/sparse: fix BUILD_BUG_ON check for section map alignment Message-Id: <20260401093308.6fe32f4de4bc15ee6495fa68@linux-foundation.org> In-Reply-To: <1f8d0cd2-c990-4597-bf47-5a8217acc464@kernel.org> References: <20260331113023.2068075-1-songmuchun@bytedance.com> <32789381-f860-4b60-a1e1-4c97f6ed08b1@kernel.org> <7C90E910-D229-4F60-A62D-E893A89D58F2@linux.dev> <1742503A-F912-4AB6-AAF6-6CDB06829024@linux.dev> <9fddd112-e304-4ce1-b3f0-a4b133fcb281@kernel.org> <1f8d0cd2-c990-4597-bf47-5a8217acc464@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 1 Apr 2026 09:26:49 +0200 "David Hildenbrand (Arm)" wrote: > > My original motivation was simply that when I read this part of the code, > > the comment felt a bit off to me, so I just fixed it casually. But if it > > ends up creating the impression that "we might be supporting something > > we don't," as you said, then I'm fine with dropping this patch. > > Can you rework your patch to only simplify the comment, and to clarify > that we always expect a single section to cover full pages? And to fix the sh4-allnoconfig build breakage ;) https://lkml.kernel.org/r/202604011400.OFLcOOmf-lkp@intel.com I'll disappear this patch.