From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D64E3B7774 for ; Wed, 1 Apr 2026 10:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775038202; cv=none; b=m7KKhzzeqfbVFn5Dcg2Dg8ZHagWfFt9qsQdizwPSzDhT/18T8Gwme8rUT/lBx6lPWMVqdHPYRqvJDQ0PDyZY6+oRKvxUMXAUxmiyBiXj+CzcoTNlt3RnoaUVqt5OfJ486DDDzX46o4+P/yyO9afn4jYn8fRD46j8hnLPuykSs2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775038202; c=relaxed/simple; bh=OazJXZzaswCkwt+8o25PlXm/nM2wdFCfDjKh8SeCTbA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=agydW91y4s0jHA4xd0MQqXJol4D/4khGpUiVcXLrFRlYMlh6IqlZsB8ru9zP+xQ7NCTsV1EByWpQs7T2AioYjVw7Xc93TCChNClz+pl8hqhFRRDaR3TIrFSOQv8Kka2+iq7stqTgQNPbhGqoqADjdK+uO45QUHmYUsg2X1jwHnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pc5PNqBZ; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pc5PNqBZ" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48558d6ef83so66979585e9.3 for ; Wed, 01 Apr 2026 03:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775038199; x=1775642999; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BbfOo0YSngwbRzgcLO4MRJ2H012Ob9tbDWEvMc7/oQ4=; b=pc5PNqBZRJDOJwSaUFpVzB3iOFXvYL35wOKKPf5pED4HsmezGq5M/Pg/N3qQEVx6rQ kNyMZv44BjyumUIrtBHlOVKvJ2Ov2geKKmXbL+nNUbcTa36fg5oGOa5V0jHa3gMlMgHZ mPAcxlOttDbBEMqyFs6DP44CjSEDngzn1aaQ7DeowVRS5SRvaDbX/AtvYm3l/eATMQ9v wKAA2nzzxQtw+56O96PEUscyLlVIuoSPqM6HiqBORuGKYZbn3tBJg88H+Dl2IExa8LVC UKr2EnbcaQybthBatgE7qosDnSSnce88MWC3rQozJ7rrEmKUpb3SK/vRk6MyKfemoqcf shYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775038199; x=1775642999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BbfOo0YSngwbRzgcLO4MRJ2H012Ob9tbDWEvMc7/oQ4=; b=fhniJDSM3UGGtuNG0rCZqcYa9QdUBcY510uFxUNulN6njjRNUrBD6eHRV28QdwoTr7 vAFpir+vD/uAWlIkhjxjDXu3DHWpCx1dFDjL1oNpqRdottVADxQ+G3P6tRzgp8TWJlNP xzVZ0o3jXnuxmmZy4y7EA82Hx6QPUpmTW4ZV13/uV1FM1SZWJu05zYTy+KOtl3KA4W/z nqkae+xjwjhHIDA8euySofqxdUVXFMqJPdSFdT6vNPo5r72vf7TPG6zl/q3q5qg71DN8 h8bDMk8hiqQTsOQPhexP+lpPApYidTknsAMyB/R3dgdbmX+xPFCdIWwCscoTGBIXaKL3 2XXw== X-Forwarded-Encrypted: i=1; AJvYcCU0+sbwIIzoHL3aX5DPpeKOAryDSw4OLbXWvJF3Dsj6SPhz+LuJH+soWVzHBp+q9jtL2f92qhIxDJV+L2g=@vger.kernel.org X-Gm-Message-State: AOJu0YyVSPRFWGPoWLYdjH8BfDVy0Cn2NJ7cW1zTpM7yXWcskkrxz2Y6 w9DNHSQMfwd0V29pf9tpBxLPDk2I/g0ZWnRGwy39s6bkt6WmaVK9ieBd X-Gm-Gg: ATEYQzzNB/BWGdEwd253kQ0ZyHrZd6UIFcguoplCpgHmIvoE3F2u3mA2S9ah4G5Iv09 B+gBhApYPETV0rRq0dJEviRaKrcxgjycFT3pceipCjAc2gsvN6o0V8BnKur08eNW7RSHqBU3eTi g4QAaAcCXnzjP54/5QXwalcXK9m7THE7Kwkb8Ni9bR0zvcFVD2yqpyLcCDoekzVRjE1mgYMNnuu WwvdcsbHYcfJr9auWLn92hRE9nv0BI/95PA9YQMbgll9VAcNAvE2/YC3WLxYOc5ADAlul0dzDIG gvkIID67aqjBUXS5wEOC1FyN7dkd/d9PaahZyeNLvWqPFCIVxgNLYGUkmErUxa8r0F29KfHOwgu mrBoTW9/97ALwtx9eRWSUClyhJcdA4Se6TQR+2V5IS+vwUZt+XO2ja+/Qu/r6OpZOx0rWcJSU+/ aFR90U2DX8B+wm85WQqrtiNSn1aTQjgAxntD9kTFG2c8Tng8lr1CbN X-Received: by 2002:a05:600c:1910:b0:486:fc61:541f with SMTP id 5b1f17b1804b1-488835d5a0fmr45239005e9.29.1775038199197; Wed, 01 Apr 2026 03:09:59 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:2d1c:ca82:e123:e111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e884dacsm150158905e9.15.2026.04.01.03.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 03:09:58 -0700 (PDT) From: grondon@gmail.com To: error27@gmail.com Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com, parthiban.veerasooran@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: Re: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() Date: Wed, 1 Apr 2026 11:09:56 +0100 Message-Id: <20260401100956.22590-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Gabriel Rondon On Tue, 31 Mar 2026 22:40:00 +0300, Dan Carpenter wrote: > Check them all, right? Maybe the others are similar? Checked. Patches 3/5 through 5/5 (configure_channel, enqueue, poison_channel) only check ch_idx range, no hdm_ch NULL check — those are fine. Patch 1/5 (try_start_dim_transfer) does have the same unnecessary !hdm_ch check. hdm_ch is a parameter there, but it's already dereferenced on the line above (head = &hdm_ch->pending_list), so a NULL check after that is dead code. Will send a fix for that one too. Thanks, Gabriel