Re: [PATCH 1/2] exec: use strnlen() in __set_task_comm

Jan Kara
2026-04-01T16:31:06Z

On Wed 01-04-26 17:20:40, Thorsten Blum wrote:
> Use strnlen() to limit source string scanning to 'TASK_COMM_LEN - 1'
> bytes.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/exec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 9ea3a775d51e..ba12b4c466f6 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1074,7 +1074,7 @@ static int unshare_sighand(struct task_struct *me)
> */
> void __set_task_comm(struct task_struct *tsk, const char *buf, bool exec)
> {
> - size_t len = min(strlen(buf), sizeof(tsk->comm) - 1);
> + size_t len = strnlen(buf, sizeof(tsk->comm) - 1);
>
> trace_task_rename(tsk, buf);
> memcpy(tsk->comm, buf, len);
--
Jan Kara <jack@suse.com>
SUSE Labs, CR