From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5E231E85B for ; Wed, 1 Apr 2026 18:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775067432; cv=none; b=CvzXGvFyvI/2KsbVKTunxDGrjAINbh0olGpPFXA9QAiKpfXIqLWSw+C2KtcMl5oyC36OW16EerF+/VTR5zPXmpzXk1X7/qlGOSDMkkunJwgxkodiJ31Ndny0Yi735SXZoMoJBh6fz/MYwRTmxR22UrT65fmyfPDNDp5AFW5DXnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775067432; c=relaxed/simple; bh=ST1x8Uz6TQiGe79USzqdmWvtwG5sB+Qa3OSNFjV2atk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T2Luf5En+SB7dQHhXuibyBc+TrH1zVLfprPVDdJTZoOLqEkp1hFa5DeDRtnTzl9r83/cXnyB4/uJnP/Ttt4sNKLN60o04XNHrIhRBisSJOGkH51hTZZYTaDoToXpkvMYC937tQkcWlGRjQWe3PqFcjvpbDHla+g7XPkJzFymKMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CkKbYpvr; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CkKbYpvr" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82ce09b61beso35552b3a.0 for ; Wed, 01 Apr 2026 11:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775067431; x=1775672231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s4DmGGsmlsWiS4YmUq0GXU6tJWK3BV4/TprF0P8CHx8=; b=CkKbYpvraMDRHRyVBuECfsavtGsmm1Ts+W3gAvE++KnUMCN7ehZ7STgv6X2yyiUGED CYKfoRQpHIy0q/z42ucQj9zXjeYu4w0/hufKnCwmnUEi2GBnILBTUX89nfPQZEaB+Toj Hbh6+89IPoDrjkY6DZA5T9S/o775KU35r325M9rqexyutu/K2LJs9glOH+pdPj29yFe3 qG3UY2/D5/nCTLK3gKBO33Fn5smHOgv7RB1I2auzMH+xD2FVIGaPMqj0kK/Gr1wvDDIV o9tdeF21rMW3ji2I0YFrsAxw7mmu57a7uZyMOiRErh7cgeyL4x8l2Ihh1Yss4f1zIpGW woHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775067431; x=1775672231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s4DmGGsmlsWiS4YmUq0GXU6tJWK3BV4/TprF0P8CHx8=; b=ZgLEPbahpmqGkH5P+0hoN8BwFmCyZHpb4wMag3Q5rnQX2HUIGLERglGnuzE+ZtTLjf SO31R+rjM7vF6p9mGr+RTeJm09l9aZKEwLBocrh5Ql4xQZnN7Wj3IF0hECE9PtUMXluD AYlO8QNp1scTpGRTePsdCJX4USKq1xRLif+DxjHnDL4Sj3YxBw2puwyDm5Ak1knqX5v5 suNR/dEPYFGeUbvyUnHzESqUfsdehPTMN+n9mDj3A3mM1eRJc+JHWhAOdCrD5AQmWrtx v/26VxQ+BDEg4FD+DbBfz79zYeFxeSaXtddesmoIRU/LqnEMTt858dffUs343WLoekP/ P+sw== X-Forwarded-Encrypted: i=1; AJvYcCXLj7S6joQNlrPJTiUg89+5fW3ExKKVOlhddplss4I7A+ZAovi2JaEZ9N8IJuQ5vBS2X4g1ebXA1bJP2vg=@vger.kernel.org X-Gm-Message-State: AOJu0YyyE/GWHtyrW25YbMSefgBTKZunaLLvG8wwhx8c22fSO/5m2U/x C2DtcrYG+6os7HGtt0LknnrBVCTTlU/RUI1yytRLooLmyjiHICQIKp1GUkjL/A== X-Gm-Gg: ATEYQzz1rhW7oMqKUOOEe9kXI3/l8q0tDQlni2a909cofY3QzcOs184p/7iwnBfw6Br +8d6uctSvnYpLQwu6UQnlhqLldvZUmWE2N1kuWa2c1k6DB43nPmN8SaxewL0vtLCeOS5coo+R4b H5Ys6o4IAWXEMDLbc18MqnRDH80uhsxDq/7bCVJNkZutavv165tgxeBUeFgPxqI2TkBkv2RiYec AuhpBY1OZAKT48g+CHRhrHvRM/3ZEx28A5+GdXXDGvbK7zSI/zzREPCMALPn1U6A3lxe7GptS+c sPOwLr5ZXhYorpv/M5HC32nzAiGWHso6ZMFxZIcB8fd1/K3oO/s+Yw2AsDqH8slyTeeuBt0iLzV csAsuVuwV2FNbjX5xfxTAxQwMhZCMvdRHsWvWCzIpoMtyZ5TEm+eFWeonhhRYdndVfJpMic9i6E Tp5DSH/ve1hdLDmc5h1NGQJDZ+onJQBP+RCLoJNuLX4I8JRife X-Received: by 2002:a05:6a00:6717:b0:82c:f035:6748 with SMTP id d2e1a72fcca58-82cf03569afmr2319067b3a.42.1775067430834; Wed, 01 Apr 2026 11:17:10 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9ca14b3sm666249b3a.54.2026.04.01.11.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 11:17:10 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: hansg@kernel.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Cc: hverkuil+cisco@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] media: i2c: gc0310: Use devm_v4l2_sensor_clk_get() Date: Wed, 1 Apr 2026 23:46:57 +0530 Message-Id: <20260401181657.654055-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260401181657.654055-1-sanjayembedded@gmail.com> References: <20260401181657.654055-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Several camera sensor drivers access the "clock-frequency" property directly to retrieve the external clock rate or handle the external clock manually in the driver. While this is valid on a subset of ACPI platforms, implementing this logic directly in drivers is deprecated and can lead to inconsistent behaviour across drivers. This driver supports ACPI platforms only. It currently retrieves the external clock rate from the "clock-frequency" property and fails probing if the rate does not match the expected value, which is the correct policy for ACPI platforms. Switch to using the devm_v4l2_sensor_clk_get() helper to standardise clock handling. This preserves the existing behaviour on ACPI platforms that specify a clock-frequency property without providing a clock. On platforms that provide a clock, the helper will program the clock to the rate specified by clock-frequency, which is also consistent with the driver's expectations. Signed-off-by: Sanjay Chitroda --- drivers/media/i2c/gc0310.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/gc0310.c b/drivers/media/i2c/gc0310.c index e538479fee2e..e9e67bd73f51 100644 --- a/drivers/media/i2c/gc0310.c +++ b/drivers/media/i2c/gc0310.c @@ -6,6 +6,7 @@ * Copyright (c) 2023-2025 Hans de Goede */ +#include #include #include #include @@ -84,6 +85,7 @@ #define to_gc0310_sensor(x) container_of(x, struct gc0310_device, sd) struct gc0310_device { + struct clk *clk; struct device *dev; struct i2c_client *client; @@ -634,7 +636,6 @@ static int gc0310_check_hwcfg(struct device *dev) }; struct fwnode_handle *ep_fwnode; unsigned long link_freq_bitmap; - u32 mclk; int ret; /* @@ -646,21 +647,6 @@ static int gc0310_check_hwcfg(struct device *dev) return dev_err_probe(dev, -EPROBE_DEFER, "waiting for fwnode graph endpoint\n"); - ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", - &mclk); - if (ret) { - fwnode_handle_put(ep_fwnode); - return dev_err_probe(dev, ret, - "reading clock-frequency property\n"); - } - - if (mclk != GC0310_MCLK_FREQ) { - fwnode_handle_put(ep_fwnode); - return dev_err_probe(dev, -EINVAL, - "external clock %u is not supported\n", - mclk); - } - ret = v4l2_fwnode_endpoint_alloc_parse(ep_fwnode, &bus_cfg); fwnode_handle_put(ep_fwnode); if (ret) @@ -684,6 +670,7 @@ static int gc0310_check_hwcfg(struct device *dev) static int gc0310_probe(struct i2c_client *client) { struct gc0310_device *sensor; + unsigned long freq; int ret; ret = gc0310_check_hwcfg(&client->dev); @@ -697,6 +684,16 @@ static int gc0310_probe(struct i2c_client *client) sensor->client = client; sensor->dev = &client->dev; + sensor->clk = devm_v4l2_sensor_clk_get(sensor->dev, NULL); + if (IS_ERR(sensor->clk)) + return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk), + "failed to get clock\n"); + + freq = clk_get_rate(sensor->clk); + if (freq != GC0310_MCLK_FREQ) + return dev_err_probe(sensor->dev, -EINVAL, + "external clock %lu is not supported\n", freq); + sensor->reset = devm_gpiod_get(sensor->dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(sensor->reset)) { return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset), -- 2.34.1