From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B4EB263F5E for ; Thu, 2 Apr 2026 06:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775110979; cv=none; b=p/7ax3x69r2zsmPdDyTXyelcNUe9NZw+YOY5XGewdR0FugDu/Eah13XCBF17ngag64M0et0D3ko2Z6t8FtIFB+V76aWgQDDpJpCxEAxA+xE5PjFxiEt/VO3fuy+XgfUwkAz5Koj03cC9XsraDaGUxRm22xrAorh7gTJZGGcrME8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775110979; c=relaxed/simple; bh=3W9anY3cpJKhpAzw4JUheDtQgDCfPd8hcHkCsYTLwls=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=K1rHVQf9A4QWRN0eLikp+Il6FAoeSR2tZ8IuOw9nO7+9+P4x1zHwRqSu5upibrQ8X+ssE2B8Jw174GFjjPVZHhCq4O1NeuprCydZzSyFz0Ynya0/AnC2XhA0enyouYlwnPNBoGAZh76KtZ+Xm75RQ2Qsnj3uzf197jAOAvcO0Dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E+ICmasF; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E+ICmasF" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43b95e5b3afso283547f8f.3 for ; Wed, 01 Apr 2026 23:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775110977; x=1775715777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aF5oWbaohPoRBNTTQwa92WNgb/6TWUajabW5bML62TE=; b=E+ICmasFO7cMALVYfNZn0fPzX9aj+nwfKkmtxu9ztXvHSmNlLmbku6U1waWx8ZQLKU /TxY9P4YTSHyuYwp/wtAqtcuZiq++UzFmfGkvWN7MJJTvYaiAuQaoK0P7tW3r7WgKyHX TI7vOLA5MMoMSd2lGoTHxHscNaemcrNgV6xy1eROOe5gZ6u/NMgkrdGvgmISYL7ppmb1 LXg8DbVVBXPy0KXpqVMtK4WtRTQ6O0B4Dd+QPNKVldO9Z0/vhdieanwMbSWTdxSY6srl 0pYM02idLbMqN1pK4jfKnEW+WhqpJW2h/NgX/gnNCK2tu1jR0RvklGCPMTOMiIlC4YAf kjLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775110977; x=1775715777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aF5oWbaohPoRBNTTQwa92WNgb/6TWUajabW5bML62TE=; b=XlCrJOOCwVl5FO4lZjsB/rjWkaR271ZI6PQjHcp1FfPn4ekQoVz9hhg7Oj6YH8iOeJ djY+r2m8dNFMlPVXH1kMotBoSdZbJuCdGOz5+qYvVr18Mnw9dDUyomCtpG9Hi/dbosop aDamd9pSpYwdnikn5PCVLv9wfMov+LFg7oFGUrhygz3ZQLNNwgqC3H/7z1HlJP2+3Gs6 BkTmsxKaCdIcW6nQtHS3j4M/igJmCsNxweLTCYNL0538ukyHfjtat4IM0oe5SVW9xwNM zdiupPeUnYq+uviGPAZdJfHriMNGB/jOdRAao9y7Y/QFnyrt4Yv2MfGE7P1niVGrM81O TNOQ== X-Forwarded-Encrypted: i=1; AJvYcCUNwAbEEB+waskrykLSzoLhIayIy4GDQNWu+CxjsIh9XwbfeO38GAHbR44H7jAYGHEonXQNOd4pL2Vx6/w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg/usowWoxwX41ITwPJmhGI3TaerW/BtRPesezUfencFvCrhJ5 BgKu2hi/JvqpqcZPa7yWkrA+2mt4k+XkGXQiN2e7DhbPOIrvP4MKSqnRTtAU+iYA X-Gm-Gg: ATEYQzx6o7SW/Y8rAsZmH46U5S6aOFMQ1aBG+/RuS1Pt3GixGJ2EuvnWvS713w/CCZd g5MZnkLpZA7NwmnU+Ian3PB14d7238VhNf9s9QCIyoCNQGMNueyynsyh3ANYP38m+NO5Himhc0L t9Y6f6sfDVkpO16hRTr3Q3jTo+y3yi3DKIVGnQ8raPGQXZYKOziEhIKV8uCLYEHp1YqzwyyhPF0 ywJWe0cZsMRwJyxko1z3OYHIowxpQJ9qoIGR5hq0D74CV0qCZweMg6l/Qhm99MVhe7lbB5lo/5C lKspN6mKoEeQAcKGQxegFr1C0NcGNIhr2azP3QkQ7N60kBwpejNmMh0KuF69vY1EZcRXeYZ6SWW Qn0nuZ1qeRATHCJUbLzaWRBI1nkahKxBl8Y3tVzj/HeWGJ0t+wJDx5sUJBkoQMXA8/qt79HGgei UZ37yOHlDhCsgL7VRdzjPCsCTPkpL1WClHttymJ5VpYBn7v7AwDAzqXdV8XE1b9FKy5yTwUFKAC CIwyPehtMELG/tj0J3r9x8mO+BQeyRo6Be/DnJc+sGr X-Received: by 2002:a5d:5f86:0:b0:43b:6356:7d00 with SMTP id ffacd0b85a97d-43d15085f7bmr11895217f8f.17.1775110976441; Wed, 01 Apr 2026 23:22:56 -0700 (PDT) Received: from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e1fe0b0sm4991721f8f.0.2026.04.01.23.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 23:22:56 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Oleg Nesterov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH] x86/ptrace: Use savesegment() in get_segment_reg() instead of inline asm Date: Thu, 2 Apr 2026 08:22:30 +0200 Message-ID: <20260402062248.459921-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace direct 'movl' instructions for DS, ES, FS, and GS read in get_segment_reg() with the savesegment() helper. This improves readability, consistency, and ensures proper handling of segment registers on x86_64. No functional change intended. Signed-off-by: Uros Bizjak Cc: Oleg Nesterov Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/kernel/ptrace.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index 3dcadc13f09a..4cb00aa0645f 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c @@ -251,32 +251,31 @@ static u16 get_segment_reg(struct task_struct *task, unsigned long offset) /* * Returning the value truncates it to 16 bits. */ - unsigned int seg; + unsigned int retval; switch (offset) { case offsetof(struct user_regs_struct, fs): if (task == current) { - /* Older gas can't assemble movq %?s,%r?? */ - asm("movl %%fs,%0" : "=r" (seg)); - return seg; + savesegment(fs, retval); + return retval; } return task->thread.fsindex; case offsetof(struct user_regs_struct, gs): if (task == current) { - asm("movl %%gs,%0" : "=r" (seg)); - return seg; + savesegment(gs, retval); + return retval; } return task->thread.gsindex; case offsetof(struct user_regs_struct, ds): if (task == current) { - asm("movl %%ds,%0" : "=r" (seg)); - return seg; + savesegment(ds, retval); + return retval; } return task->thread.ds; case offsetof(struct user_regs_struct, es): if (task == current) { - asm("movl %%es,%0" : "=r" (seg)); - return seg; + savesegment(es, retval); + return retval; } return task->thread.es; -- 2.53.0