From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D8612DC782 for ; Thu, 2 Apr 2026 14:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775139804; cv=none; b=JccnsZLseGQnaSawI4cpDXrG51fech/ok/TdjBKirJeNd42PwAsCH+TGGyDiZXam/ZlXgVjhE3fL6EZ+1/hOajmAcCU75C1qobpELA/lN31tWT1yjhLuUO58rNTUK25+utlMeNc7LdbNBJnUgGbJ0r39Nis5TX1eYZLq/iGCHv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775139804; c=relaxed/simple; bh=FBdbJcvciWpQjX7pla6TaAYH3QV5dVpZVhfT8H7onLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVm4a9z3InFWddkCPQOtnipwcBVRFjHuNQIqRQuTtDVV4OsawXRX5sFwhO2zGu9t0a8AloUu7DIzNGOF8H2Wh34PiLKmxLdLhse68kYCGABTm+UF8/rCOKmhdYhecWIkpC3IDJuON3V0BGFVzkbaDrEaNwGE8Q161hkGtdk0iK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RLu8X0fJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RLu8X0fJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D353FC116C6; Thu, 2 Apr 2026 14:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775139804; bh=FBdbJcvciWpQjX7pla6TaAYH3QV5dVpZVhfT8H7onLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RLu8X0fJNPiVQNGxOIeMAUUGIUOC7CStxElAFoc9Vj67JAKJrpFml54GYlgDmP22Q i1Vl7CfXE1WHG8dDcSZkE8ONexMndCuNQ76PZvh515LPf9el0SXbIGK9JRDy0ZS+WI AhThAA+QOLS+mNBhFDRuAso74vq38HSD7LzternA= Date: Thu, 2 Apr 2026 16:23:21 +0200 From: Greg KH To: aravindanilraj0702@gmail.com Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: altera-stapl: Replace sprintf with hex_asc_lo for hex conversion Message-ID: <2026040220-viewpoint-confider-f74b@gregkh> References: <20260326173257.25375-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326173257.25375-1-aravindanilraj0702@gmail.com> On Thu, Mar 26, 2026 at 01:32:57PM -0400, aravindanilraj0702@gmail.com wrote: > From: Aravind Anilraj > > Replace sprintf() calls used to format single hex digits with direct > assignment using hex_asc_lo().This avoids unnecessary overhead > from using sprintf for single character output. > > No functional changes. Nah, this driver is so old, let's just leave it alone wherever possible, unless you have the hardware to actually test your changes? thanks, greg k-h