From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA31938F65F for ; Thu, 2 Apr 2026 20:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775161277; cv=none; b=dsUUVoT/UZMP0krvBeNULz+HAUFCw0ECSWy0zcE9J6LmViUPo8AvivfnWFq48GkiKF+Gon1K1t7OGy98J6F+n4qs6C19BTeAU1swAvukUqFO6C7ZPBxbs9dWNY0wr8lRGQFZWCqZ3lffbIJ/R77/e+7eNQK5Zql/Q1U+7KgS5nY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775161277; c=relaxed/simple; bh=hnchutNSKdERytZ29SHtkBya1y8wz+y2yuNMQGv+P3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pS9imj1zuLo74We7jPonPqOus3df9MltsS0p9H+4yTu2g4hDneFWO5Od6EcXrXJ25rx2Rwtk0xRHpPu2gJBORHi9+uE5YPYkFsKwRiXpS7vWa8ntVgGlYwYWraKgJMKUH2gG91lw/TGqVHzgteZ82xRScaQwN3tb4uOnFYi6jk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=Nsft7Q+D; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="Nsft7Q+D" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c06cb8004e8so489144a12.0 for ; Thu, 02 Apr 2026 13:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1775161275; x=1775766075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jygRO2y1k21YPmAFcC26ldU2Kb9JdwnlpXm+3nNMbLU=; b=Nsft7Q+Dc3otstlFIV2ctsZKd4VmRxNE2xpcu1l4KcjFQxk28N5ibvGYGjTeMerKuj hj+SjG5CtPxcby/pAizCoN4CGJ2SqSdqDHWsKS3xofdC7z/vlKCU8O5L1536IjTe16v8 WuLa9lofcbIR9QNlRj3a9/IGsKm8ylYtVmvE2zZ1vtFPpPyJVRR7RfQJghWF21WtTL2G 6KQf2JBaj07yKuqGHMZRCOBgj7fdU5vT7krrJb6YP5i29nFrOD0Z17x+GcijyvMjpJeT iqlZchWQsSa+OHf5AdTylkGT4xMXTeWU0wjlAJ6bdl2SPlmtbPzKjjJnnwlyFNB71PkE G71w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775161275; x=1775766075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jygRO2y1k21YPmAFcC26ldU2Kb9JdwnlpXm+3nNMbLU=; b=iPtczeEBT5cikr0Ps9ydT8Q2/WL3CXSmAA1+zBUvx9EdRCMhGmgYo+VmOPl7KXpDzX BAUUQYEkzcCPH5xKJStvDZm62Y7MNKREC/yKJlPmSCm68dbeyJ2+WMz9MphM3iD1Jze+ 8pxSmSm5DgFbZEJmg6yyyEONBCKtbNsoH1i0ANgk+VuXlKAf/ckoIA0fLOZ6JFT4WyHP kNg4vUhG1iD1pTkaocSNMhG6pqjgN7jKalhZkbk4U6Hr4dFBuVdJ5NokMFiRabkkkIOZ /JO88IECSupPlmuFwrOMD0m/aYtNC3vg0BQdshcrbFXx5TQdurpv+aqhAkwk1O6UyaZk QK6w== X-Forwarded-Encrypted: i=1; AJvYcCXPVaeg4ZSmuIea2uuzNFAYBpaL09ey0uI2QmJUu3mvLWvVO7AfHE7BiTgxJklw+dN0y8dmc5goL+w0lNU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9YHzC9MZwJClk6DL2G9+HV0tKgXhbW2tS/VtTAaGduWofeEWT vFh6+OVoP6yxQsaYiTd8rznx626FwstkcoHV5Ac187xILsj/SV3HN2bgHpf9l8ZKpVg= X-Gm-Gg: ATEYQzxbD3muIvMi3oOG4YA7SO1jYOLZhI8Z7Fpg2eFK894QG7wQwhJsICpXAFWoByI /0QspqeMdOzbCuFHbLwWB9RI6cpsekgy36L6QZROla6nFuKJ4U1cWqFcVqxrhE/Vik71XUz/KMr C0Kf6zvtIkeJ6Q4TYROFvPmZi7jKoiVdVF9391h962JgGCcrrgmD6xrrFwzEP5DOS9RyJHyA3Xr RBjqyJ/VxEq4J8uvi6Kr1Z1iPmYpFSiKxkgP+okOiskUYRAjn8yd2JHaeT8LrGc8GhPD6nbBkDV pRZ3XGMnNLHNyQ3e7jPhRlsweXSru9bKb+QYQWzp5f1OBBMz2B9ySuRQErfMDKZHDMJTbSnQD96 pdywfk8n8k5MEEJRVvgVG6UTX1xVeEm8s0YuBjOB0HvvPZydQqr7yvzAeMTauah3E1tvbYCuwEB KcFMWWzr/jVRoa4iqaps7Szm2d4c4bMuhT X-Received: by 2002:a05:6a20:7d8a:b0:398:9c94:2033 with SMTP id adf61e73a8af0-39f2ef837acmr266911637.11.1775161275181; Thu, 02 Apr 2026 13:21:15 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c657dfb7sm3345621a12.24.2026.04.02.13.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 13:21:14 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Oskolkov , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net v3 5/7] net/sched: netem: null-terminate tfifo linear queue tail Date: Thu, 2 Apr 2026 13:19:33 -0700 Message-ID: <20260402202037.176299-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260402202037.176299-1-stephen@networkplumber.org> References: <20260402202037.176299-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When tfifo_enqueue() appends a packet to the linear queue tail, nskb->next is never set to NULL. The list terminates correctly only by accident if the skb arrived with next already NULL. Explicitly null-terminate the tail to prevent list corruption. Fixes: d66280b12bd7 ("net: netem: use a list in addition to rbtree") Signed-off-by: Stephen Hemminger --- net/sched/sch_netem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index b93f0e886a2b..e405bf862163 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -398,6 +398,7 @@ static void tfifo_enqueue(struct sk_buff *nskb, struct Qdisc *sch) q->t_tail->next = nskb; else q->t_head = nskb; + nskb->next = NULL; q->t_tail = nskb; } else { struct rb_node **p = &q->t_root.rb_node, *parent = NULL; -- 2.53.0