public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlo Szelinsky <github@szelinsky.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	Carlo Szelinsky <github@szelinsky.de>
Subject: Re: [PATCH net-next v3 1/3] dt-bindings: net: pse-pd: add poll-interval-ms property
Date: Fri,  3 Apr 2026 15:51:21 +0200	[thread overview]
Message-ID: <20260403135121.3309161-1-github@szelinsky.de> (raw)
In-Reply-To: <20260330-spiritual-placid-jackal-cd4269@quoll>

Hi Krzysztof,

Thanks for the review.

The idea was to let boards tune the poll rate in case I2C bus load
matters, but you're right - that's a driver decision, not a hardware
property. The controller either has an IRQ or it doesn't, and how
often we poll is up to the driver.

I'll drop this patch and the of_property_read_u32() call in patch 2,
and just hardcode the 500ms default in the driver.

Does that work for you? Happy to send v4 with that change.

Thanks,
Carlo

  reply	other threads:[~2026-04-03 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-29 15:31 [PATCH net-next v3 0/3] net: pse-pd: add poll path and LED trigger support Carlo Szelinsky
2026-03-29 15:31 ` [PATCH net-next v3 1/3] dt-bindings: net: pse-pd: add poll-interval-ms property Carlo Szelinsky
2026-03-30  7:10   ` Krzysztof Kozlowski
2026-04-03 13:51     ` Carlo Szelinsky [this message]
2026-03-29 15:31 ` [PATCH net-next v3 2/3] net: pse-pd: add devm_pse_poll_helper() Carlo Szelinsky
2026-03-29 15:31 ` [PATCH net-next v3 3/3] net: pse-pd: add LED trigger support via notification path Carlo Szelinsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260403135121.3309161-1-github@szelinsky.de \
    --to=github@szelinsky.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=kory.maincent@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox