Re: [PATCH v3 10/13] drm: bridge: dw_hdmi: Use drm_connector_helper_hpd_irq_event()

Dmitry Baryshkov
2026-04-28T12:40:33Z

On Fri, Apr 03, 2026 at 06:52:56PM +0000, Jonas Karlman wrote:
> Use drm_connector_helper_hpd_irq_event() or drm_helper_hpd_irq_event()
> depending on if a dw-hdmi connector or bridge is used.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> v3: New patch
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 4d079b689b3b..4a0498922476 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3054,10 +3054,13 @@ static void dw_hdmi_hpd_work(struct work_struct *work)
> {
> struct dw_hdmi *hdmi = container_of(work, struct dw_hdmi, hpd_work.work);
>
> - if (hdmi->bridge.dev) {
> + if (hdmi->connector.dev)
> + drm_connector_helper_hpd_irq_event(&hdmi->connector);
> + else if (hdmi->bridge.dev)
> drm_helper_hpd_irq_event(hdmi->bridge.dev);

Okay, following the comment to the previous patch it should rather
become:

if (hdmi->bridge.dev)
drm_bridge_hpd_notify(&hdmi->bridge, hdmi->last_connector_result);
else if (hdmi->connector.dev)
drm_connector_helper_hpd_irq_event(&hdmi->connector);

> +
> + if (hdmi->bridge.dev)
> drm_bridge_hpd_notify(&hdmi->bridge, hdmi->last_connector_result);
> - }
> }
>
> static irqreturn_t dw_hdmi_irq(int irq, void *dev_id)
> --
> 2.53.0
>

--
With best wishes
Dmitry