[PATCH v2 20/25] perf timechart: Don't pass evsel with sample

Ian Rogers
2026-03-19T23:24:47Z

The sample contains the evsel and so it is unnecessary to pass the
evsel as well.

Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-timechart.c | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index 034e0ba3f9cb..de551c9d3053 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -567,7 +567,6 @@ static const char *cat_backtrace(union perf_event *event,
}

typedef int (*tracepoint_handler)(struct timechart *tchart,
- struct evsel *evsel,
struct perf_sample *sample,
const char *backtrace);

@@ -588,7 +587,7 @@ static int process_sample_event(const struct perf_tool *tool,

if (evsel->handler != NULL) {
tracepoint_handler f = evsel->handler;
- return f(tchart, evsel, sample,
+ return f(tchart, sample,
cat_backtrace(event, sample, machine));
}

@@ -597,7 +596,6 @@ static int process_sample_event(const struct perf_tool *tool,

static int
process_sample_cpu_idle(struct timechart *tchart __maybe_unused,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace __maybe_unused)
{
@@ -613,7 +611,6 @@ process_sample_cpu_idle(struct timechart *tchart __maybe_unused,

static int
process_sample_cpu_frequency(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace __maybe_unused)
{
@@ -626,7 +623,6 @@ process_sample_cpu_frequency(struct timechart *tchart,

static int
process_sample_sched_wakeup(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace)
{
@@ -640,7 +636,6 @@ process_sample_sched_wakeup(struct timechart *tchart,

static int
process_sample_sched_switch(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace)
{
@@ -656,7 +651,6 @@ process_sample_sched_switch(struct timechart *tchart,
#ifdef SUPPORT_OLD_POWER_EVENTS
static int
process_sample_power_start(struct timechart *tchart __maybe_unused,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace __maybe_unused)
{
@@ -669,7 +663,6 @@ process_sample_power_start(struct timechart *tchart __maybe_unused,

static int
process_sample_power_end(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace __maybe_unused)
{
@@ -679,7 +672,6 @@ process_sample_power_end(struct timechart *tchart,

static int
process_sample_power_frequency(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample,
const char *backtrace __maybe_unused)
{
@@ -849,7 +841,6 @@ static int pid_end_io_sample(struct timechart *tchart, int pid, int type,

static int
process_enter_read(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long fd = perf_sample__intval(sample, "fd");
@@ -859,7 +850,6 @@ process_enter_read(struct timechart *tchart,

static int
process_exit_read(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long ret = perf_sample__intval(sample, "ret");
@@ -869,7 +859,6 @@ process_exit_read(struct timechart *tchart,

static int
process_enter_write(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long fd = perf_sample__intval(sample, "fd");
@@ -879,7 +868,6 @@ process_enter_write(struct timechart *tchart,

static int
process_exit_write(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long ret = perf_sample__intval(sample, "ret");
@@ -889,7 +877,6 @@ process_exit_write(struct timechart *tchart,

static int
process_enter_sync(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long fd = perf_sample__intval(sample, "fd");
@@ -899,7 +886,6 @@ process_enter_sync(struct timechart *tchart,

static int
process_exit_sync(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long ret = perf_sample__intval(sample, "ret");
@@ -909,7 +895,6 @@ process_exit_sync(struct timechart *tchart,

static int
process_enter_tx(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long fd = perf_sample__intval(sample, "fd");
@@ -919,7 +904,6 @@ process_enter_tx(struct timechart *tchart,

static int
process_exit_tx(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long ret = perf_sample__intval(sample, "ret");
@@ -929,7 +913,6 @@ process_exit_tx(struct timechart *tchart,

static int
process_enter_rx(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long fd = perf_sample__intval(sample, "fd");
@@ -939,7 +922,6 @@ process_enter_rx(struct timechart *tchart,

static int
process_exit_rx(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long ret = perf_sample__intval(sample, "ret");
@@ -949,7 +931,6 @@ process_exit_rx(struct timechart *tchart,

static int
process_enter_poll(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long fd = perf_sample__intval(sample, "fd");
@@ -959,7 +940,6 @@ process_enter_poll(struct timechart *tchart,

static int
process_exit_poll(struct timechart *tchart,
- struct evsel *evsel __maybe_unused,
struct perf_sample *sample)
{
long ret = perf_sample__intval(sample, "ret");
--
2.53.0.959.g497ff81fa9-goog