From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C8DC358389 for ; Fri, 3 Apr 2026 21:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775251750; cv=none; b=lKf015ae5zWzgQt4esBOaOpRNjn2Lnq7Nxll4uUZCcROeKUCoLkjz0/MeDAt/LYA7IMjAYJPssKlUU1Q4F0W+0BaeknsLtXOt853oUMuXbRzr1ZoppT2h957/7loh59QN+14yPqwqvKJJjcWQbkmnjbiOvD9/4Y5ozXOsU5Ef3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775251750; c=relaxed/simple; bh=Ox3UuQdkMKEHg6JNiBb7kjGglPmNTah85JmC94qLAOw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lfrJsyyYKyP96BkBi1Uvo32nIOMrppCdtlTkVak6kWtX1ePDpfm5YGPG91t0/8rSyeYRfytpMc3fquLWjfIYXqUXeVPq1hWTs/otuum90rV7qWCQH6t/vOokKTtGdtlr9fHL6+FZbLkYIMA1TFWhx35YijgfFKdlmFc54RrI1+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mTYIt6sf; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mTYIt6sf" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-12a693cdf29so3031898c88.0 for ; Fri, 03 Apr 2026 14:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775251749; x=1775856549; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ViRMffOfOvJYtVVzDZMmnf1RPEi0BVW89hSG6CnDeTI=; b=mTYIt6sf07q7oUjVgRD/TxaPLY974m67Y5Y3UWkzJUrG6rN7r60LGZ4NTeWzTXGHOp X13/m5gviRf/S62kv06ZePy80KWRVpqFB4vnYaokwchgI9EKsIplG0Jp3rVfhynQEbhs TQ40ikTAHC6HxoWLQSjJ/eZdSS6RZnewQZ9PGh2ovhcqPQ2psOZirM5VxljLZMP03nc+ 2Ert+gu5dH1mJeBvk3Fqupv803K5Zk9rV034Gv3RCiowpWHIEJd8INKCFEjW5SF5Atic H3QlCBrtbbS93GPnGmdvEwG5ylV6hrPlRfjYgcM3E5E5Tm7044o0ms6qy3tJggUVo1yi y8qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775251749; x=1775856549; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ViRMffOfOvJYtVVzDZMmnf1RPEi0BVW89hSG6CnDeTI=; b=S6gRkh5CgHuVs1nAjUS3XJWM+2A8N49bFwjRLIMuWGDkKzcz1tFNGF5biHbMnRIACq QrMHoIqPB3TRm9zQjI766NVUBuErsWUm4Tu1/NOC2LhyMBH2J+J8m4mIG74dcWBbAzHP bLxFSTM1d38IW97wOyRCt2PA5tOX8GwL4E7YOd7nCu1vAJ+YXGOnRwH30LscL2evb3+F LM6MwCoUdnrrRd91CHp3fV65qjYtpwa4Wj1NLxiFUCgzmrulVvwX0P7wL0h1SdhsXF8G SWjfbsW48rX67/rw5B8sNvR/Xx50H3QzGqFlln9PPtKNpDGY623HbuV6LZ3vGKbWyRWQ vj2g== X-Forwarded-Encrypted: i=1; AJvYcCUocG8dL5OGpEn6HqVY3+xIk32JuDRCgR6hTw3jotq1IN4kea8dehzMsttw9Z3HDq8ZQgvsLTgyujS6bo4=@vger.kernel.org X-Gm-Message-State: AOJu0YwwdzoJ5yn86Cvc8asbnvcVtAny14g7QzqrRE+oifekJjAzf3F3 i7Pvbd0N2gh7oFz46uZ4cNBSDNeJ2JiSX2j5DqhiVnBTbgAAJ8+7mnCe X-Gm-Gg: ATEYQzynL9LH/Cg5vvAQCzmBAYP5fVhk6Jzayl9olS1bWeve8B8xpkxeaSrv+kgw7H1 15exFj2Fx1DT5IOnfxy50U5VXeqD2WfBhwc5DMPO9SK0Rc1Stz3ez90vKf1nyCjMGOOoBN+pDPY 8ysfgZQsRmffdAlNyiP+Rby2AIAuhV0KygMxXLX8cc6Nxm55WHwrtKhujQHi8kffXEzi2NZHHvx CyrahkHTQqbTbWK41Y8lQ58iI7uP/V+DNJ87ByuhD/CGO6LuhbeF4Su3tnPaB94489gcvRWml+u wiRePpBiOJHIT+Vfru5QiettB04G9vt+tFC9YjIQV/qCvHS1IIe2gZGwopdN7UmObYu8reQGTMP Nsg+otY/xTuZzuyM2J5pzAA+bCCqnt3yskqcmrzOsapLEuNMaMZE0WlGzslK9fi8HPmDEiJQ8RU 5IjQroHjOk2qUr3TSzT9xWOOxFRCeqiz91gS4rrr96dpCeIRjYzrTcnDzQ596Q1x/h0KDV0v9E X-Received: by 2002:a05:7022:927:b0:12a:6d05:3941 with SMTP id a92af1059eb24-12bf0599936mr3116316c88.2.1775251748584; Fri, 03 Apr 2026 14:29:08 -0700 (PDT) Received: from ar-pc.lan ([2603:8000:bb00:9b3f:5094:4d4:5bc0:f9f9]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bede7f542sm5462263c88.14.2026.04.03.14.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 14:29:08 -0700 (PDT) From: Aditya Rajan To: dakr@kernel.org, ojeda@kernel.org Cc: abdiel.janulgue@gmail.com, daniel.almeida@collabora.com, robin.murphy@arm.com, a.hindborg@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, aliceryhl@google.com, tmgross@umich.edu, driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Aditya Rajan Subject: [PATCH] rust: dma: return EOVERFLOW instead of ENOMEM on size overflow Date: Fri, 3 Apr 2026 14:28:22 -0700 Message-ID: <20260403212822.294288-1-adi.dev.github@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In alloc_slice_with_attrs(), the checked_mul() guards against arithmetic overflow when computing the total byte size (size_of::() * len). If this overflows, the current code returns ENOMEM, which is misleading -- the system is not out of memory, the requested size simply cannot be represented in a usize. Return EOVERFLOW instead, which accurately describes the failure. This also distinguishes it from the actual allocation failure two lines below, which correctly returns ENOMEM when dma_alloc_attrs() yields a null pointer. Fixes: d9aee73c56ee ("rust: dma: add generalized container for types other than slices") Link: https://lore.kernel.org/all/20260320194626.36263-3-dakr@kernel.org/ Signed-off-by: Aditya Rajan --- rust/kernel/dma.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs index 4995ee5dc689..179bc8832947 100644 --- a/rust/kernel/dma.rs +++ b/rust/kernel/dma.rs @@ -832,7 +832,7 @@ fn alloc_slice_with_attrs( Err(EINVAL)?; } - let size = core::mem::size_of::().checked_mul(len).ok_or(ENOMEM)?; + let size = core::mem::size_of::().checked_mul(len).ok_or(EOVERFLOW)?; let mut dma_handle = 0; // SAFETY: Device pointer is guaranteed as valid by the type invariant on `Device`. let addr = unsafe { -- 2.53.0