From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51789333440 for ; Fri, 3 Apr 2026 23:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775257644; cv=none; b=m2NXirmISDz8nuVwTpN7xO70+vh8N2eyV3yvzkzp3/EtLQ62Q/LGeubkYC+FfPEioO+UcA9CQv0GpitSRjhLf94gvUB39WWqp35tVsmbjbcYd9YpipyjD51zTuCVZ0z//VPeI89BoWvhhk5c9oFotHnEgT0HF94iOa3e1R8u07c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775257644; c=relaxed/simple; bh=w9Up1fKB2GEY6om9s47lJMNvXz+5zEdTXVEOI5jkmIU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JlLlYc4BmiCqY8XafaMEVYKKQ/p7tDTEk4oTcPenghhV8aLbrSi85xBedXppsR6GoeXkD5i+1USK+Cu4S+H92CAn8X/FeFyeQklX7OI2jGrbcf1zJEPthMEuFj8Dh2aSJz9xtv9Fqd2t7NIKHge09C8EyeIhz2+KXaZ5mMcGUYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZfGPaQVy; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZfGPaQVy" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48558d6ef83so23195065e9.3 for ; Fri, 03 Apr 2026 16:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775257640; x=1775862440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LFVf762eS5hmMghaQTstY0t0CTwtXlUiAW2YdJ/qH4Y=; b=ZfGPaQVybBqvtxFRuGhx0wL3V+XXpMaDYShiLea2wwphqYqyvtYv3vqNQm3fEfdkZb KOl8kRP9eygkTVf/S569F46JSShw2Fa5hJgDuhx6u+75ysad3Mc/dyWqFXx57vxfJ2CS DT+/Gu5fqrnz6DgMg9657yf7Fh1QmLbAR8fIXWfd4lHn/xaWFeIbP0AkGK9M3YPyUA+J CLrv28QJYV0d4V1mYg2renK3Luy9Yn2GHZbQ9sC+MLr63VN07AB2eot3mH0vjflBT26B vMLCHitl7t5shed6jmX7dELGBqgVXi6XxoOCDOplqyw2xSSinl9eJG2+hyNmajrGe8BT xgPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775257640; x=1775862440; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LFVf762eS5hmMghaQTstY0t0CTwtXlUiAW2YdJ/qH4Y=; b=Lx4DDPnQ3wykjUAaMmIc7TklY6+C2UkGySPJ8hPc1dN5UwJyQFfAmGts90jhSAhOBn lnP0JGNvbOhGGfkmNbXq+9ae8oLChk2kZFZDxKDPtz3caL3iSTN38+Jq8q6uS8wlConG zcBsYvMmAE/LKQvklVie/VMUrfm5kiDkvi1u5cCiJvpfuKc3hu49vouM3+hZtjdxXnDv wx9DYHyTFCuY/6Q9zICrQ+d3QHWz8xJlxkLqQjhzSfv0aFGsgZ5SoDZZrhd5uDKquYxI SiyHxRZZghaHkUh96sahaTt9T00KK/pKeQBq8odCWVL/242spt2FSyX2rElmrI136+Jd mksw== X-Forwarded-Encrypted: i=1; AJvYcCUVwrKmRLIpAvTfK2LZJXzlLmCHht2T/sfonNCGxXq6VsKchSUpmmpZQKoTLPdJE2th4N8N5m6dQDjj7vA=@vger.kernel.org X-Gm-Message-State: AOJu0YyRHpBH1/PpU1hemiOJOKlshech1AXC/wOEY+TcMMUhlxs5Vdsy NLaVEC5EtTtO3yPwYEsG+F/4nBiL5F0E7O+N5IXYk6ZcJ+fZ2uzdyzMN X-Gm-Gg: AeBDiev4qNdiWPduMgLwzmkeJ+BfgIu0sUGUKhO0xZgx5q08nn77znr5/WtQeUIdni7 +rWQbNIIXFbb5COHeER2eEexba+dOZsG6XeXBBPRCVoN8WXkFkd7ZQ7x0HEyTHjzpAG5/qbKVEY 8p+G8YELyNKGOfKUw6VfL03CNwaLsSSGmuRAPOkNMn2CmMDBi/NSWwaTNvuc7bOG3xNwVZB+TF8 WpzCbi51cSUzQlt6vfJYdMaQTdmIqVyMv/uJp/CtDECIzu5Q4QPP9ejITS/nMy3MBPqUxygrnbc qHF6F1Ijq4Rr7jcKbnTO72XrbCykoP0uH2Z02J5oHBBAga93eHnVKRTv51BUDI2B4GswxE1NC6m HE1iapeTKxKvq1Xg6Aqgt8UiGVJe0EP7Y2iFbUZPGGf/49qrOzaE7Z+U8wGeantHFZHX1y0vEIS vQt3Oi0vuZkBwKQVGY7FpPZ25cI6ed1+aDrLYwF0UaTHGQj2zmx5OqIvjydLpE4aX54RCc9PC8i GeZXGiNADps X-Received: by 2002:a05:6000:2c0a:b0:43d:14cb:8470 with SMTP id ffacd0b85a97d-43d2930630dmr7189067f8f.46.1775257640395; Fri, 03 Apr 2026 16:07:20 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c60a2sm18830924f8f.10.2026.04.03.16.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 16:07:19 -0700 (PDT) From: David Carlier To: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, David Carlier Subject: [PATCH v2 1/3] net: lan966x: fix page_pool error handling in lan966x_fdma_rx_alloc_page_pool() Date: Sat, 4 Apr 2026 00:07:12 +0100 Message-ID: <20260403230714.10667-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit page_pool_create() can return an ERR_PTR on failure. The return value is used unconditionally in the loop that follows, passing the error pointer through xdp_rxq_info_reg_mem_model() into page_pool_use_xdp_mem(), which dereferences it, causing a kernel oops. Add an IS_ERR check after page_pool_create() to return early on failure. Fixes: 11871aba1974 ("net: lan96x: Use page_pool API") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c index 7b6369e43451..34bbcae2f068 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c @@ -92,6 +92,9 @@ static int lan966x_fdma_rx_alloc_page_pool(struct lan966x_rx *rx) rx->page_pool = page_pool_create(&pp_params); + if (unlikely(IS_ERR(rx->page_pool))) + return PTR_ERR(rx->page_pool); + for (int i = 0; i < lan966x->num_phys_ports; ++i) { struct lan966x_port *port; -- 2.53.0