From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2613838A289 for ; Fri, 3 Apr 2026 23:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775257645; cv=none; b=uM68/YGyRMZEdRyPxyAQfHxBmvjshdTC/tHACVn3cnQ4v8zOQKuLpD9I6kqpbC5E+J0PPG10Tpj9U1pHOUGySMEjxoS6FQjLzcHgaD3MmOT52TuMxKI/kYVWDuZivbqmM2jMldUPIIHG9DMsCHrqiIC11U8pmj3NWbRxumK+9Y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775257645; c=relaxed/simple; bh=6XTjPc1Lb1fLIVViZE6tdIzfmgnICDpV2y3bO3Ij+cA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ua1E9M98K6U2B9Qii59HAHMVduL1KdYNgbWFnEkUKl8si+Md67jRYMFAfk+TX2Q7arSJHxo0TMmxYr1tvGvlbNx1u5pqWQV+2/IwVw9qaNL5LFFpLQCnt3IK/eaUbcL/4rnK/Du4FpMIHiWevyvq/ApnBTjG1ZPmqPGRT10TsXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=da8e4PIV; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="da8e4PIV" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43d01d6b50cso2039030f8f.1 for ; Fri, 03 Apr 2026 16:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775257641; x=1775862441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GOEofDb75q5DY4mpfrtmz9omvpmNusDfp4+owj8UO2I=; b=da8e4PIVnCwmwSTT/jl6K36s9yumduItM3wWLz2KwqoHEJ2K4Q0/gZBNbEMFfuBSYn ZKXRy0feNjWR/wXq5DncIeG/+94WeYDhgOgPwIPq34ZgkVT/9JLgfUiUnKJ+5AWqvXmm zJTNExZdGOGUF+Ef5RjpFk6TdquITTE0PV3dSmUptRY4uQouX3L//wEL/ghiUtkiLgtJ husDtx+n6XMq5id4VVVunWJXXaY0Aby4DlrFjOrYnd3gXzQ45z4xdNJP3UUuWGY4IihM NJaw/nJrLPynqtXm0b2arh9UA49sgA9yBr0EQdkrXqzxGxNoH0OO0vPkkQiMDZxPWHbW DQcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775257641; x=1775862441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GOEofDb75q5DY4mpfrtmz9omvpmNusDfp4+owj8UO2I=; b=P85gdFf2NGuH44MTlahHF9IWA21+E/7vRJ1wg71aKZFQdER6vCsxyrO/eQH4V2Mvom X9V4U6dM7xCQ04E8Wzszn2t0xLTHBeAPzItCmZWqj9W3Z3xzWuKxMG1bbUlvk9LnehDt ha1PiYyK1E/Hf45NH91wItz6hS3KqYtYMMhx8FWkxORXtnmi1VTDpniiEPdoSLtHrNts g19Eu5e0NI/SceJKDvn2HU6Xg+cwOfHZl6WRaFEkRlkG5uz/u280Z9oRe6mFAXPEfVOq WlvE1gQ0QkYCytsjwPnMwyqfm1mici6x8aBOInEUngzUU33s+GdsZo8tBm4T/+SWNMJ7 e5Aw== X-Forwarded-Encrypted: i=1; AJvYcCVr54A+rOYuy9Pmq4KW7uo4kBAgO7TRYcePrsz7eT3KLNsveqdxPCsT6F4+X1ogMBXaAIhv+mJUXs0Zh/s=@vger.kernel.org X-Gm-Message-State: AOJu0YwdBLMfgyFklpEstlPl97BpykjdGEWW4tQ0H0Z34GQhcVLPSWCK zD85HrTpKMGxiJ5r4zkg0yWrg7cx1aNJWpOveWZsa7s1Xw3DwV7J3Qky X-Gm-Gg: AeBDietRVyoppGt+U69tLP3AXW9oSecQVd3F5XmezL6Q0fAVRGlsQllcmUWWVedLEkx 5Bt4ZikCHlCzIlXXExcNCwqfMQOZDF0CaDByyv1dqkyvPokOY/ktnux6haZp1VdA2XWvFtZ0OJR JsjGl1ffZYZUlAvhnUxXvxWI+H3SaR6jx8poLNSkpMi9gr0ueoibUhtV39ObyFZJd+Zl4ydXyEg M1mya6+zgzpFuu7e1YYDrR+fADv0htakmEGrXP2KhoV/ZRE/AwpJAkY5MRTPFLsNhgCZ3YqVEmK /vfBMY/935jy+UaL1AU0K3O0STy8YyiKQWszkQ0Nra9FQ2iL0rxTXT3LPRr0C/gJQNtCAKw5LkF DaD/CNvy8Dz5DaJQwzppGSH1gr375zevW2dru88PBVLF2ItuTBb1u6SmEgcSaKb4zGvzYCl9T99 462BAjqP0OmJBsDgsRyeNW/xDliUkDulnH1sQadAlljl2hhfFOpGyOD1gvd3Jah8eZYTGkQXTL4 pyRZ+ZdEQ7j X-Received: by 2002:a5d:588c:0:b0:43c:fbde:310f with SMTP id ffacd0b85a97d-43d292e40bfmr7213997f8f.36.1775257641423; Fri, 03 Apr 2026 16:07:21 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c60a2sm18830924f8f.10.2026.04.03.16.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 16:07:21 -0700 (PDT) From: David Carlier To: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, David Carlier Subject: [PATCH v2 2/3] net: lan966x: fix page pool and resources leak in error paths Date: Sat, 4 Apr 2026 00:07:13 +0100 Message-ID: <20260403230714.10667-2-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260403230714.10667-1-devnexen@gmail.com> References: <20260403230714.10667-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit lan966x_fdma_rx_alloc() creates a page pool but does not destroy it if the subsequent fdma_alloc_coherent() call fails, leaking the pool and leaving a dangling pointer in rx->page_pool. Similarly, lan966x_fdma_init() frees the coherent DMA memory when lan966x_fdma_tx_alloc() fails but does not destroy the page pool that was successfully created by lan966x_fdma_rx_alloc(), leaking it. Add the missing page_pool_destroy() calls in both error paths and NULL-out rx->page_pool after destruction to avoid a dangling pointer. Fixes: 11871aba1974 ("net: lan96x: Use page_pool API") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c index 34bbcae2f068..b985ce64bb50 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c @@ -120,8 +120,11 @@ static int lan966x_fdma_rx_alloc(struct lan966x_rx *rx) return PTR_ERR(rx->page_pool); err = fdma_alloc_coherent(lan966x->dev, fdma); - if (err) + if (err) { + page_pool_destroy(rx->page_pool); + rx->page_pool = NULL; return err; + } fdma_dcbs_init(fdma, FDMA_DCB_INFO_DATAL(fdma->db_size), FDMA_DCB_STATUS_INTR); @@ -958,6 +961,7 @@ int lan966x_fdma_init(struct lan966x *lan966x) err = lan966x_fdma_tx_alloc(&lan966x->tx); if (err) { fdma_free_coherent(lan966x->dev, &lan966x->rx.fdma); + page_pool_destroy(lan966x->rx.page_pool); return err; } -- 2.53.0