public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: linux-staging@lists.linux.dev, Andy Shevchenko <andy@kernel.org>,
	Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3 2/2] media: atomisp: remove redundant call to ia_css_output0_configure()
Date: Fri, 3 Apr 2026 08:42:11 +0200	[thread overview]
Message-ID: <2026040336-humvee-throwback-72cf@gregkh> (raw)
In-Reply-To: <20260402183402.444630-3-azpijr@gmail.com>

On Thu, Apr 02, 2026 at 08:33:45PM +0200, Jose A. Perez de Azpillaga wrote:
> The function configure_isp_from_args() contained a duplicate call to
> ia_css_output0_configure() using the same output frame index. Remove the
> redundant call to simplify the configuration path.

Are you sure the hardware doesn't actually need this called twice?  Lots
of devices need to be told multiple times what to do in order for it to
"stick", hardware is "fun" that way :(

Have you tested this?

thanks,

greg k-h

  reply	other threads:[~2026-04-03  6:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 18:33 [PATCH v3 0/2] media: atomisp: clean up ISP configuration path Jose A. Perez de Azpillaga
2026-04-02 18:33 ` [PATCH v3 1/2] media: atomisp: gate ref and tnr frame config behind ISP enable flags Jose A. Perez de Azpillaga
2026-04-02 18:33 ` [PATCH v3 2/2] media: atomisp: remove redundant call to ia_css_output0_configure() Jose A. Perez de Azpillaga
2026-04-03  6:42   ` Greg Kroah-Hartman [this message]
2026-04-03  9:02     ` Jose A. Perez de Azpillaga
2026-04-03  9:53       ` Greg Kroah-Hartman
2026-04-03 10:14         ` Jose A. Perez de Azpillaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026040336-humvee-throwback-72cf@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andy@kernel.org \
    --cc=azpijr@gmail.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox