From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59EFC34A3A5 for ; Sat, 4 Apr 2026 05:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775281018; cv=none; b=Q7zLEb1JZMRCZo3qxKwR1n6pg/Iqwe62GcbMYNzw+R84tqNH5Lpta5jIBSgXQEb++pW9asOjvKesenJG9RzFdRzIibexbHNiW4LTvVStdqgvBoSuriXudQCeLVLc0BcNw3C7obuc40+l6oouBSBjUv5evD7ZdiUG7wPNucvVIGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775281018; c=relaxed/simple; bh=uGnqBjxqD9968pbq5J8npALEql4QzUTA7OuFcZx36Ys=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IvO+1KA8GsgtTwwMjzFI/Rs8MTMiDgSG9+Hw7rNhOCrNVFQN0+9wwyRvAICE7v3tNrVDC1mY/OEP7U8SV6GSBgzqgkOrle4C9gHQb8Kg0sLHUrNjIpQ3iapx/j7XpHJFMjOR4ur/81xtyCga4TWkB+amSQQ+4gSi69WJUTQu3L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tigCOEqU; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tigCOEqU" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c7422397574so3453310a12.0 for ; Fri, 03 Apr 2026 22:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775281016; x=1775885816; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BbleK2rQ9CB1joEUhU8swEcN4Lv7Hyg2pgINrudzdSE=; b=tigCOEqUHhqei3ZF4PxzXsXgZTkEn4BdMWcyTeG+mOTvA8a+C7TRQ50CWRUenDkj3v dY0dpM2omfx7IQ5xBOt9/VBeT0DZiewNaNwlcbQXJMKz2zCiguwBix+nSEGES4/xSvh4 qet8j1Kj0OKzKKNAY+yUq58ztmUKAKks/wfYgcWoVJxIWt9kpcgjCgZlBLVULySCB+r9 52yecGavZHfUOyq5JxSxe2p2ZjK4wlWNWCdLDsMl5ohZtMJP28UGFUpKYYuD4X2CLMWy 9rmHpbVcSToGXpTorKTCj88R33ks6BAtO68OvJsjdCBZCfnMLeLSY/UG0KxB2TeuOmV7 BvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775281016; x=1775885816; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BbleK2rQ9CB1joEUhU8swEcN4Lv7Hyg2pgINrudzdSE=; b=RscpS3h19qn8huevnrO+Dw+me55WsDQiIdsOiOwfACu4FMyEtv6v+PI4Jf9h2GrVly BIaXXfTrx2vp5gYOyx6AF8pJLGgNiDGDgDTlajv3Z7/qGaFi1PrCgnOXfk6D5WyXfnaO +cSdzrOdOutf5GmKQIlTKK+kF5jA20xX9h4gfOVGlkKn2O2CPy6y3voYqHY9LNxXfvcj idT03EQv4Tjxik4DDeG5sxISULpUeCt+e2BD/oyKDZtyZAadLEl/yXHBXDYBx6J+1P+7 ZTHA/oRhJcoRWX5ZkKyroP9dHZEP7CDLWYodkZpkmb5wRrClpnIRGvRASxcNkKsjOOa1 ERiw== X-Gm-Message-State: AOJu0YwABYH1nUOtleoZ3WNpYbV9LLu+3JvSZs5VDoUHFt4vMr71M9G7 sp/jC20RHVKmqJryxB3LwiKH9XXQ7tjo11W0Y1UbP5cAqEEGdmSznUJ6Ds8vwG+aJd1PgdQogev +7fMyUUKUxNI8jerXzFs23m27AXSZLVG5szu1EKPnBany18m8RjJ1+KcSS6nqZ6aVAT4eJEYc9O hh4VyhMyadfJLgASo9wI6PGziXTydbMAuqntyuGmFKJSEgIb3G X-Received: from pgbbz35.prod.google.com ([2002:a05:6a02:623:b0:c74:2040:e525]) (user=jstultz job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7f8a:b0:398:8e5c:4a94 with SMTP id adf61e73a8af0-39f2f11e04cmr5351925637.54.1775281015378; Fri, 03 Apr 2026 22:36:55 -0700 (PDT) Date: Sat, 4 Apr 2026 05:36:26 +0000 In-Reply-To: <20260404053632.1729280-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260404053632.1729280-1-jstultz@google.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <20260404053632.1729280-10-jstultz@google.com> Subject: [PATCH v27 09/10] sched: Break out core of attach_tasks() helper into sched.h From: John Stultz To: LKML Cc: John Stultz , K Prateek Nayak , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Mel Gorman , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , kuyo chang , hupu , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Pull the core of attach_tasks() out into sched.h so it can be used more generically. Suggested-by: K Prateek Nayak Signed-off-by: John Stultz --- Cc: Joel Fernandes Cc: Qais Yousef Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Mel Gorman Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Metin Kaya Cc: Xuewen Yan Cc: K Prateek Nayak Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Suleiman Souhlal Cc: kuyo chang Cc: hupu Cc: kernel-team@android.com --- kernel/sched/fair.c | 16 +--------------- kernel/sched/sched.h | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 4a6669c517dae..9964670621d8a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9969,21 +9969,7 @@ static int detach_tasks(struct lb_env *env) */ static void attach_tasks(struct lb_env *env) { - struct list_head *tasks = &env->tasks; - struct task_struct *p; - struct rq_flags rf; - - rq_lock(env->dst_rq, &rf); - update_rq_clock(env->dst_rq); - - while (!list_empty(tasks)) { - p = list_first_entry(tasks, struct task_struct, se.group_node); - list_del_init(&p->se.group_node); - - attach_task(env->dst_rq, p); - } - - rq_unlock(env->dst_rq, &rf); + __attach_tasks(env->dst_rq, &env->tasks); } #ifdef CONFIG_NO_HZ_COMMON diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index adefea777e0a5..02e28fd211b76 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3034,6 +3034,25 @@ static inline void attach_one_task(struct rq *rq, struct task_struct *p) attach_task(rq, p); } +/* + * __attach_tasks() - attaches a list of tasks (using se.group_node) to + * the new rq + */ +static inline void __attach_tasks(struct rq *rq, struct list_head *tasks) +{ + guard(rq_lock)(rq); + update_rq_clock(rq); + + while (!list_empty(tasks)) { + struct task_struct *p; + + p = list_first_entry(tasks, struct task_struct, se.group_node); + list_del_init(&p->se.group_node); + + attach_task(rq, p); + } +} + #ifdef CONFIG_PREEMPT_RT # define SCHED_NR_MIGRATE_BREAK 8 #else -- 2.53.0.1213.gd9a14994de-goog