From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EC0F2BEC3F for ; Sat, 4 Apr 2026 18:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775328932; cv=none; b=LQeoLwcysENt7bxyKAYDcYk14EQQkFS/npGxXUdCYFexalRfScD6kEk4pAqd4BI0iB7X6Bj/vgTwzdTd9RlN++rMafnng6bFfA/Or6qVFo4hNFNbw4NyiEny9FxH4OAXnrig6ieNoGPug+RAifAMmjIeeDqLMcLK7VpRZTrciwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775328932; c=relaxed/simple; bh=Slx7eSZqFhCa42JJBZzkCBuoEeNNx13+E+beeKgam7w=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=aTaSQmkeZ7E5grWtYNqOgVuAx6zyl96Rjib70ChoZdsimdI7T1W1nwlAan7aQ4v2zlfxV+l/2raWAdZ2ApB0DAy15zunJmAMmbfZedizS0UYvuXbzGQQ9TbhtW/Y7eRls9t+n+jD0/nZqoK8Aien9VeQmCsTO4oxaVXLr/CcE9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O8gB6ZRm; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O8gB6ZRm" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488a04f39d2so11134575e9.1 for ; Sat, 04 Apr 2026 11:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775328929; x=1775933729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=vuojKUDIjsIoi1AVAujgC/QVlgeGpJowX7gCMqW5wRI=; b=O8gB6ZRmkhE3s5IkQxoI2jxAyj1K6z9i1w5KRccO0PHH+H3+yU69sYSLUfSFZ90Lnt tOuVhYV6TspF7/kv+gCd96ZMekR0X0Eu6zN0c13Puea32gHmF9xXpkXMFV52em8Ya33e yFSgov96cp0t2amMHXvuVIP0MYsB4KjQmC4Dvc524eD9ShyltModYwvp/qlw20u46NiU yCYPXkc717Hrb+7lvJpnm2n89t8vJR8BLyXpPjo6ip/vsKYy5E2pc/QyNeHEy31LrhoZ qPFCaOyjXRkSNE17QVS6bSa70WfZwDbPVs1suMCRFXRWitjKZPJ4aNvQ8pk4x5EHIanP QdLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775328929; x=1775933729; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vuojKUDIjsIoi1AVAujgC/QVlgeGpJowX7gCMqW5wRI=; b=nOUt4RsBdRhODxxlfa+ZyXzlvg+DZ+SSDIe5IVY3e1xlGeEh1iCOFnlT8+CyMN0KBt LBWuILEZOXE/VxBZEvxYsjXRbVDI6/zD5LA6bs7jfvNZiXAFE/cpSHp/2t4slqusGTNx k9g539Z4BWXawxr/um6WG4GRlT5qd2GHNrKLvhdsd5G0sdGkHeeQYAlHI52EVMFIQyEz QQE4bf7uBuuPumiN5Tyj0Y84p/Nj+T3FPliBuTtR64TgpzgqCrvNbmeLT+s83G3RnAe2 jFKvdsJDPVXfioTSJzcsYXOvhTggGek2T8GC8oJ1p3K0bUPMx9+PHwI3TdOGAlHbLFF6 DNFA== X-Forwarded-Encrypted: i=1; AJvYcCWyeC1Mu/44QxwaI3p8GQbzsb6UtkmXMVUIfa0Y81NkE7GcNvJX9ATYunuH3fmd9RHIJcn+spfu2Urs/xA=@vger.kernel.org X-Gm-Message-State: AOJu0YyF6YH4opkKw3Asb1yJYfU49jRndJeCWiFOOKZ2eU8is+stA/dl 7qtc3+4GutsuU7+dwgVd5XFqs+KQfhRofjo0n1XJCiIHRMILHQoSj/1P X-Gm-Gg: AeBDieuIOA8hc5BIRzV3GNHXk3OymzpuuKxU8d4nKuu62KamzrSgcwLONX2tJXLPxci 67+5SsmZku5JCktnuQwB49IbhPpFITXXb9mRVFDKiz9gP5VcHFE0Ks4drsn4y/1n/Wt4pWu/RlI lqiKqFenQW9c+i4WWelMfAaFTvdCRZS/N+z5w7OPiFZyP9DByVHWlEQK9d5JWCocM0M+qad2jJO atuTfVwuHxU6iM5zm3dBVS+kvmZqpvkQHP0xho42crspr630GLhk2jLOiYV2ovtvnPjLY5frRaU jL/Id46vvU6VTHiObImmIi8V4w4irA3O3Wv7eGqdN7smYEom+WL09wDnFkMTRMpOVKD3NIyQweW dptD5eKwF/jLWc512hma0zAWHuWneDedoliKqya9HapUquxQVmph5UtfUWbZJhBGKG6MLUtM0Hi QdeSI5iDEATEeKsS2l61RRr0+mxfdjIKw3ZGndzOKvJRfypFSuWCLnHRZgu1k+ X-Received: by 2002:a05:600c:630a:b0:488:8840:e5ae with SMTP id 5b1f17b1804b1-488997eed8bmr112205745e9.24.1775328928602; Sat, 04 Apr 2026 11:55:28 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:2817:10ce:a533:4101]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4888a65635fsm231622955e9.6.2026.04.04.11.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 11:55:28 -0700 (PDT) From: Osama Abdelkader To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Vladimir Kondratiev , Osama Abdelkader , Thomas Gleixner , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated Date: Sat, 4 Apr 2026 20:55:20 +0200 Message-ID: <20260404185522.21767-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack or scs_alloc return NULL, call panic() in this case. Signed-off-by: Osama Abdelkader --- v2: - call panic() in place instead of return -ENOMEM --- arch/riscv/kernel/irq.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c index b6af20bc300f..017d42e778be 100644 --- a/arch/riscv/kernel/irq.c +++ b/arch/riscv/kernel/irq.c @@ -75,28 +75,34 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); #endif -static void init_irq_scs(void) +static void __init init_irq_scs(void) { int cpu; + void *s; if (!scs_is_enabled()) return; - for_each_possible_cpu(cpu) - per_cpu(irq_shadow_call_stack_ptr, cpu) = - scs_alloc(cpu_to_node(cpu)); + for_each_possible_cpu(cpu) { + s = scs_alloc(cpu_to_node(cpu)); + if (!s) + panic("Failed to allocate IRQ shadow call stack resources\n"); + per_cpu(irq_shadow_call_stack_ptr, cpu) = s; + } } DEFINE_PER_CPU(ulong *, irq_stack_ptr); #ifdef CONFIG_VMAP_STACK -static void init_irq_stacks(void) +static void __init init_irq_stacks(void) { int cpu; ulong *p; for_each_possible_cpu(cpu) { p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu)); + if (!p) + panic("Failed to allocate IRQ stack resources\n"); per_cpu(irq_stack_ptr, cpu) = p; } } @@ -104,7 +110,7 @@ static void init_irq_stacks(void) /* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */ DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack); -static void init_irq_stacks(void) +static void __init init_irq_stacks(void) { int cpu; @@ -129,8 +135,8 @@ void do_softirq_own_stack(void) #endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */ #else -static void init_irq_scs(void) {} -static void init_irq_stacks(void) {} +static void __init init_irq_scs(void) {} +static void __init init_irq_stacks(void) {} #endif /* CONFIG_IRQ_STACKS */ int arch_show_interrupts(struct seq_file *p, int prec) -- 2.43.0