[PATCH] ksmbd: Remove unnecessary selection of CRYPTO_ECB

[PATCH] ksmbd: Remove unnecessary selection of CRYPTO_ECB

[Eric Biggers]

Since the SMB server never uses any ecb(...) algorithm from the
crypto_skcipher API, selecting CRYPTO_ECB is unnecessary.

Remove it along with the unused CRYPTO_BLK_* constants.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---

This patch is targeting the ksmbd tree.

 fs/smb/server/Kconfig      | 1 -
 fs/smb/server/crypto_ctx.h | 5 -----
 fs/smb/server/server.c     | 1 -
 3 files changed, 7 deletions(-)

diff --git a/fs/smb/server/Kconfig b/fs/smb/server/Kconfig
index 5c77c5552ed8a..37387410e5bb3 100644
--- a/fs/smb/server/Kconfig
+++ b/fs/smb/server/Kconfig
@@ -5,11 +5,10 @@ config SMB_SERVER
 	depends on FILE_LOCKING
 	select NLS
 	select NLS_UTF8
 	select NLS_UCS2_UTILS
 	select CRYPTO
-	select CRYPTO_ECB
 	select CRYPTO_LIB_ARC4
 	select CRYPTO_LIB_DES
 	select CRYPTO_LIB_MD5
 	select CRYPTO_LIB_SHA256
 	select CRYPTO_LIB_SHA512
diff --git a/fs/smb/server/crypto_ctx.h b/fs/smb/server/crypto_ctx.h
index b9476ed520ae4..27fd553d10aab 100644
--- a/fs/smb/server/crypto_ctx.h
+++ b/fs/smb/server/crypto_ctx.h
@@ -18,15 +18,10 @@ enum {
 	CRYPTO_AEAD_AES_GCM = 16,
 	CRYPTO_AEAD_AES_CCM,
 	CRYPTO_AEAD_MAX,
 };
 
-enum {
-	CRYPTO_BLK_ECBDES	= 32,
-	CRYPTO_BLK_MAX,
-};
-
 struct ksmbd_crypto_ctx {
 	struct list_head		list;
 
 	struct shash_desc		*desc[CRYPTO_SHASH_MAX];
 	struct crypto_aead		*ccmaes[CRYPTO_AEAD_MAX];
diff --git a/fs/smb/server/server.c b/fs/smb/server/server.c
index 422d9d9782859..d8893079abdb5 100644
--- a/fs/smb/server/server.c
+++ b/fs/smb/server/server.c
@@ -627,11 +627,10 @@ static void __exit ksmbd_server_exit(void)
 }
 
 MODULE_AUTHOR("Namjae Jeon <linkinjeon@kernel.org>");
 MODULE_DESCRIPTION("Linux kernel CIFS/SMB SERVER");
 MODULE_LICENSE("GPL");
-MODULE_SOFTDEP("pre: ecb");
 MODULE_SOFTDEP("pre: nls");
 MODULE_SOFTDEP("pre: aes");
 MODULE_SOFTDEP("pre: cmac");
 MODULE_SOFTDEP("pre: aead2");
 MODULE_SOFTDEP("pre: ccm");

base-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979
-- 
2.53.0

Re: [PATCH] ksmbd: Remove unnecessary selection of CRYPTO_ECB

[Namjae Jeon]

On Sun, Apr 5, 2026 at 4:45 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> Since the SMB server never uses any ecb(...) algorithm from the
> crypto_skcipher API, selecting CRYPTO_ECB is unnecessary.
>
> Remove it along with the unused CRYPTO_BLK_* constants.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Applied it to #ksmbd-for-next-next.
Thanks!