From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52AEA17A30A; Sat, 4 Apr 2026 20:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775332926; cv=none; b=ItIFJrH5f79QOyjJxeDJGPSl8WrmyKzd9vtOprp+iGS4QyWWmwiRH0h5LbDKY8QgFaRBNaC9XZtSYM+nvOpdbPvo1N3Z8UPR+95NtpTRXl+j2bOSEaeLpTXsemPkfdY5GYXU1mRPuPtHMLGO3lBjGLAYZkIai6sn4diqIPVMZUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775332926; c=relaxed/simple; bh=/JiyVizUMe9wSdqRZWW6fVbbnNxTVMDWZytcmkzNmcU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DytGpkCNj79Kk41Udw1LYZ4R/WADtdnzZQbr1ZmDJbXxLUEFpTkIBGZPOT59hTVIq+Oqq+a4wDeVsfgUOH+o/gmTCs8Shz2FeBpi2BHvYgsritC7iMO0x9LVdKo1BCPHa22pl1chd60U1tCfrsw29yi7g4JLSoYYh2wfs72/6kU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lrA5QUGy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lrA5QUGy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 560C5C19421; Sat, 4 Apr 2026 20:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775332925; bh=/JiyVizUMe9wSdqRZWW6fVbbnNxTVMDWZytcmkzNmcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lrA5QUGyJQ8bVQcBRmkgwJI7ZwBM9sJNU5eBGGV8qZnyWKaSUSqyBzu6LpN9GvD2U 6PWqlaeorIT4jytNB3eRyedgLHY4vnZ6k6bamJalIPDMDVKAkMXdqMHg8VkCPk0dEQ qwq2SnCL0oc8kudZeUxGXqaFCTXar2+nndGXZcRnaxRguhK5GF4JD8E9XaMQvYQqZC EC3Tb2Z2do5VI+617ig9E5WWJc7V2bUnhUoVMAxoyrAwK/SW3I+5+Du2twxoMyWjf9 cXG8+wX5CFQV5LXDpLImwNq0Qy+fCoBrWJbb4+EMp0GEby3i0RtmKpBUCX1He7oBSi jW3NCs6DwbfUA== From: SeongJae Park To: Ravi Jonnalagadda Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, bijan311@gmail.com, ajayjoshi@micron.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, kernel test robot Subject: Re: [PATCH v5 1/1] mm/damon: add node_eligible_mem_bp and node_ineligible_mem_bp goal metrics Date: Sat, 4 Apr 2026 13:01:57 -0700 Message-ID: <20260404200158.86020-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260404012215.1539-2-ravis.opensrc@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 3 Apr 2026 18:22:15 -0700 Ravi Jonnalagadda wrote: > Add new quota goal metrics for memory tiering that track scheme-eligible > memory distribution across NUMA nodes: > > - DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP: ratio of eligible memory on a node > - DAMOS_QUOTA_NODE_INELIGIBLE_MEM_BP: ratio of ineligible memory on a > node > > These complementary metrics enable push-pull migration schemes that > maintain a target memory distribution across different NUMA nodes > representing different memory tiers, based on access patterns defined > by each scheme. > > The metrics iterate scheme-eligible regions and use damon_get_folio() > to determine NUMA node placement of each folio, calculating the ratio > of eligible memory on the specified node versus total eligible memory. > > The implementation is guarded by CONFIG_DAMON_PADDR since damon_get_folio() > is only available when physical address space monitoring is enabled. > > Suggested-by: SeongJae Park > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202603251034.978zcsQ2-lkp@intel.com/ I think you don't need to add the Reported-by: and Closes: for bug that found before this patch is merged. Could you please drop those? > Signed-off-by: Ravi Jonnalagadda > --- > include/linux/damon.h | 6 ++ > mm/damon/core.c | 186 ++++++++++++++++++++++++++++++++++++--- > mm/damon/sysfs-schemes.c | 12 +++ > 3 files changed, 190 insertions(+), 14 deletions(-) [...] The code changes look good to me. But, as I replied to the cover letter, I'd like to get sashiko review before giving my Reviewed-by:. Could you please rebase this to the latest mm-new and repost for getting the sashiko review? Thanks, SJ