From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B805C355F36 for ; Sat, 4 Apr 2026 23:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775344997; cv=none; b=O6qeo1+O4HeVQXXOHbt0ImR+B77mRtGurkzhNuiQy0ClHK+EKBEMACeYyqztKbDJtvXgVkAvSneM/qo6jI34MxAckdjt215rkehPc9ulNDm0sEq9mHFUVaxDpBD9RJLBY0EPvgw7+ivpodt7Q7RSAXwLXWxrBjMHo/NQbHdORZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775344997; c=relaxed/simple; bh=aHr247WZgADKTKUzBygaaf2YQeBar4PSJ17AIEQoyVc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hBoQIKNIdTVFebdAnv83+DzmcXqQ2Dz9W8H9FYEQpGa8WMNezg82JKN5m67AKradPqgartUROxAOCXMU64ou8y0Pfr838mDW9sgUrujKXBAggH8P8j9M/FxJMMmcMhul0yIG3FixVhp5ZA8dZWUTKkB2qV3H5UFUNlyyFLd6fNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qjEAwxU/; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qjEAwxU/" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-56d8d479149so1005580e0c.2 for ; Sat, 04 Apr 2026 16:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775344993; x=1775949793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QhxQ4oVxg7wwJH0gj6MCRdyLZTtveOYtZsme5m0GCsY=; b=qjEAwxU/+pMtqqG6yD8PaeToaNdEHO8Ss00cf8WGGVSDRu5H0sx3GCbNCALfduZ8WW RKreUQSFJNLA9Fyi2aWm4QUhpuqNFvI/AcmwiGhQjPMAH7mguN8CxheXEriit6jNsb4j rkqlk1h4xCXs6wCeWXZbRPjbpVy4CS+J/mCvB/RO//tk2bKhQHCBLhVb2bLS4mXrW/Yb 1JJgbcxjGmP0et82y82Xu1jm3WCW7miViJRhBXKLqSXsR+XPvEKSYUZyuc5ivj0YMCCv XSvqHgIuW1Tl+1koD3bRw13AKdCvQCBB1dSMsrkGtsTWORMB2LG89gH6YSan37WAmYvc hehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775344993; x=1775949793; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QhxQ4oVxg7wwJH0gj6MCRdyLZTtveOYtZsme5m0GCsY=; b=B+PXy7XckNaLiUC6vsgepbsnJ1HTa+ebwWDgq0dxc0A/W42ypo/1Eu4CKG50i8r1+E fXUj8Z65fzvPAq0kYIwcGAbw0bKmCPjAW/ZmOy//Iuf9Kix5SELGWnRz97MStTTLY9KN ZuGqXdZDon3KWJeyNnYgEK/aVBCEkqYKoCAfkrwJ39r3WHpwqWxVP9uSnFiBvS3HPrIo gWspSEqCTSRz8fA3YsHnhqHrgupLiOdInZcRm/Zjd1zvV00CleH23H7064OfgRZ7Lv1J FcjN/Zvmq3JiXFVZOETnqihulDhVCTwaFlJI9arZDqmnTnmeVmq04jQ6d0p+tGM4sab2 EWEA== X-Forwarded-Encrypted: i=1; AJvYcCVvEFnlNx2imBWQpEXr3+12DTuU4GQSO74Qh8NxU1eGoVW5M5KPytG1xut63zTz+eu4lviPaTc0TwSOxag=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy0+nh/cTFXFRXxn6/mpuOeMF+WbRKBbn9gyLAipxWLBmtZtWQ jQLNDUuMMGhsc1rkz/i5zUEZQhGaubPn/UmweNM9y6a2/jMxGQBOdvIKV9BuxmAd X-Gm-Gg: AeBDievmnZY1q82l3/kD2s6eWvrYUQ0Y6HJf/JiVD9NkEY87en9XlhH10XWFle29BhN 3c8uWEQMOlQFry9HBa5H9EfYSu3mR7M1YyQUtLqe1tiBOihlB6+hcPA/pxU0BuJMDJhmlov9nnB oGuTAj0/slA0UajvP3qv46UXO1kNa3syz6DyoA1BdBuOuIZfCfbuIGEfHVlaRdsx4GfBLh5MkPp 8msuWpz0Zb1ReBPdAW8r2XNG9WyQP/QT+LSIeeDLYMv0ExzJ3nzTtJagkd+AdirlUBNCdS7Q4NK +8MQhpV1oCXvvqzbTCi97lzp0sJ+BnKR/MKfYL6EPJ08J6ujM3FBzaC3/aPOd9HxQZhORLOM+RH WSyp9bLauRdw+wIpeTu7elRiCxjInCyCu0rEgzp9bVYZViKmEDQlLmIxEi8UKXNc68dClvnqHT8 HC0HVGzQOLBBViU8Ct7F8035vOw3XdfCi7+G0viXpE X-Received: by 2002:a05:6122:1d15:b0:56b:a673:27bb with SMTP id 71dfb90a1353d-56dab90d4f7mr2447140e0c.8.1775344993509; Sat, 04 Apr 2026 16:23:13 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.15]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9bae1117sm11228422e0c.7.2026.04.04.16.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 16:23:13 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Delene Tchio Romuald , stable@vger.kernel.org Subject: [PATCH] staging: greybus: fix size_t underflow in cap_get_ims_certificate() Date: Sun, 5 Apr 2026 00:22:42 +0100 Message-ID: <20260404232242.68423-1-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In cap_get_ims_certificate(), the certificate size is computed as: *size = op->response->payload_size - sizeof(*response); Both operands are size_t (unsigned), so if a malformed Greybus module sends a response with payload_size smaller than sizeof(*response), the subtraction wraps to a very large value. The subsequent memcpy() then causes a heap buffer overflow. Add a payload size validation before the subtraction to ensure the response is large enough to contain the fixed-size response header. Cc: stable@vger.kernel.org Signed-off-by: Delene Tchio Romuald --- drivers/staging/greybus/authentication.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c index 97b9937bb..1c14ad184 100644 --- a/drivers/staging/greybus/authentication.c +++ b/drivers/staging/greybus/authentication.c @@ -132,6 +132,12 @@ static int cap_get_ims_certificate(struct gb_cap *cap, u32 class, u32 id, response = op->response->payload; *result = response->result_code; + + if (op->response->payload_size < sizeof(*response)) { + ret = -EINVAL; + goto done; + } + *size = op->response->payload_size - sizeof(*response); memcpy(certificate, response->certificate, *size); -- 2.43.0