From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8013C2E for ; Sat, 4 Apr 2026 23:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775346328; cv=none; b=ZyG4qyn7k4jboEScXuS9qLQ5O0cQjfmdEuAO/isNpymeTej7xEFjdKK1/AdhZ+50ZUivQEu3ZOgPFnh5EocQW+sVZoztItSzw7x0tv1TqoJe35vszATjhalCgUW0CRhdgBakm71+LduldHHis00Yvdnow8yO3Fbkj/a8xls7v1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775346328; c=relaxed/simple; bh=TWi0XDqLrqy0ypbn9Sd51p9cUWaA/5BD8JIRlXP6gvg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ggIsPjcFIwpB5iCzPdWkZmPX9f9vPymc+owD5cg8V/HB96/Pg0MdsDn2mdVaQ6RP30pnq6jMqUZJisbfXcPJWIVY21BXMOqHjEERmHg3+qrGaDW/qKTgRuuoxsHh/ZpyTZyfZVF84C+0w5S2IOBjqPmsTjEK3Gc9bHbGI7HdgkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KDWMYQPj; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KDWMYQPj" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775346323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=c3G4IaxkFcmqbQ4LYPwOZ+6xz1d+fbfGkXZaawTfXHM=; b=KDWMYQPj8S+Oy2eEsscW2uGIbNGk46PkRKWvyOQdxexfg/bLyqYPZCOm+ASNMk1a03A1Yt eh5IiWO9f7qZgMDs0lG5nrR57ZF4yBVXnQPzuGZynVl5LGAQqIBLLbWlZ+fZvSM0c57a/h 2CG9+MyPSYdS5FBHVIuzkXCIkakTFzk= From: Thorsten Blum To: Sudip Mukherjee Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH] parport: replace kmalloc + strcpy with kstrdup in parse_data Date: Sun, 5 Apr 2026 01:44:57 +0200 Message-ID: <20260404234456.958148-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1031; i=thorsten.blum@linux.dev; h=from:subject; bh=TWi0XDqLrqy0ypbn9Sd51p9cUWaA/5BD8JIRlXP6gvg=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJkXF1XcmTyFkTPK8zHT6TBvW2/x2QeP11ypCF+izfpG6 bHjquw7HaUsDGJcDLJiiiwPZv2Y4VtaU7nJJGInzBxWJpAhDFycAjCRa9sYGZbUvy+8U1Mn92EV u2+XcFxn3cFU58Cw8xtMI3zslr3de4qR4Yf8eet9V36c0JpskbBBg8FyW8DRLHuxhT617949+9T NyAQA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace kmalloc() followed by strcpy() with a single call to kstrdup() to simplify parse_data(). Signed-off-by: Thorsten Blum --- drivers/parport/probe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c index 5d1b9aacb130..bf9d81c0abaf 100644 --- a/drivers/parport/probe.c +++ b/drivers/parport/probe.c @@ -52,7 +52,7 @@ static void pretty_print(struct parport *port, int device) static void parse_data(struct parport *port, int device, char *str) { - char *txt = kmalloc(strlen(str)+1, GFP_KERNEL); + char *txt = kstrdup(str, GFP_KERNEL); char *p = txt, *q; int guessed_class = PARPORT_CLASS_UNSPEC; struct parport_device_info *info = &port->probe_info[device + 1]; @@ -61,7 +61,6 @@ static void parse_data(struct parport *port, int device, char *str) pr_warn("%s probe: memory squeeze\n", port->name); return; } - strcpy(txt, str); while (p) { char *sep; q = strchr(p, ';');