* [PATCH] parport: replace kmalloc + strcpy with kstrdup in parse_data
@ 2026-04-04 23:44 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2026-04-04 23:44 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Thorsten Blum, linux-kernel
Replace kmalloc() followed by strcpy() with a single call to kstrdup()
to simplify parse_data().
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/parport/probe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c
index 5d1b9aacb130..bf9d81c0abaf 100644
--- a/drivers/parport/probe.c
+++ b/drivers/parport/probe.c
@@ -52,7 +52,7 @@ static void pretty_print(struct parport *port, int device)
static void parse_data(struct parport *port, int device, char *str)
{
- char *txt = kmalloc(strlen(str)+1, GFP_KERNEL);
+ char *txt = kstrdup(str, GFP_KERNEL);
char *p = txt, *q;
int guessed_class = PARPORT_CLASS_UNSPEC;
struct parport_device_info *info = &port->probe_info[device + 1];
@@ -61,7 +61,6 @@ static void parse_data(struct parport *port, int device, char *str)
pr_warn("%s probe: memory squeeze\n", port->name);
return;
}
- strcpy(txt, str);
while (p) {
char *sep;
q = strchr(p, ';');
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-04-04 23:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-04 23:44 [PATCH] parport: replace kmalloc + strcpy with kstrdup in parse_data Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox