From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4846369967 for ; Sun, 5 Apr 2026 05:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775368369; cv=none; b=BxbKLSwd3AMTbQHxKdkXvpShlIzBLGko7eI4lVKO3F7mY8zdu0p/VCyLNPPNlstn5kUxtxT6rur+pO9WRzqWV/Itz8Gj0tP2TqBGn6/9V7o77KXWl8E48YBXmc1HiNDs4YmyCThpL+4sOFF4Li3aYdN8ytnH0FFTQftleaVDxcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775368369; c=relaxed/simple; bh=0tTTbC/ebQuK84WVTeLENCfRkHSaH8uFUAbuP1W5FdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fqflyov/W791DYmOKdVp2pP0OkJHWcVMSJLD7TVW9Z/11VS2+LRfuYbTCxRyGPM4pFLR+Cgv5mZh6IQGqvGi2/oazMzj5Zv8F6A2N0HNTF4Tp5aAS7ndd+OwG9JBUEAgtT7WKfzzdrmbUGP1CpusgF0qyKgjBHGf6Jo5l0GGask= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GZ/KsOGd; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GZ/KsOGd" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so30316995e9.1 for ; Sat, 04 Apr 2026 22:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775368366; x=1775973166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e7nMVD+VOcNWUuhtqvwltUnQm85Jrmb6cAMzCcy5HCI=; b=GZ/KsOGd41hD4c3HUTOhAwJATP8z7SYWev84NsPtekiKicIwETvw4yv3KjqijLEH5t MTH6+iViXXozluCaWxBqF/H0Iimx0EDH7S9wSYFvvDNJ9zWBduxkKOq4+KaE42IZsNTN wiU7aMAQDQB+KUIaAFljXeX1fnX4PHnsyZcQ/9IUE2br5gtidcNJkQiQxuahDTEavybS cGU5jW+CHi8mfcVpfT5WxaGZyVO787I6T8QOqCRWkcrMIUIGQ3qFD3vUo1bcklNNRhNY wWdv6ukY+0XJxgyglEpY/6X4oiBnFGpOq6nQCtzoVNzJT+nJjYaY3wiv9Smc593xVcQk qGMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775368366; x=1775973166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e7nMVD+VOcNWUuhtqvwltUnQm85Jrmb6cAMzCcy5HCI=; b=fUZ3pomJ8gRlJ9qvlvcnxL9PJldln0a520/e0Z6mCS2p/0PyJ6jqk2i3xf0Vg4TxYD xHgtZH4Qn/vlsDP0c8kkTa9xcr/fwqrGcTGVLMAx0Kr9pwRHpoAEoDw85oiCk8R2f1mo Fo7HU3SvDU5EACtbjF6YpUu58fSXsHwDnHv3oxEiBPsdplQesUw4vCOfg3oHjDjMleLg 3Par+WqsZq0oR0oqJYz33TTn7ez1ONJMqBriunE2QcKuZk7XlvKqOlZyijTA+/pXjv6f 57H26H+LwGGxvsi38Kn3PCTWBdbiegc8PWJVG8zO1AG4fKUOcqUr8V7U3S5trymuEE1l 2+NQ== X-Forwarded-Encrypted: i=1; AJvYcCUndWP15/Po/VcP0d0KPtx6utsb7UUy7z+IYCZbKNhkLqC+mDI2Dt7shQYlUYMjTgOP/ydY9P3cSm5Ea4o=@vger.kernel.org X-Gm-Message-State: AOJu0YxWFBSYcadp7xTPW3DBiN/qcK9v6OzbU1ror5o89sPpCQwg8jr9 OcVHuatRBGfwb8Uk+5sf2F82/ezEGpM/Xb1KVFPHS3DdZzanWpQn8Qif X-Gm-Gg: AeBDievLc+A/8q+Z+upH43gP5sGIsjM5PvCBKTWAZ92Hq584KRGyvdB5ub7ngKg54pX 6qF0+jFOqko2mPCNur1lkelO+NYbgtEp1OwHlrz92qGrAl655aSoBT/HZYiNECVZDpH2JaB3Flm /GIcizmNzgJHCKod9xpfapHoru3Y4ebvjfjYZ5IzPjYggVJVxLQ3Y66hhTAFGtHMeEo+HcLbFff fG5G5RBC4UmbqtXs2PIoGgIn6n9TDXL7TwX230PxvSRatImdWjMc1FBqR5A0EdHXxdxHO7GL07W v+dd54kTFMlpxAp9P3iWad1iI4Fbg14am3EltYAY4xoGTI6pg24mQpggvn2HmcjoWWHrNxPCX16 sHUQ94RxYD1f7JEjyo4jvlBTsqq2ES0304vNt4rRMIPWin2QQqCjrRQ8Gynryv0oCGh70FR11X0 lPo6sFOLgjn+CvAGUQ4lIWKe1F0ugqNd8SbLFdvvs1IAv0Q4Mb8rxbIzgD7xhQ3uX208WzE9BGq nWtdFXJPc3X X-Received: by 2002:a05:600c:4f87:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-488994a77b1mr117703095e9.12.1775368366063; Sat, 04 Apr 2026 22:52:46 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48899e960a7sm55847465e9.27.2026.04.04.22.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 22:52:45 -0700 (PDT) From: David Carlier To: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, David Carlier Subject: [PATCH net v3 v3 1/3] net: lan966x: fix page_pool error handling in lan966x_fdma_rx_alloc_page_pool() Date: Sun, 5 Apr 2026 06:52:39 +0100 Message-ID: <20260405055241.35767-2-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260405055241.35767-1-devnexen@gmail.com> References: <20260405055241.35767-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit page_pool_create() can return an ERR_PTR on failure. The return value is used unconditionally in the loop that follows, passing the error pointer through xdp_rxq_info_reg_mem_model() into page_pool_use_xdp_mem(), which dereferences it, causing a kernel oops. Add an IS_ERR check after page_pool_create() to return early on failure. Fixes: 11871aba1974 ("net: lan96x: Use page_pool API") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c index 7b6369e43451..74851c63e46a 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c @@ -91,6 +91,8 @@ static int lan966x_fdma_rx_alloc_page_pool(struct lan966x_rx *rx) pp_params.dma_dir = DMA_BIDIRECTIONAL; rx->page_pool = page_pool_create(&pp_params); + if (unlikely(IS_ERR(rx->page_pool))) + return PTR_ERR(rx->page_pool); for (int i = 0; i < lan966x->num_phys_ports; ++i) { struct lan966x_port *port; -- 2.53.0