From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 479B933EAED for ; Sun, 5 Apr 2026 10:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775384254; cv=none; b=isXrTewuQw3oXc1Ybln5p5BrZFWup5+LlIJz8kIHEfw2cxC2zUC9bSj4L2GEOQ2T2CPEasVcNyQWSM692oVo272RCQvzFpo8f6roUsV5ZOBCLwC2xieG7bVtHQlBdLLRiuw/6rdPG4+Np9SmIQ2QXCLNdxM2BeXRmw7cAXEY/E4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775384254; c=relaxed/simple; bh=NxncsbAdSLuMbc17VvMAI5fr/no/7/aP8bRKwl8YQsM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LbLaoqFPXEdKjTDnU9Ed48MtPCWKYjJHg370MKIHc9ts1HQ0W1gqBEDMOYnA2JbXb1stbp4AikalYXwZo/R+3smfsYxYr0lGxuKHna1W1dNafpQm6Dv0zYOyI+jpl9YOheRg+lPLTQIJCyNi54YrL2k9mQhPoz2sWz7m7puV4MU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LbjpOSNI; arc=none smtp.client-ip=209.85.221.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LbjpOSNI" Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-56a8fdaddebso1025178e0c.0 for ; Sun, 05 Apr 2026 03:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775384252; x=1775989052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aQU2SsMReRl0oD9GLJmwgm8l81dSwTvpulsnX1IecM0=; b=LbjpOSNIaJycVRoAr+CQo6p2XglLLzpre/2foVHeapsTn7aCC8yEjGZ3O+78txUH39 5dj/d0ruanyRnvetjEiJNT+9IUKldkf6kqTWfv6372yWTrFMtExHx8DRgSwj10Xki02O fgWElNw4ls8F81LKyz1o1JUigx2M5QQ77Ay+/yiDwmmdrzYmgbNY18EDpUTInnDgZmDb nRrlDyLXeWChwv5sDJXEnA/Kv32pnh5DIzRrhJV4TUVTj107j+bhFSa1VzYlfZ6/S4+g s3ldmux+xY4JdZXXzE6sE0FSKYxMAxg6OPhhcdJVqa04oA/56EO9brzfB1MUkMClWFvO x4rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775384252; x=1775989052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aQU2SsMReRl0oD9GLJmwgm8l81dSwTvpulsnX1IecM0=; b=eyA91ofvI6cNUPjREhky2vJdiGC5iQ22kTqaoRUDkxy4glY1XLtN+3eQAJfGkLQIsn H0mvIvZFg4wAFrPEWZ5Zm+cJfkUJJdHf4nnEPFBUpRlPO5RBnb7yYNF742obdX1ja0rU WfFWpikgJxuBDN1m0aQFWD0lCkFddKNkbMyQswOQ4BifqTEPEsYW09jq8/h55nn1BWDf dyz5rusQCyLV39L8FzfJ+fxdz53ALgOewEQCJR6ZxiryCogkFT/b9ofdkdPr6dRsg/pq ioXovkh6RDEryGA6NqYE1GfUWUCR6ihH1fzTGMyKlwV/yEoXtu0mlkXyUq1Rm0QXHG/g DUGg== X-Forwarded-Encrypted: i=1; AJvYcCVzOkLAZjW92M36xfgAKFDs3Lxgg8Lr+cdXl5umGHQljE00GCfekyhOVpg05osqVFE23b9ee+XMa9VBokc=@vger.kernel.org X-Gm-Message-State: AOJu0YwxfhMgYXXDF91P6OWfVcIZ7GX10+ruYsDIaEqaiZvjP2MmKn4G 0UrX9bAFGJpYlsTqWnqpE23I5jRO34jvOxArQfrxmU0M2kuwMSF7vyXNhPdDbG/Y X-Gm-Gg: AeBDietKD9xVs6SAUVgcnA495M9tRg5HLMPtV9SXBpPN7M/zixFlnIDRFEZPHjYDo2f fxGElrzy2WWGcHTFy0VSpa1M61CESE40RwCdQsvjbzN+Ad+ySLWMDsPH4xT3fRY9t7FdiCYIg0t vOFX2WJ6ypkWKe9OI06W4ms7bNDgVaidOb6z2d7Ax7lLTCmXdOKRF/prIxK0Iol6dQVstzgihpG 2DdOxlglPZojBxobCGg27MaJcloLrXv84LqTL05EmG7+CVwPgCxgyAN2ofBWUyERvlmsBGmgb5T kRBNx7JrR0hykvQQM/h80xyIl8fGiCo9KH228H7FYJem6MmMLHbI9YMDiGHwh7LDL2HZNAV9fXT FB2DUUbQ5wcEJPOWTHuorTLP9At/21CFO6ZYkCK6mtZBuJWCQm9s5bLVqDd5jFZnsI4zf1y2fPI oS82Sb/QAoJjSO494JeDYENIN4V0IvA2zhnlPtjnti X-Received: by 2002:a05:6102:5cc1:b0:602:a651:11d7 with SMTP id ada2fe7eead31-605a4ca8866mr3198854137.7.1775384252101; Sun, 05 Apr 2026 03:17:32 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.15]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-953fb897b8dsm10473385241.7.2026.04.05.03.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 03:17:31 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: Ethan Tidmore , Sam Daly , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Delene Tchio Romuald Subject: [PATCH v3 2/5] staging: rtl8723bs: fix integer underflow in TKIP MIC verification Date: Sun, 5 Apr 2026 11:15:45 +0100 Message-ID: <20260405101548.124829-3-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260405101548.124829-1-delenetchior1@gmail.com> References: <20260405101548.124829-1-delenetchior1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In recvframe_chkmic(), datalen is computed as: datalen = len - hdrlen - iv_len - icv_len - 8; All operands are unsigned, so if the frame is shorter than the sum of header, IV, ICV, and MIC lengths, the subtraction wraps to a very large value. This corrupted datalen is then passed to rtw_seccalctkipmic() and used as a pointer offset, leading to out-of-bounds reads on kernel heap memory. Add a minimum frame length check before the subtraction to prevent the unsigned integer underflow. Found by reviewing memory operations in the driver. Not tested on hardware. Signed-off-by: Delene Tchio Romuald --- v3: - Rebased on staging-next - Sent as numbered series with proper Cc from get_maintainer.pl v2: - Rebased on staging-next (v1 did not apply due to whitespace changes) drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 717e0594d983a..11ae99e53b86a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -390,6 +390,13 @@ static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *p mickey = &stainfo->dot11tkiprxmickey.skey[0]; } + /* Ensure the frame is large enough for TKIP MIC verification */ + if (precvframe->u.hdr.len <= prxattrib->hdrlen + + prxattrib->iv_len + prxattrib->icv_len + 8) { + res = _FAIL; + goto exit; + } + datalen = precvframe->u.hdr.len - prxattrib->hdrlen - prxattrib->iv_len - prxattrib->icv_len - 8;/* icv_len included the mic code */ pframe = precvframe->u.hdr.rx_data; payload = pframe + prxattrib->hdrlen + prxattrib->iv_len; -- 2.43.0