From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39389326D65 for ; Sun, 5 Apr 2026 11:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775389480; cv=none; b=iYaDcaH6c/R9bI9zAqfPgTpe2Ox+PVs1AACydNLxflzh2Vl4BMJ6qIe9tnEPbucODd1LdRa1MnUuZzgNS/Wl0+lSC6PFUd1kOR+xejSyk+AJdad1k23PekrBgi/aIowXGuR6cFsvmgw6PbufXxQzmwCT9nSk0qYam9ZR2rfcJlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775389480; c=relaxed/simple; bh=QhFZfZE65gbnl9h8vQU90kaMUl0AlHiQu80nDsgeAKo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=twTApzVKzL6kD63WZ6VSrmQfyS/IVdJElXjtwO7Xe1wby2MsxFaNprssfyFewuA9p+PloLbinWWr1nUxB98LiefDwcedl5ZdibU6cIv7K7wNrMZPTcL0vCZv+SPIosPlQaNSjf0QeP7KG5E3BfPxcwQZYnZ++mt90OWzJ27mFfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pP++qf2F; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pP++qf2F" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82ce09b4197so1277515b3a.2 for ; Sun, 05 Apr 2026 04:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775389478; x=1775994278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O20kcq5bcuV9eQLusJE7YAYwYicT0IX29PK1z9JHR94=; b=pP++qf2F91wC8Kc0cztorw9ORbZ+6duOh9pID1xZXt4FxU6wcYr2XMryK39dsoI0Zu rC/X6MOIBT4F8iICg1XHlkO08pCB0lRnODFG3jMRGEGrQ2wOFgsKgJCwJmHd84AsXfFA irKfp1sPV2AhP1dlPpNsdweABIlMh7x51LzPpN1gk8jloBPEe73tDiFmnF+toimxGfCL ey3f6bTMxBDYDDHO2FD2rHayV5UWI4Tkp+Ut+LR6zcYOX7wKhyET7eAXEWhl69NUIR1Y R9krGFUjHOGKds8IrMw64yb4gMX5rroeJkdmrzJB7T2uDFdj639juPukljLNTjfXlhlO HoEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775389478; x=1775994278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O20kcq5bcuV9eQLusJE7YAYwYicT0IX29PK1z9JHR94=; b=OwKCcqB3DB1CCNkntXKbBjtOfdsEpCZxjojNudYRtJGQKwPL64JqkelTqBpSHmh8HO P/BPksta9TratiPyzMMbKHEFucPNZjgu7GYhwQBGZH9ggH+IzerPtq+qVi/yhxcV25+t doZ3FqfUofatsM3yLktyfZhFjv4/T/Xelr4krmpT4IJWSiBB7N0ofICw/jTsgzejvCu+ CWnEiJOpndx7wIqQXkzdbzPOToRmSWY5AW5jpnqY620GtFjdRfOdML+6Ep/sR/C++x77 6fHxbDeFoEAmFJuyQI8DU4CNt5ivHKH7QpgUFlp5ieZXvx2qrYRwbelLn3d+5j5IuI/Q YdQA== X-Forwarded-Encrypted: i=1; AJvYcCUaa4Dg6xXmVQ9CKglShjAJy+kpEJc1PqUVMZ36+bH6WJurXImnlra/y8ho8d0VnB5DP8beuRhIuAAe7hE=@vger.kernel.org X-Gm-Message-State: AOJu0YzthSGKfyGQ9t9e2mxKgDtKGy0mroNmezO3jCZCRai7aDmjaAev 0vhZptsHPlvGeu9m1QI72cj9recF19VeMr2yjO4dYT5+7p0lG8Q/rVKu X-Gm-Gg: AeBDies8YVEpf0aIoWdolO9MGtiOmpDS3dFn1+2Tw2V96Cd9mU+zK7IhPNsM4jPDAVi z98lcTeNBR37FZXb+G91gw/pmzzMmVZBxr5OnfRQRm+NJf+Pm7qrBinVr68Toe0CJh7bq78zdmO meXzGvCDHrx/xKYYlFSPjcf9C3x8+TJS2hxqppSdShajKAbembp6LxRYNUmhtD4LXm+82bORsYd JgDQ1IAH2+s3pR3UCwDLTb0ipVa+Ix1nGHrxOvw2iCu32gUtOieXZIHZ31/j4en5Vo7Jj/uPwCE YsT3WNe6vwg3I/PT5INIx10Tp1WYheAHvRuHYUAo46z/3WBBqVClbc/+eeDrHy9P3tch4gkIOoT W2ayw7x2NwQEky0rjzp7g681ognjgpjX4civIwCPwipGy1hiwR4kiBVPGCxHnV+WrYWevYQhfxx AO6vuBUA8QKx1rkkRLPM7LWeMaC4Q3fmI78QyD/xI= X-Received: by 2002:a05:6a00:e05:b0:82a:8030:f574 with SMTP id d2e1a72fcca58-82d0db40023mr8714468b3a.33.1775389478590; Sun, 05 Apr 2026 04:44:38 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b3ccc8sm13938205b3a.19.2026.04.05.04.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 04:44:37 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, dan.carpenter@linaro.org, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, samasth.norway.ananda@oracle.com, lukagejak5@gmail.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [RFT PATCH v3 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down Date: Sun, 5 Apr 2026 17:11:31 +0530 Message-Id: <20260405114132.310774-5-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260405114132.310774-1-activprithvi@gmail.com> References: <20260405114132.310774-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the existing rtw_read8() and do-while loop mechanism with read_poll_timeout_atomic() from , in _is_fw_read_cmd_down() which is a standard Linux macro, ensuring polling REG_HMETFR efficiently. Signed-off-by: Prithvi Tambewagh --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c index af6cdda8238d..17e135cd3e0e 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "hal_com_h2c.h" #define MAX_H2C_BOX_NUMS 4 @@ -18,20 +19,15 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num) { - u8 read_down = false; - int retry_cnts = 100; - u8 valid; + int ret; - do { - valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num); - if (0 == valid) { - read_down = true; - } - } while ((!read_down) && (retry_cnts--)); - - return read_down; + ret = read_poll_timeout_atomic(rtw_read8, + valid, !(valid & BIT(msgbox_num)), + 0, 500, false, + padapter, REG_HMETFR); + return !ret; } -- 2.34.1