From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFB81F92E for ; Sun, 5 Apr 2026 15:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775404033; cv=none; b=J1aRBwWUSYYpF2XrHJ74Y0v9XwPpGhGoVtL35m3anvYJM5rlRLoJIgLmhmba7F3n2blWhdxAlzFMNmszp1E+TgTcXcppUKut+Kg5rCSZKuq9euyokQ0C0CV5ibQ3Fe9GMnDsFyIOM7Ew0F5t87we0v2kO7Di4M5yBhQp28lfO3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775404033; c=relaxed/simple; bh=meNifUCrFKnm7OhNcC8ymnP12Ih1WJ0NsbIEGdB9Bxg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YmT0q7BfbXwGvVvH3I++jBq8veb43kclFH9Aykd4BUzwfs40AalxFPlTHTQ6jrBNRJVtiUUUXUUTTpHeIwRbUCk1Qb6/X83NDWxcHHZtmA2tR+zQXfDX8XLjI3lt+npioIfHKLu4aDt/P5w56Hk9BdZT3w+bwyAyC1sYiIcVk44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G2PqFZk8; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G2PqFZk8" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4887f49ec5aso46478185e9.1 for ; Sun, 05 Apr 2026 08:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775404030; x=1776008830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ij+T5jzWpjsPXYuNnUcPKiRbTS9+M0L00zfNyuOLfvI=; b=G2PqFZk8ke5eXAG8Q4LyqJJjZhNRxq+H00c475gsrTmj3cb8hSsKmgIBsKNbNsa/NQ V+w2JJtqUdlOppyQ/qgBY0Yeq7alD3b+E5gMYH5ZV09UaoQMgoDJ9xvqYtfvC2gqqc3S kk6uBcFtiP8JO/JPek/9Ggrsr8ExzvpMmSm1WVf2Ph1WvupKF8X0fhDTA8Sp54YUzXNg 8Ztb0iibVmrJwg1B0qwmB2T8vuwYpkWZB3K1mzYjZf+86KUmhX8kxuP+Fi5RRdezWnm8 dC/+CAnn4wIhFlPmU5KW6sYm0Tv3gst1khQtRgYy87Knb44Ap01fMJRVHu9kZHBbcoBe 1+NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775404030; x=1776008830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ij+T5jzWpjsPXYuNnUcPKiRbTS9+M0L00zfNyuOLfvI=; b=iVrtHhS7/KHl/96yXS1bqP78qL7fsK/fzDMt9hBidBdE32fwMnhWQYbu5QESIekBhU fPgAsVE+zkag+HWPiJQ2sdvq5mes1N1vi7Ay5Hdv5fypoIco2bcqxJJxE3b6C7s8mf/8 8J9yid5ovMeeRhcPqKRhnyjrimc6Hl3/axcbX/vJvnI2J733JrMR4hfXW+h4u4uNgRsd xVCKu4fneYcA2Q5y1+co3Q26i5HC6YYFqElUEaGIrM+N2DKYeulu37lvu0GVj4RlQWOU IBFfvDsBKhokpzTgCA1PbYZEaoixfQ/srvSF7g8vw6CQOJKshsnpQuD3nmGkbB4igzJJ ZipA== X-Forwarded-Encrypted: i=1; AJvYcCVkjB6wRw6JhZy+cBv0qvkwohTLhag7L2z+lw2yIIUEh+dOB0srFNP/cpFUFlFPrElQ93A1lDfFLvm5Uj4=@vger.kernel.org X-Gm-Message-State: AOJu0YwlNj2ui8E24EqxmXrQ2QQ2mfuvH0T28OOfT88LS9YmEkrU+yOv lAW4tKnZIW2alCV5X76JaPGH9i4vq4mlwdNbdha3XxNbngFFU73X+Yk6 X-Gm-Gg: AeBDievFYzi6N60NE4Zeh1g829wbaM5mVIHM1D/yuFNBCi4mpDQod0fFgUmbhJV0/b6 /z91RqmMUyqSPHS7Cda9vPFv1El/SJR5nSS00WeOVHNBcM37gYawgo6gC8utv84hYXK0fPmJwoD 5z8AkC6TdPI7J3uXSN0dSxrHlDrvtC/WeohwPBPz9xtqhlssrsrrhIK5y0k93PJMrqsXXwMkZ6e Af1JsxLR2L1j8vCC4ncVdk197J0gAq+Qm/U1vxcVanNb1u+VHYCkUdmClXME3tGcEpJNNfP8rzK U4Sg9NHfBAaYwKKYwwKimtNxDXiJVfooEjrXqBZ+4yncW+akj+NfzdZzE6UDR/oUfTwe4jqJx3s 1dKI5OTC7wj7mAIjoRb93yon73Cvh7w92j56k4tASwfpwk2fjVZV4Gav77qXjBcCbcAm0H7g/D6 5s70p708IuO71/10hq+BUsVyjwiqYMGSI1Lh3aNMxXl1Jpe/Ivp6xUmDwof7Z+sSevNtg08sBo5 7NyzDCq/mC1 X-Received: by 2002:a05:600c:4593:b0:488:9696:488a with SMTP id 5b1f17b1804b1-488997e7dc7mr165902365e9.30.1775404030180; Sun, 05 Apr 2026 08:47:10 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488b0c53a27sm22255485e9.7.2026.04.05.08.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 08:47:09 -0700 (PDT) From: David Carlier To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= Cc: Jens Axboe , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH v3] drbd: use get_random_u64() where appropriate Date: Sun, 5 Apr 2026 16:47:04 +0100 Message-ID: <20260405154704.4610-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the typed random integer helpers instead of get_random_bytes() when filling a single integer variable. The helpers return the value directly, require no pointer or size argument, and better express intent. Signed-off-by: David Carlier --- drivers/block/drbd/drbd_main.c | 4 ++-- drivers/block/drbd/drbd_nl.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 200d464e984b..b1a721dd0496 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -874,7 +874,7 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device) if (uuid && uuid != UUID_JUST_CREATED) uuid = uuid + UUID_NEW_BM_OFFSET; else - get_random_bytes(&uuid, sizeof(u64)); + uuid = get_random_u64(); drbd_uuid_set(device, UI_BITMAP, uuid); drbd_print_uuids(device, "updated sync UUID"); drbd_md_sync(device); @@ -3337,7 +3337,7 @@ void drbd_uuid_new_current(struct drbd_device *device) __must_hold(local) u64 val; unsigned long long bm_uuid; - get_random_bytes(&val, sizeof(u64)); + val = get_random_u64(); spin_lock_irq(&device->ldev->md.uuid_lock); bm_uuid = device->ldev->md.uuid[UI_BITMAP]; diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index e201f0087a0f..377f60b40f28 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -3173,7 +3173,7 @@ int drbd_adm_resume_io(struct sk_buff *skb, struct genl_info *info) * matching real data uuid exists). */ u64 val; - get_random_bytes(&val, sizeof(u64)); + val = get_random_u64(); drbd_set_ed_uuid(device, val); drbd_warn(device, "Resumed without access to data; please tear down before attempting to re-configure.\n"); } -- 2.53.0