From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2788E4AEE2 for ; Sun, 5 Apr 2026 16:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775405755; cv=none; b=Dk6nUEcvI0uF/XRru/TzOKLH7UAQG3ZnDPru/iHamjnSdkIVBELnmt430oJl8ejcvp2xII4qwI17jS0HwhVel+ne8ycesXGSUWEz1xdOD4CrLE7FcTA0eCyi8puqUQ3EMVxZfuhsofnH1DmGl5H1sn1i7zvm87PhJxo3AUoLd74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775405755; c=relaxed/simple; bh=I0Yp6TdGtVpPoFTJaS3SElTM5q3ai4L9HU+Syq6+Fuo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EA19rED671SWXL6poQFEy6e5McLBfV8GgYngXNnVRhp/k+0uEy69Uv+MNS5XJlyB+xM9SVhz+2tGgO0oLTiWj30y+gkgiL19EFH91klpzcVFijwXjKu8wTD+Nhs0x5Ildlb2N7OTm/rfk4IzpBcCZ9xIzKaNuTWxtzaP8yMnf88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WSOM/zSB; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WSOM/zSB" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43cfac48bc7so1723149f8f.0 for ; Sun, 05 Apr 2026 09:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775405752; x=1776010552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=JDo7wOf9Rd6NNXxatwieaMtmaaIFmU/41KBybrHKVJs=; b=WSOM/zSB8oD9Vh0eRM9Vl0XmBjSqbkuEgKfkd1NuAnEhv9G4hQVIChbpEIsE2nSTn0 GhiGRp+VO/KkDejKiSHSqSpJ95N4rDvutiAeOH+DgySlHUNZHCUMknyLfQDigseCv08C 3HSSYBESKRf52mko9zYNB155AkOBKpeadQCKPCoMB31DjUfsSxiZID9DtUkKzFrjT9B/ mOJpYnhr7Ea0+kWe0ffpRVsaMcK83G1a5K6/KpUFIH4RtqyDUIU6GTb7vFVt9h6TUqlP GQ8bUQfXFaMjfFDXgjhPXLS+caMRU6uUooaVrnUi/07lrYDYbgUTGy2SanpKdR9mLMSB VX3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775405752; x=1776010552; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JDo7wOf9Rd6NNXxatwieaMtmaaIFmU/41KBybrHKVJs=; b=aiITkw0uHNXm96yWqerPR/pkk3738bq7cfgze/WCN9GcxtFT6V7dRiyyxwoZB06a7Q Swb2PyrfxjxH1ARxRYZBcWX1DcsHGtdXoErcKnq09fg6Iqdnplwg3CiMZRoYrHvqHz1R IO9yKmNasltdWR62ysgfehfrjvrqSUs1KAW2FbljgSIIVQKcS8xD6JQG6fiyp2YaXb5v TjRh9SqPPHXJ2NHG5tZPB+A7TWX2mtKfXsaflRMTMbb4q71+F2h2HJmHo6B4Znu1Cf41 cQl/m+FD9nmXjGhyTIaxOd/S0H4Ia+ihuraTzFHz1gZepgpF6y/RcSSy5sdvifJ2nY9t 0bGg== X-Forwarded-Encrypted: i=1; AJvYcCVF956/PcxR74JnmpcfcnN9z97Q+2axNvuqbz39b/tqG6yI4D7dPV+tnMHOEmY+92iS3uYeBvBV/lzBSUU=@vger.kernel.org X-Gm-Message-State: AOJu0YzHHmgH6Vp1FsJIkns7s7f0OSqvYKALOjZMj3Q57lYbl9vfDtfP yK/4q9Gd7u3u5+GKTAY5chJ1ed8AFPLAM3LBrC5ZipSTFXBF6RpmWolE X-Gm-Gg: AeBDievTD9iOFfb2o/7AnO5yYzOts4C+bzm1x+gARLQXRp6OiXSwm/h6dZZNPCxyBR6 67+IkG9+vMouiglzKyOH8QYCxt6fd4YXfYTZgNoexrBe7+RwnXzrfAgVTrgn4F+gVfBZ48OToBa kYtZakyWPardLe6El+szLwsvvkqhBvyXaE2dks30EKLDmx0yVTsxv38Z60TS8XeBSZN1VFeR0Mv SOjfmAGx3pkBH4beoJ/UEuQpxiRe92KhZyvnk69rwSGFKlNJwKEEnoKhT98DRuYLDOBq6061z3v WyKJy+jkxw1XO3AZ7b8obbqGeOLCcCp/lFi23a7XHp9/wWYOqF6vTUKyI3AFJ32HVvq7nAz7JVZ IJTGll+rQ3bJxIHYwfMa/zil2ZfmMziUrY+h6oFQ61jC7LiLVgazxc2KrZpmQ3UJQQSPICZ8JJR Twy9vys7gyDwmnn6OcE7/UjBzF19puL9GOWE8VZQBD2LcadfzBHmAE+WU= X-Received: by 2002:a05:6000:2c0a:b0:43d:1c39:26fd with SMTP id ffacd0b85a97d-43d29305b12mr14362355f8f.43.1775405752340; Sun, 05 Apr 2026 09:15:52 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d214f2b63sm28787819f8f.28.2026.04.05.09.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 09:15:51 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, jniethe5@gmail.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] powerpc: fix dead default for GUEST_STATE_BUFFER_TEST Date: Sun, 5 Apr 2026 17:15:45 +0100 Message-ID: <20260405161545.161006-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The GUEST_STATE_BUFFER_TEST config option should default to KUNIT_ALL_TESTS so that if all tests are enabled then it is included, but currently the 'default KUNIT_ALL_TESTS' statement is shadowed by 'def_tristate n', meaning that this second default statement is currently dead code. It looks to me like the commit 6ccbbc33f06a ("KVM: PPC: Add helper library for Guest State Buffers") intended to set the default to KUNIT_ALL_TESTS, but mistakenly missed the def_tristate. This dead code was found by kconfirm, a static analysis tool for Kconfig. Fixes: 6ccbbc33f06a ("KVM: PPC: Add helper library for Guest State Buffers") Signed-off-by: Julian Braha --- arch/powerpc/Kconfig.debug | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug index f15e5920080b..e8718bc13eeb 100644 --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -83,11 +83,10 @@ config MSI_BITMAP_SELFTEST depends on DEBUG_KERNEL config GUEST_STATE_BUFFER_TEST - def_tristate n + def_tristate KUNIT_ALL_TESTS prompt "Enable Guest State Buffer unit tests" depends on KUNIT depends on KVM_BOOK3S_HV_POSSIBLE - default KUNIT_ALL_TESTS help The Guest State Buffer is a data format specified in the PAPR. It is by hcalls to communicate the state of L2 guests between -- 2.53.0