From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17354381B01 for ; Sun, 5 Apr 2026 19:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775418634; cv=none; b=OopMynF/xXti6x8pT9fSjxofqfTDuGZTK7Pkd26ZsTK/sh82kwlbwKix6ynIEpJ/vuioyxfgGCrU12MmBOaey3p5uglGrcsqx8I3gsXBISgyjiwxzpd6nHzZRw2QwoYiSVw8ZAy0eh4XNV/qTDFedOPcWN6OGTQ6kYD4EtNKl3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775418634; c=relaxed/simple; bh=evS6sJd1RnWlkbjgcPhwUsPNQVfDbE9QZrru+rBlhSE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kpHPesy1rvgFqRZoH33f69YXhWlvc5ay0eePJaivf6vfFyO4AoqmEyHDlECSYHR8vBO35/3SlqB0fr2vlXwPEUTYT1+2NgIMEtlg3JCDgUukLRXO2WD3VEAqENsN4UWW7EP8zApzP+zWyAfuPBZlJff/BwFPbm+M9zfhjST8Nds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LD5/4NCQ; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LD5/4NCQ" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775418619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mUwPl5fcDvn9ZEfXd/e0M/SWxMo4KU7sgVV2RlJ9akY=; b=LD5/4NCQ18mx4DKXfJWl94X+bEf8MZ3Ks1Ky0N+upX0gr/0pdPesSmU5RgkFPVCUYsOEuY miZivQxX7LDIprFoYXAje7N9IYA50Ho/VC3765jWLKKxPl9qVAdokAm61+8bYzIv7Dzcj/ gXnUmEEaLPA02eweDL4V54VVl8ynTd8= From: Thorsten Blum To: Herbert Xu , "David S. Miller" Cc: Thorsten Blum , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: af_alg - use sock_kmemdup in alg_setkey_by_key_serial Date: Sun, 5 Apr 2026 21:49:41 +0200 Message-ID: <20260405194940.990619-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=820; i=thorsten.blum@linux.dev; h=from:subject; bh=evS6sJd1RnWlkbjgcPhwUsPNQVfDbE9QZrru+rBlhSE=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJmX9lyxUzx39lP0z7rNv7v9T6Zs3m25uvK7wHRtgaOxr VNFtj450lHKwiDGxSArpsjyYNaPGb6lNZWbTCJ2wsxhZQIZwsDFKQATEdzJ8D/42fspvDwWTa3b bTK/OPIHXtD8XV+kcnnLt8yFsatZs+oY/nDU8fHPkdG3LZjY/+/X55uLk3m3i/v2/OW8Jh0X7b+ qhw0A X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace sock_kmalloc() followed by memcpy() with sock_kmemdup() to simplify alg_setkey_by_key_serial(). Signed-off-by: Thorsten Blum --- crypto/af_alg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crypto/af_alg.c b/crypto/af_alg.c index 8e0199394984..25d2bfae31dc 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -324,15 +324,13 @@ static int alg_setkey_by_key_serial(struct alg_sock *ask, sockptr_t optval, return PTR_ERR(ret); } - key_data = sock_kmalloc(&ask->sk, key_datalen, GFP_KERNEL); + key_data = sock_kmemdup(&ask->sk, ret, key_datalen, GFP_KERNEL); if (!key_data) { up_read(&key->sem); key_put(key); return -ENOMEM; } - memcpy(key_data, ret, key_datalen); - up_read(&key->sem); key_put(key);