From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E24C34CFDE for ; Mon, 6 Apr 2026 12:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775479405; cv=none; b=RkPd+8WUduuXvI3sbBt5tnHU404UuZoPaHqosgLzfQ7AwFYCcF8kaJjDfm3dVQCOhD2EtUEWCGTXWH+wuiGh/SYUApn6qWLDiateogSlTB32OBA7Fk2VdoE5R6tnd+xjZ4UvLs97CdSS1QN/Hs9HU67FMPq1l86+bvGwp/u8ZHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775479405; c=relaxed/simple; bh=Cx2s2w3meJfSfpKTacSMv/QU3Sx8jDulv3B2bNsYKQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tSiupRc/rsjvCme+/FNUo3dX2Kuo/9CYuCWmiC1u8NWBnDancg9GWLRp49v4vvPMCO0zj4Iy6oq6ZTslIF/1JGr3ttmQwkzUz16ljJqQiMdwcVEMY3ZgdUIHk4J4JQ9XvSvHIsO7/S4GjrQJZazom10w9wO1aZa/jXuWuVtNKDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RGd3b1kn; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RGd3b1kn" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2a9296b3926so21386175ad.1 for ; Mon, 06 Apr 2026 05:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775479403; x=1776084203; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wFXMumAntQ8wMwwB4Cm6xgKR3q8YklhzLyY8Ugve8Fo=; b=RGd3b1knezbAPIhdmF7bMvBBDMOvBZ0b9bh73s0OKOXYn2DrsGv/8bx3SEGinVCgX6 joXyOGSKN0n7XUTWhdVM21WoArvCoh47M2wqCNVjQNOHPTtRsEjJA2egmSxNSEXf0SW6 xj2VhKEJWi2dJn+HndCROrHvQF3ZEdHJP1Azp3PhZ0qFrWDJGWtiHENivXsikvWrS27i cUzsCWxbWY7bMTHfRYqo9tMRd9GMg+ATrQr0U7UPiH0S66LnFaQw0kbJ5U4lKAnKsmw/ lfS0lSCa2GwsXlFp9HLdoW59V3xKLpzhKQjucdTUH3be/lZldKQyspmULlip51m0Qp6S dI/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775479403; x=1776084203; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wFXMumAntQ8wMwwB4Cm6xgKR3q8YklhzLyY8Ugve8Fo=; b=mzH8SIhpJnz6L+C6TyXkOeLg6PH9OY1zFtC5faBmi0KZPh9Q1UOPpXyZ72D7Q8GNF0 X49g6YMbeLcxyhKBqxiplS8yawm1J+u/YwoiHl/LSPIgvbF6FZgN0xY9kESz5ZxcVEV9 Ob6UHR7vrfs++Ff/gdzWGGLq0KWtB4Kq14AeH7s3Xkk6SWe6ZYaiFosGppIhEPm2fk3G OXfrXu6WWwoYLdjkUrFfMDB8zJ+CLAGmwm9jFOWObtT8zs2bTQrVsQBJc8Mxx5d0axCh 7oi9F5WPI0tWIXMNX6PUfUn6REiYdFcCz0lYJXz2YIw/ox6yGhb+UW1dMa2Lk3vNifdJ JPpA== X-Forwarded-Encrypted: i=1; AJvYcCWE/lBwPkEBr8xpL8S1Kf9oA69v9uSu2lqjLZrjNn/F83Ar7TrwXB6yDHtQsYMjHjFKONYAOIyLIdr4Q4k=@vger.kernel.org X-Gm-Message-State: AOJu0YzQe6bMHr1QCJQVwJ6mm55mF4v6GtCZvXvz51Z7iot/gXT4jZsL 1OZLvDcenoh23ei0g8znaQp8KSfmyNFkg1b9LSM4MQ1npl/uzqDJ/Uhb X-Gm-Gg: AeBDietx7wk252uiZEOIL1OzjXU8JZIr1uNVBwqS/Nr0k32kBaQFecwkymBY62f3/iy TPZh9C6kAnwYWQezkHIiAmXCSFMpvB50q6YgKASQcXLqbHt1lZF7r3Z3oc/2PdNmiliEwSC6T3l hy7QU9ePO/6cOdouhEsafYY+Y2c53kxrsTdiCwP8b2jCbbuofLBhZ5mtEkcRw7GVtDRQzoB7wWO bqsxbv5GLdmTiaga5SqE/TwOpPmMCZOOrcS/zZh7lboho/drUI127X4tGpzh5S/RyFF9c5utT+C r0FfMN8otwQqbIPH/k/p12WoGWG07X9/7lmEhyLjU6bnY5m8wCFscMXeUnL7drIyC9s84ZMm/MW kTEsU/nll0Lwza9BtRgwpt8Nq8n2eXzcdSX9ElLtR7Ts1XIjaW1/kN+VeSIzjJU0tK0KMkLoqVl 9J0l2CvharV4zdpeEj029Qdyi+T/LOEz/xaBUTUr442zwLOVs069aiyyTCuQRCe8iFpU8jSpzhz b5ANqk/PEBYyr2bQ1Lh X-Received: by 2002:a17:903:388c:b0:2b2:67ca:5ff9 with SMTP id d9443c01a7336-2b28166b24bmr130928605ad.0.1775479403236; Mon, 06 Apr 2026 05:43:23 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27472d233sm143486445ad.2.2026.04.06.05.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 05:43:23 -0700 (PDT) From: Felix Gu Date: Mon, 06 Apr 2026 20:43:16 +0800 Subject: [PATCH v3 1/2] i3c: master: renesas: Fix memory leak in renesas_i3c_i3c_xfers() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260406-renesas-v3-1-4b724d7708f4@gmail.com> References: <20260406-renesas-v3-0-4b724d7708f4@gmail.com> In-Reply-To: <20260406-renesas-v3-0-4b724d7708f4@gmail.com> To: Wolfram Sang , Tommaso Merciai , Alexandre Belloni , Frank Li Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775479398; l=1599; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=Cx2s2w3meJfSfpKTacSMv/QU3Sx8jDulv3B2bNsYKQU=; b=ngZ1UVYMhz0kYIc6Gh4zPWxqI+TT9L9Uxc8oLCc7ij2AZOERHBATRPr338sBS7YtvnWD4AZoA cRTfTga8GAvAGEPV0WpNwk3v2wN6zlkLvQpJfsEvadfPWGQuLKJfUoU X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The xfer structure allocated by renesas_i3c_alloc_xfer() was never freed in the renesas_i3c_i3c_xfers() function. Use the __free(kfree) cleanup attribute to automatically free the memory when the variable goes out of scope. Fixes: d028219a9f14 ("i3c: master: Add basic driver for the Renesas I3C controller") Tested-by: Tommaso Merciai Reviewed-by: Tommaso Merciai Reviewed-by: Frank Li Signed-off-by: Felix Gu --- drivers/i3c/master/renesas-i3c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c index d9f5b30a4b2f..a8a9e89a9710 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -8,6 +8,7 @@ #include #include +#include #include #include #include @@ -817,13 +818,12 @@ static int renesas_i3c_i3c_xfers(struct i3c_dev_desc *dev, struct i3c_xfer *i3c_ struct i3c_master_controller *m = i3c_dev_get_master(dev); struct renesas_i3c *i3c = to_renesas_i3c(m); struct renesas_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); - struct renesas_i3c_xfer *xfer; int i; /* Enable I3C bus. */ renesas_i3c_bus_enable(m, true); - xfer = renesas_i3c_alloc_xfer(i3c, 1); + struct renesas_i3c_xfer *xfer __free(kfree) = renesas_i3c_alloc_xfer(i3c, 1); if (!xfer) return -ENOMEM; -- 2.43.0