From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473452EB84E for ; Mon, 6 Apr 2026 09:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775467587; cv=none; b=bvhz+roAZnrmNRPT2Cglv4DB1SDcjmA1JmEPcd2uqcWe3ab8+Ei1Y+QzNoZoKYqcgXzul0Zcgwlg/oRQaC7PZcr2eQ30WWKxVMInN7lrEftz5vK39T8wutodgoOblWJOpJWnRSVxAADUZqftJgCAtF+NwceT/4pjzjk8R/gzHa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775467587; c=relaxed/simple; bh=192CQ4hc+M5khI9m9NzTTc88XPmfxytoOQBY5466R2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uiHesV/hZ8vTOjMA1Hn+MxDVouuMZt+GyJvE22H/xisEImc/PGnJQ51A4DxaXLPlj0c7hbLL4Ko9rGGtjbweyfExnIgy8KJqLpRxILDb6Ov4HAzKJJ4PtgZgBHICI2zaxcxtHN5GhCL7evCvp8tgmdlbZKMPdlp4l7dkyaeXVjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zs5tMBKD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SdtGon7K; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zs5tMBKD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SdtGon7K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775467585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MqqPtNs3ANYvOJtJzCyDBuh3wrvsgELj1mRcfTFeetk=; b=Zs5tMBKDtG9FykQkam4BEncPrCJqhGI4NFqUNCwONQMbRMjTbwOojl82Ye8uwefmLqmSdo GEvfBZxJmUhHbEj8UulultL59P34NE+RCFY9NgtUb9JQGAbEobTU3jYKBrypGuJzlvrN9M fMnZpX8qBQQ9gcO20sq1Ra+wZ9C/eHE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-JKiUfo7_OSiRHjwx0ZuMYQ-1; Mon, 06 Apr 2026 05:26:22 -0400 X-MC-Unique: JKiUfo7_OSiRHjwx0ZuMYQ-1 X-Mimecast-MFC-AGG-ID: JKiUfo7_OSiRHjwx0ZuMYQ_1775467581 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4362197d1easo3584587f8f.2 for ; Mon, 06 Apr 2026 02:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775467581; x=1776072381; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MqqPtNs3ANYvOJtJzCyDBuh3wrvsgELj1mRcfTFeetk=; b=SdtGon7KCDBR9OKXbW4ciTVwLYVbWK8Pbd0i3lsUpuHETn76A8Q7wFCo9cSmPaVCtM GNEnxNeiYIZoAComlb1IYt1DPUkOZysLWZWcRwT/zlS6q7jSz9fx4gA68vDBx5BRRrT9 VMcSUf9oLSWgQFGocqzYu6dNDYqX1t7JtzJsufwbBPqMCN45nh5i9uZtNugbHVgEOh7u 8WfQ0LZWReej8OvMXQHbyg35YhRH8xFR25mJwUW8SeWnXY1ZptfO8VZBxPUrZdrttzU5 bdCxW3dzUd1m+phd8typE1l1khCM0VIC2XA7/mCPuDAafKKwhrF5Qe1qUq+NMLZKwFs6 tepg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775467581; x=1776072381; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MqqPtNs3ANYvOJtJzCyDBuh3wrvsgELj1mRcfTFeetk=; b=K7m6+l3SJFp9IqxsUqWw8h9doSu3u3QBPeM50sr9RfJwV2rurAsFmhB2ry/R1IknT7 /I3OB+APG4kKEKOyms/9PCeVr/gSx7I3aFbct0ftJ/Rz85OhgnNQEm2oqj+kgTFWBUqV MSPtHtaMtxvR1WS4l4xO23dEmiuHKMzbWOVj/JfJZjFUKnrg/fKnqYWAhd0BSn/hNdY8 zjUP0hEPgh86OZbbGNKd0iSJRIAH12Sw0Ife4S9W4JiMOEC2YO87ayFKxnX6Y7XryBNV 225YamXeZRnRRNr24Ko3ILeBImJtvEgHM7Ixh7I3F81R7w5RpxPHTzzaYMxRs4yBEmyA oMkw== X-Forwarded-Encrypted: i=1; AJvYcCWQDAUilpqzWr8WtSEDqat7x0CeyYlctLbxDaoRon6nIK+K05slLRI2fH0+yg4acBtn+HHdhb/+O77iQaU=@vger.kernel.org X-Gm-Message-State: AOJu0YyvTbEk8yiCSF1dFMIMg7jyBwlFPpLhyPKmXbL8TBCRfKxlfpgv GtpFX9QgKLpSA7pr27GQv+bocki4m0PtopfaMPFhxInLuxZJIzoU2v5vCWT9uxN03Tu/bubPc9l omlxTXoYHDFP20FWXkiJAs1W/tgiNDw7wLTwhsFxw4WKPpl2Q3PZ9N8csv+pKPkQ2aA== X-Gm-Gg: AeBDiesZFFwQ87zT7cy1rjJ14EIfGyg8jEI/sp4l5K9RHyPrcV170qYZuor/UMvta+R fHyi0srgI7ZJp6OPBB3tGi4w605sPmmE0xp66GN71cn5LRetL9ybMnOt0O96BbtYtpOtaEcVpJK 5Gou78Mvh8/GsU98qYCLl9CywkuwNWn1qJElckzKw56nIrS+DDt8y+OEiP3CEoBYCUzJlHyf/0H CnB0oDx/cmeNIKqiIKbMzi9Pu9y/NZkgyh86gw2gj3xqb0f9jL7QMF12Zug3Lh7ssNp964QG5bp IrGHDdlXrxOzuCpAyqfYSfevbNKPyXsVASP56kGMnEgtXWRXV2RoLnA1iiu4MkAThTZn9WvwvE3 i0HP+OmqAzrLtm+b/ X-Received: by 2002:a05:6000:40da:b0:43c:fc5c:aa0b with SMTP id ffacd0b85a97d-43d292ec960mr16756662f8f.42.1775467580708; Mon, 06 Apr 2026 02:26:20 -0700 (PDT) X-Received: by 2002:a05:6000:40da:b0:43c:fc5c:aa0b with SMTP id ffacd0b85a97d-43d292ec960mr16756634f8f.42.1775467580210; Mon, 06 Apr 2026 02:26:20 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1525:da00:3ac2:1a22:72ff:4256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d214f2b63sm34917992f8f.28.2026.04.06.02.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 02:26:19 -0700 (PDT) Date: Mon, 6 Apr 2026 05:26:17 -0400 From: "Michael S. Tsirkin" To: Clement Amar Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio: simplify of_node handling in virtio_device_of_init Message-ID: <20260406052552-mutt-send-email-mst@kernel.org> References: <20260406092159.136447-1-clementamar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260406092159.136447-1-clementamar@gmail.com> On Mon, Apr 06, 2026 at 11:21:59AM +0200, Clement Amar wrote: > Replace goto with return for simple error > > Signed-off-by: Clement Amar I don't see the point, sorry. > --- > drivers/virtio/virtio.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index 5bdc6b82b..b49113ea8 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -493,16 +493,12 @@ static int virtio_device_of_init(struct virtio_device *dev) > * Simply don't init of_node in this case. > */ > if (!of_device_is_compatible(np, compat)) { > - ret = 0; > - goto out; > + of_node_put(np); > + return 0; > } > > dev->dev.of_node = np; > return 0; > - > -out: > - of_node_put(np); > - return ret; > } > > /** > -- > 2.43.0