From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623F330BB8A for ; Mon, 6 Apr 2026 08:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462949; cv=none; b=pzrQQapXXfKs2zYbEsYtx+vzJRKdqihzIrzGrD9WnI70Ynjq3A76TTB2SgAoff22wcjcoAy+t22MzxDAVvQ+E8FzG7dXSM9nx8/gBfSHfAegE8upb28REa6Z4X7oyngm+kXbWuvGosWIk5GwxmZ08uI3VLzOLk5dAzDxq8JXdW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462949; c=relaxed/simple; bh=rU4vsCbZPCGD0vFrs6ml6LjfFL+wePC5vj6ZFMlpsQo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jPpk8oE6fIgd31WQ5zYoTQzyfjh0CbjkRgj4gmiKlkwJ+3jcUNrQa7HTdP/457FoOjIMGTGYeTyCv6BhSJu3vKLSQAEqjpcqa6jd2peXp0iGv8mu4Yhg3e9daf6eQjlF/BIu3tnlyc/2ScrNQ9maC5xHSW/JFm++nyzNgk9I6p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j3qkXJKn; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j3qkXJKn" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ab077e3f32so14780995ad.3 for ; Mon, 06 Apr 2026 01:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775462948; x=1776067748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hpWKQRsVyCaZj6hI3lvjcls06PN5HybDlwyeC4uCUJE=; b=j3qkXJKnAbjC26YtbkUPEysEyKSZslNNyGOBEdvmlohcUhJDLuVqM/7EqmOX9IWplb C1T6KKJTf9RZOmKf0FL+CF97POI8po0DiGy7J/i8JTqhuKGZPgPwLAxkmlsS4AGcJq3g /0aGNLVqpCBxuac0J9jpFf89FBtLimIxiTG2dCRXp+ReoDRhVpfFdfhYuch6MULrT7fo yNNk6QMyJy2gGNxFtDCvsmR6eyvvO4S6BeAlridTWFCp3cSGN1aCr0GlRZUyTr6Fw80f R2dX/8e/sUrg+NTiWhyOJMqHVbfA458AQWwBs5de4RnES2eUNWQsObXYbJCIqBF8OuEh HGnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775462948; x=1776067748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hpWKQRsVyCaZj6hI3lvjcls06PN5HybDlwyeC4uCUJE=; b=PxC1Iuu8AfWgT/3C554r8XaYkv0Z/HtWIiR/HERPdKvwFqujpll5L04CZF17zjcq3L WObj5erSnGpadJI9Xx0oOPnJpL1+/5y3PYPG23oG/6F9bpUzU384MzTHSlVjhbvIqcZg BtTzG5e8aqtoWssOxbxlBFytLlKr7Ks/NSjvX/+bNbDMPfMjZksomENd+FsH1ot7jnzg SYIlQNvIXF8hgnL75Ul8UGYx0va0QvxINeSGIO/4E339x6mKUlIeQwM9Lb3ETxzA1E00 is5VZzBAgf2AiPjdHu12DisUGtPDm9Ekcl7IYFZ3DE/harDy/RYbt6kVr4mrNy9n0YaT 7NVA== X-Forwarded-Encrypted: i=1; AJvYcCWnVCMbOBkhxbcqe9H2/oisGbwHSU2Jg+/IAh5XLybPBR7kMT0/vP3Th/j7IR9vezD5yVrmtfw5i6F5mL4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzhwutn8QCPCAS42+HLTUlKXZarERwcMSTt7g4WLgkZpHzqXYQB DbNgckhhSAoPEKda7gfWAv2C9d/vyciQZ3Vn5yYOtT43t9t4ciVRxMeS X-Gm-Gg: AeBDiesLlGIrqoZQ/KPG02kmrgHHoB1B5k08JuMKHjQQJCS1K5VVSaMkEFYzFltk/HF ea0XBt1SbGcZ7gTmEX0PaVyARtvHTxZXnkvMssgy6yCOw3D1u0Z/La8jDpXRvqocyXWal6bGNfU 6c/lk3weVhkyosph55uIbW7W12bbNRgYwIQYxAln7HiZowlWSPWvuhtnNLgQKl2xK+UKg/GOf3o IJnxnEGE2aWVH4EUSckjtjEIlY7cHvupt42jZ56NPKRQmneO/XXDDWDOEZ5MYSYnkT0VdTdJai1 BhnfeoC3O34eXV2Zpa8vYPFffarsYE5KqBkZPSRY4wcz5NxPk99zvJwm+JC4IOm0h9xDbsOIfQ7 AmVokmCjbd0jbiI66HvdrbQCLv/vflNk6xuZ89Sew3nfY2Rd3evHONAUeIndnRj5ym+ZHtSYQaL 0oubHuFMu1kLFxrwv4KVIgQ7RhQom09eMfMoutJS0HKNSEnkmJ X-Received: by 2002:a17:903:3b8f:b0:2ae:cb0e:fd59 with SMTP id d9443c01a7336-2b28164cfebmr125528785ad.8.1775462947787; Mon, 06 Apr 2026 01:09:07 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af19sm127961835ad.50.2026.04.06.01.09.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:09:07 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v5 3/5] iio: ssp_sensors: factor out pending list add/remove helpers Date: Mon, 6 Apr 2026 13:38:50 +0530 Message-Id: <20260406080852.2727453-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260406080852.2727453-1-sanjayembedded@gmail.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda The SSP SPI transfer path manipulates the pending message list in multiple places, each time open-coding the same locking and list operations. Re-factor the pending list add and delete logic into small helper functions to avoid duplication and simplify transfer flow to follow. No functional change intended. Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_spi.c | 34 +++++++++++++++--------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/ssp_sensors/ssp_spi.c index 08ed92859be0..7c1780e15acf 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -174,6 +174,22 @@ static int ssp_check_lines(struct ssp_data *data, bool state) return 0; } +static inline void ssp_pending_add(struct ssp_data *data, + struct ssp_msg *msg) +{ + mutex_lock(&data->pending_lock); + list_add_tail(&msg->list, &data->pending_list); + mutex_unlock(&data->pending_lock); +} + +static inline void ssp_pending_del(struct ssp_data *data, + struct ssp_msg *msg) +{ + mutex_lock(&data->pending_lock); + list_del(&msg->list); + mutex_unlock(&data->pending_lock); +} + static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, struct completion *done, int timeout) { @@ -202,19 +218,13 @@ static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, goto _error_locked; } - if (!use_no_irq) { - mutex_lock(&data->pending_lock); - list_add_tail(&msg->list, &data->pending_list); - mutex_unlock(&data->pending_lock); - } + if (!use_no_irq) + ssp_pending_add(data, msg); status = ssp_check_lines(data, true); if (status < 0) { - if (!use_no_irq) { - mutex_lock(&data->pending_lock); - list_del(&msg->list); - mutex_unlock(&data->pending_lock); - } + if (!use_no_irq) + ssp_pending_del(data, msg); goto _error_locked; } @@ -224,9 +234,7 @@ static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, if (wait_for_completion_timeout(done, msecs_to_jiffies(timeout)) == 0) { - mutex_lock(&data->pending_lock); - list_del(&msg->list); - mutex_unlock(&data->pending_lock); + ssp_pending_del(data, msg); data->timeout_cnt++; return -ETIMEDOUT; -- 2.34.1