From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D545931D72E for ; Mon, 6 Apr 2026 09:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775467329; cv=none; b=rEcZIZ8C49V7NKK3x3hobQPcTNfUNPhhaTxGSWyDNb4XXXsOtgwwBPPc8xgM42fxEjzXvbIGpIf5e+5tAUD7VVBvKd9Hjny4j6r0owtziact6dLNMrKrepyh1SgIpfUEU2abcJu4VawHyK7lTJ1k41ybFyGQV2pEtcJlQx7g0JI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775467329; c=relaxed/simple; bh=nPmeLyKheAluha24MShpyFT0khgevoZVJ1J2O4svefg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gRRbgsDXe2509miu3cRTMNPdphsnygY+wioKoDoWAGlMhXNy6TkrG5kFBQrCiSOdro/Qs6G1que5GUQfBATVCW9koG0HEmA5pWbjSEh1RVSc/AJe4YGhmJzqvGdB9/Yb7G2IEU4vRNC739hKzo894qeC1/DBguArcHG7x/PnJdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EqWas/Kr; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EqWas/Kr" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso7891485e9.3 for ; Mon, 06 Apr 2026 02:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775467325; x=1776072125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oT3j7eJ56iHVhP23HyrLK/FqBqCArQkgm0YXamNGuoA=; b=EqWas/KrHzbI31X+4szvSQTwP+13RD/vBra04E37EFVTxwWWdOOtD3L2xfAvIeFo6S Hmfd1eCd3AfP9pHpIwupDhb6d6HyNmVpObjW4/6d5fQ4JBUF9uHPtJ3f6SLkYh2Q7fNM +vaPM19qyMPC0RdRfbe9/juY29NDZawvpc+ziEy8imxaT5/KgnKhgmBceTAquC4i8izu RG3hs4Gqi/5hk0VwVXhRMRRGlKkZjC91z+dqHwQFoKgx/bYqrs39rrSFo+GMluTvxACa NiLKfa7FSRvIy5fNPzWKr5i847tXle18IyPlf6c6/74QVIhsp/1Lh/NYZCwbOTbe5LfM Mpkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775467325; x=1776072125; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oT3j7eJ56iHVhP23HyrLK/FqBqCArQkgm0YXamNGuoA=; b=WhyXPKwWdMhat7P77blm/SG1lwyn2iphF0SoB/sKeeIq27QtFx054F2pVp3bRjXZbt 7jvLTpH1XZ0QHOHwoeR0ERSqalO97pQ6XljyeLZ3Lh1vIiMZWgRrJZ7LIOMnxsJtpV4j ZvPRCbmUzTzVsaUqYboPk9V/cg8EXfMm9HwRAD+hYXPi3kJRY7atajtwL5amMNqqWOfo EvJk40xDMu9DLgmLvgMTvF6cBGBK2Gg4uKngySIcktyF9hp/x03G7NPtda2tEm0rZD+/ lo8rBG3xQUdPfxmCzdvlz2glwG6TfkKuk0aN3YQHsvtiL3x9OPOdhHFlbPilLguPsAip HtQw== X-Forwarded-Encrypted: i=1; AJvYcCU2+1iEi5GnmS24RguwtsS62V3H3QWrbQWZZBEDYD3q71n/dU+Mmzafobu16OS/EtjAZb7OlTc8T8QTGyM=@vger.kernel.org X-Gm-Message-State: AOJu0YzUj/WxzzL2pkhKdBMP+0/QVOazbNeKM86Z20HiwzmW3G1prxlg s/s+2Cq+o20KlMceIu/yE5jVQ0mORRmPQavb0K+egj122RKHp2vqPcWP X-Gm-Gg: AeBDietq0zTblIjwwwPdnRlJdEr4mC32yEBhPiTCFXtzzSzwTDsfpbtdxf2xi6YziHx UrYQS0VbV/9oV8or7JASUEceB1Uy8zaH9EV5vB6L7XKDAWFONNQGPls60H6/9RsxGk6NHhKV/T2 WOk5VoT6G7Zf6/QhS1UqtRv+J6bwTyrg/Q9AcVX2WLcSSYocPlob5R7xSdq6aIDG4sTDqPAES/f w4PY80FhXFJK0dOpjMRuh/eIwZt2VlGLhxtWUAGxBUJzHDRc1oR4f3OIuLeRgr/+CDafPKTHiQ4 5lUFSVz6mZyg9zxZzfgloo4GkH4h7W5JWgpl8gmBNqvVGDLvoQp4ge2bwIZMACN4LyGPbfjVRP9 we7LJqRhYKUQaNJj6IWbJJbGq9RMlc4kCZIQP8MwnJrOS8yoO1XYw96jU153Jr/0MtkX+lAr5Hd 0vr/ZXChLNLZ9A9v0oaY9OUHC24d/c/JGFHDekYLiY/IHpLI3BViGC+knS8XCmRO4Oyy3YyMmuD mX9iMW7aBKKRTlDU3B6ZjUvCyzV2q1jA27emi0pC/s= X-Received: by 2002:a05:600c:3549:b0:485:30d4:6b9e with SMTP id 5b1f17b1804b1-488997d1f50mr164045015e9.21.1775467324920; Mon, 06 Apr 2026 02:22:04 -0700 (PDT) Received: from user-Vivobook-ASUSLaptop-K3504VA-K3504VA.lan ([2001:861:3380:8810:54d0:56ef:66b3:18ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48897fd5594sm87940235e9.3.2026.04.06.02.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 02:22:04 -0700 (PDT) From: Clement Amar To: "Michael S . Tsirkin" Cc: Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Clement Amar Subject: [PATCH] virtio: simplify of_node handling in virtio_device_of_init Date: Mon, 6 Apr 2026 11:21:59 +0200 Message-ID: <20260406092159.136447-1-clementamar@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace goto with return for simple error Signed-off-by: Clement Amar --- drivers/virtio/virtio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5bdc6b82b..b49113ea8 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -493,16 +493,12 @@ static int virtio_device_of_init(struct virtio_device *dev) * Simply don't init of_node in this case. */ if (!of_device_is_compatible(np, compat)) { - ret = 0; - goto out; + of_node_put(np); + return 0; } dev->dev.of_node = np; return 0; - -out: - of_node_put(np); - return ret; } /** -- 2.43.0