From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F9341EA7CE;
	Tue,  7 Apr 2026 01:43:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775526195; cv=none; b=b+FSNtpdl1e5c81w6pftjYBqQVqRzGtgMEk2d7Ywb/2F+xqmTXCkl3it2zbSSoXhKsFNFEbgqEYW3XDgaKjknRPY30sOgNbqK7b/VgdU0/qKYSzczeHcfQvbMHMrEYmHQHjKHM1wv4TEbpYRrDU1vH1ZNV5TP7ilZKukRPo5NZQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775526195; c=relaxed/simple;
	bh=/wFbz7nW/QdAMU7lzO7ww8Rlb/6Og7pScrCkte1ume8=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=B1IOjEWNXCZI9b8dr8K6QD8IIf6vjgr02C023dKLDQOQaWlJlQXBzg9sIUR/dcaq7WuW6fXK8KEm5q+Iua8rz/kKAAPDhMQzsTaLyTWB6fADBCraQbrZ5zem+ThWx0FhpqSlIzXYtvUqvzWykPzxu8IEl08fFjKf4gJi5syY01Q=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jGpkZP9/; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jGpkZP9/"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97172C4CEF7;
	Tue,  7 Apr 2026 01:43:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1775526195;
	bh=/wFbz7nW/QdAMU7lzO7ww8Rlb/6Og7pScrCkte1ume8=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=jGpkZP9/1jqW5AypC2rOM6aKCKax0we2yimxgUEBGjSvDEDLqGNRR9sIbNjhbEqWi
	 0h3/Y/KPvR/EKuVxoGcd40yY/xJ0eMRKWISXNN/ORQ/wASsgSf1Zb5tjOv15Wff3kn
	 rL3qiqQZ3uqWFjTv694gH8t/xabJ8UqNiYM7mq5FCID3jOgLSGGOfv4EXl8qPOUlI4
	 XseC6esSeKMz4QkGImsFtOj+G4ETd+zYJtDCT4FGr9WRULdjvH+41Rx9XpyOgieXG5
	 vPKzdmbFsGOAEzNZu8l1Cvzr0RCQ2+FGuA6e/p18NRXTwomvLALmRLfRZ9Z3wpexQz
	 0bnYtwx5ojf4A==
Date: Mon, 6 Apr 2026 18:43:13 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>, <edumazet@google.com>,
 <pabeni@redhat.com>, <horms@kernel.org>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ipv6: sit: remove redundant ret = 0 assignment
Message-ID: <20260406184313.5c446354@kernel.org>
In-Reply-To: <20260403084402.4105936-1-yuehaibing@huawei.com>
References: <20260403084402.4105936-1-yuehaibing@huawei.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 3 Apr 2026 16:44:02 +0800 Yue Haibing wrote:
> The variable ret is initialized to 0 when it is defined
> and is not modified before copy_to_user().

Makes more sense to remove the init during definition IMO.