From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54F539C63A for ; Mon, 6 Apr 2026 20:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775506447; cv=none; b=J9okWQL2qJ6iiYK8X2tuXvU/jWHGo4z+FzASmgf7fI72pQNPfZtW0Lz5uWR32VHE4OXpKvuGoHHnTHIUfX3Ma2lIe/3nw+0mVGbd/C8i5w9QmFxBuecoNw2LtC089JkOExzbGE/tOWfIIGsI7OAPPAfM18YucrgQ/RBr8dH42dU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775506447; c=relaxed/simple; bh=A5nBMBkWkafHNY7USWwQbGA1Gg3Rjn8l3CkT7z4RWhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mPVwICMvL6rNmftqVURSN/mk1ISTvOXapHqsv4mU9HB+iE+r5jsXbD0SBewpXdjC1lxkMes/kr0Z9tycujOPnx+MJV0Nyn8fQTMzYbqIJUj3Y29lv9inx7Yacxmramn4fA3P8D/0C1K7FYWAU9PnctV4p3pJs6T2dkJlSM0l55U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NYqpV1Z0; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NYqpV1Z0" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-1271195d2a7so9286221c88.0 for ; Mon, 06 Apr 2026 13:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775506445; x=1776111245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c2sfsoM3eXXD/i3TYQHRzXUhUiniPGPfrTop9I4lCjo=; b=NYqpV1Z0VZog+MsPIJfogi+iN5OKCVUNF08wCZjx3SuwuKNIfPPI4CJjj87jt1yMY1 RIUXB6gg+2y8/MMVxHZgegsWDN4y2i0kpzGABhzTWwzltiUIOOyNCZav3dwizLpQNTPh wzL5U2NstNyM7UHZNp4I8K1k/02RNq+SJY2unl/louZrW8RpHSRyY6dtU5YvUWqIpZeF LEPCRuUbYduWe7fvWViPdg6FoKNwSA6OGiMf7s6E5JPs0GnzRWeiwmeUCrFMPysLnrly lrgunZVPn4CXszLNqvKoH/L8Wwze7f6oRpEwMbFfgnQk+glcqhwqPoLgN8K+kWgcVxSb wgmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775506445; x=1776111245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c2sfsoM3eXXD/i3TYQHRzXUhUiniPGPfrTop9I4lCjo=; b=m9Q2SxuqJRnVq++UQgiqF1nbC8u5sMB3sfrgyfo9dVUWY6yHTtLj/teMSPV9FWG+5G 1YVpyqa/I/QR0i0HvsEvA4+QSezMpFhTi+BImY6cz4Hm3FQI+Gh5AS37/O/ePSXx23Mw uJhltOdRkWofsoMNuaHfh/VFfZhJTwtisS1eNnS5AqTSCKjTsgT4UeNmJnvlPh22BB9s 6CfvWWeduSQavUZFbLP1Ph9svEuB+3y0SBG65KtNjuADdEpbRn1YYzwpdDO3QdE8n8hp f3Rqg0wgYZyn2EQF63w/7JccRvaBuy2Jlgy89xAP+gKqQizi1+XUTh7g/4vJZsfAlHHV KIkg== X-Forwarded-Encrypted: i=1; AJvYcCV72iAevXefOx/cAa3kfC4kNlp7qP6XVg/WFk50JYrCEIsYAPBDyVG7QySTXNAh36Ev45SaixB5XsTFVyw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy843s9MEKnBjs4nQeoaz8SSptz9TPXdU4V5mjt9sCjRdqUWcsR SyErcXfuMjFD0GZqoMUNm6MVj0Bl5/bJTSzy0KBYDXNnzE/MJcAKCnG7 X-Gm-Gg: AeBDietr2XXMWYqikhbaDFpN5Ya1L0BzHI82Vf5YwXt5a9QNQH9c4jd84xEMO5pEabw ns0A3MLHAMm9ddrajMQcXKsU07jK2dPW685gqobDHMlXJtXR322BNTSyvGX6S53PJcIRDNDBfSF 68+UmoRQ4hsZeBnhH5ZXoO6oYNNsJecu5rBZw8+PJjMS6u6Qw6GXkWg0WMUItlXaQO8j8Nr//+O 8VRbG6WoGYFtYoYmNYS/TASWswYnIDlB7Kxk5u86POXsgq0arac5I66qQHGjNT8V40IjNOnQlsJ U3b5PxWkLBkvvO6mSKIVMpAnZ/YJcCC6Wy9T2mhrfrV9f3O+NDy+I4eUsFb9Yx243OY58/urlCm sDcdzjiViOwHLNKaYXBxx4TldDt9KRqKtVw793X7ALv/AccDbihDr6Q+zNeue/Mcx9OW6PIFztY w3XX/Ap1/v6YhlE6u9E3xWXc8OmNpbHPnNR7Qz31pIveaZdV1zAJG/jV0k6KgEw4niN975kEvrJ QYm X-Received: by 2002:a05:7022:1603:b0:12b:ec96:c936 with SMTP id a92af1059eb24-12bfb70bfe6mr6740371c88.14.1775506444895; Mon, 06 Apr 2026 13:14:04 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bed93f861sm17022333c88.0.2026.04.06.13.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 13:14:04 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v8 03/16] platform/x86: lenovo-wmi-other: Balance component bind and unbind Date: Mon, 6 Apr 2026 20:13:47 +0000 Message-ID: <20260406201400.438221-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260406201400.438221-1-derekjohn.clark@gmail.com> References: <20260406201400.438221-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rong Zhang When lwmi_om_master_bind() fails, the master device's components are left bound, with the aggregate device destroyed due to the failure (found by sashiko.dev [1]). Balance calls to component_bind_all() and component_unbind_all() when an error is propagated to the component framework. No functional change intended. Fixes: edc4b183b794 ("platform/x86: Add Lenovo Other Mode WMI Driver") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clark%40gmail.com [1] Signed-off-by: Rong Zhang --- drivers/platform/x86/lenovo/wmi-other.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index b47418df099f..4b47b5886e33 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -1068,8 +1068,11 @@ static int lwmi_om_master_bind(struct device *dev) priv->cd00_list = binder.cd00_list; priv->cd01_list = binder.cd01_list; - if (!priv->cd00_list || !priv->cd01_list) + if (!priv->cd00_list || !priv->cd01_list) { + component_unbind_all(dev, NULL); + return -ENODEV; + } lwmi_om_fan_info_collect_cd00(priv); -- 2.53.0