From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34633368BD
	for <linux-kernel@vger.kernel.org>; Tue,  7 Apr 2026 05:24:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775539445; cv=none; b=oKAeNd2DFeVOUD+1mY5WH9YvNCMBgEBOH6b+Psy8pc38+C+I2G07yV/1ppa1P5pSks/2PSiCSHl+uPA32qfC09QDCxjUEQkJmXTNOIOPlQP9ApQPKlriASuo4I21ui3bCecxpW5SleBdZvxKX6/6bGYp1BJ0XzPDe73u9PbDRQo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775539445; c=relaxed/simple;
	bh=3TzdHPPvxsTlr9rTdvmbZTkDiWgZFSVqaAUGddtX5AI=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=l6I8Yxn63egnNI4eNgerQtbigr0LNbAE/FgCzQeP3HNr1QkJi031Tm5pBqyeXORiNznkwmEU5hINlZ6QMpvDxOHjZ79GUq/I0tTW+r9Jg7oshDtNmXRylk/rwv1r/EkE29yDcivSaNN/dfNUH5m2Hp4MJ03Q6u5JT50bBPXv2sU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id D4CA968C4E; Tue,  7 Apr 2026 07:23:58 +0200 (CEST)
Date: Tue, 7 Apr 2026 07:23:58 +0200
From: Christoph Hellwig <hch@lst.de>
To: Aurelien Aptel <aaptel@nvidia.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, smalin@nvidia.com,
	linux-kernel@vger.kernel.org, Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: Re: [PATCH v2] nvmet: introduce new mdts configuration entry
Message-ID: <20260407052358.GA6089@lst.de>
References: <253ikaa1woe.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me> <20260402132108.250386-1-aaptel@nvidia.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260402132108.250386-1-aaptel@nvidia.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Apr 02, 2026 at 01:21:08PM +0000, Aurelien Aptel wrote:
> +static inline u8 nvmet_ctrl_mdts(struct nvmet_req *req)
> +{
> +	struct nvmet_ctrl *ctrl = req->sq->ctrl;
> +	u8 mdts;
> +
> +	/* Limit MDTS according to port config or transport capability */
> +	mdts = req->port->mdts;
> +	if (ctrl->ops->get_mdts)
> +		mdts = min_not_zero(ctrl->ops->get_mdts(ctrl), mdts);
> +
> +	return mdts;

This could be simplified a little more:

/* Limit MDTS according to port config or transport capability */
+static inline u8 nvmet_ctrl_mdts(struct nvmet_req *req)
{
	struct nvmet_ctrl *ctrl = req->sq->ctrl;
	u8 mdts = req->port->mdts;

	if (!ctrl->ops->get_mdts)
		return mdts;
	return min_not_zero(ctrl->ops->get_mdts(ctrl), mdts);
}

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>