public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Georg Klima <Georg.Klima@durst-group.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"thunderbolt@lists.linux.dev" <thunderbolt@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"georg_klima@gmx.at" <georg_klima@gmx.at>,
	Rene Sapiens <rene.sapiens@linux.intel.com>,
	Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
Subject: Re: [BUG] Thunderbolt runtime resume during PCIe removal causes IRQ warning and shutdown failure.
Date: Tue, 7 Apr 2026 07:41:51 +0200	[thread overview]
Message-ID: <20260407054151.GC3552@black.igk.intel.com> (raw)
In-Reply-To: <adIkaExcG-T5XACV@wunner.de>

Hi,

On Sun, Apr 05, 2026 at 10:59:20AM +0200, Lukas Wunner wrote:
> [cc += Mika, Rene, Alan; start of thread is here:
> https://lore.kernel.org/all/AM9PR10MB42316BF3E59B29E1EA3E5600B756A@AM9PR10MB4231.EURPRD10.PROD.OUTLOOK.COM/
> ]
> 
> On Thu, Mar 26, 2026 at 04:09:05PM +0000, Georg Klima wrote:
> > I am reporting a reproducible shutdown issue involving Thunderbolt,
> > PCIe hotplug, and runtime PM on a Lenovo ThinkPad P16.
> > System fails to power off cleanly when PCIe ASPM is enabled.
> > After the kernel prints "Power off", it emits warnings and does not
> > complete shutdown.
> 
> The dmesg output shows that the problems start much earlier than
> on shutdown:  The discrete "Barlow Ridge" Thunderbolt controller
> is hot-removed at the 08:44:29 timestamp in a noisy fashion:
> 
> > Mar 26 08:44:28 fedora kernel: usb 3-3: reset full-speed USB device number 2 using xhci_hcd
> > Mar 26 08:44:29 fedora kernel: pcieport 0000:80:1b.4: Data Link Layer Link Active not set in 100 msec
> > Mar 26 08:44:29 fedora kernel: pcieport 0000:80:1b.4: pciehp: Slot(25): Card not present
> > Mar 26 08:44:29 fedora kernel: ------------[ cut here ]------------
> > Mar 26 08:44:29 fedora kernel: thunderbolt 0000:8a:00.0: interrupt for TX ring 0 is already enabled
> > Mar 26 08:44:29 fedora kernel: xhci_hcd 0000:b1:00.0: Controller not ready at resume -19
> > Mar 26 08:44:29 fedora kernel: xhci_hcd 0000:b1:00.0: PCI post-resume error -19!
> > Mar 26 08:44:29 fedora kernel: xhci_hcd 0000:b1:00.0: HC died; cleaning up
> > Mar 26 08:44:29 fedora kernel: WARNING: drivers/thunderbolt/nhi.c:147 at ring_interrupt_active+0x246/0x2f0 [thunderbolt], CPU#3: kworker/u96:5/1092
> 
> The controller is then re-discovered after the link goes back up.
> The actual shutdown doesn't seem to start until the 08:45:26 timestamp.
> 
> Going forward please use "dmesg" to collect kernel output, not journalctl,
> so that we get timestamps with usec granularity.
> 
> >   *   Hardware: Lenovo ThinkPad P16 (21RQ003BGE)
> >   *   BIOS: N4FET30W (1.11) 10/03/2025
> >   *   Kernel: 6.19.10-200.fc43.x86_64
> >   *   Distribution: Fedora 43
> >   *   Platform: Intel (Meteor Lake)
> >   *   Thunderbolt controller: 0000:8a:00.0
> 
> It looks like this isn't Meteor Lake but Arrow Lake-S:
> 
> 0000:80:1b.4 - Arrow Lake-S (800 Series) PCH Root Port #21
>   0000:88:00.0 - Barlow Ridge Upstream Port
>     0000:89:00.0 - Barlow Ridge Downstream Port to NHI
>       0000:8a:00.0 - Barlow Ridge NHI
> 

Looking at the dmesg there is hotplug enabled for the PCIe root port:

  Mar 26 09:44:00 fedora kernel: pcieport 0000:80:1b.4: pciehp: Slot #25 AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug+ Surprise+ Interlock- NoCompl+ IbPresDis- LLActRep+

For Barlow Ridge it should be disabled. Lenovo may already have a BIOS fix
please check. They have done that for other models too.

      reply	other threads:[~2026-04-07  5:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 16:09 [BUG] Thunderbolt runtime resume during PCIe removal causes IRQ warning and shutdown failure Georg Klima
2026-03-26 17:57 ` Bjorn Helgaas
2026-03-27  7:01   ` AW: " Georg Klima
2026-03-27 17:28     ` Georg Klima
2026-04-02 22:20       ` Bjorn Helgaas
2026-04-05  8:59 ` Lukas Wunner
2026-04-07  5:41   ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407054151.GC3552@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=Georg.Klima@durst-group.com \
    --cc=alan.borzeszkowski@linux.intel.com \
    --cc=georg_klima@gmx.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rene.sapiens@linux.intel.com \
    --cc=thunderbolt@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox