From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <wagi@monom.org>
Cc: Christoph Hellwig <hch@lst.de>, Daniel Wagner <wagi@kernel.org>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: expose TLS mode
Date: Tue, 7 Apr 2026 07:54:12 +0200 [thread overview]
Message-ID: <20260407055412.GB6405@lst.de> (raw)
In-Reply-To: <ac373146-cf2d-47e0-a851-9c304bacd5f2@nitrogen.local>
On Thu, Apr 02, 2026 at 08:42:57AM +0200, Daniel Wagner wrote:
> On Wed, Apr 01, 2026 at 04:09:34PM +0200, Christoph Hellwig wrote:
> > Looks fine to me with the example fixed.
>
> BTW, do you think an empty string is better instead of "none" when TLS
> is off?
Empty strings are confusing, so either none or off would be much
preferred. Out of the two none would be my slight preference.
next prev parent reply other threads:[~2026-04-07 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 8:52 [PATCH] nvme: expose TLS mode Daniel Wagner
2026-04-01 9:04 ` Daniel Wagner
2026-04-01 14:09 ` Christoph Hellwig
2026-04-02 6:42 ` Daniel Wagner
2026-04-07 5:54 ` Christoph Hellwig [this message]
2026-04-07 10:47 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407055412.GB6405@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wagi@kernel.org \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox