public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Yicong Hui <yiconghui@gmail.com>
Cc: steven.price@arm.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
	me@brighamcampbell.com
Subject: Re: [PATCH] drm/panthor: Fix kernel-doc warning in panthor_sched.c
Date: Tue, 7 Apr 2026 08:58:32 +0200	[thread overview]
Message-ID: <20260407085832.51a4d169@fedora> (raw)
In-Reply-To: <20260405192309.389039-1-yiconghui@gmail.com>

On Sun,  5 Apr 2026 20:23:09 +0100
Yicong Hui <yiconghui@gmail.com> wrote:

> Fix the following W=1 kerneldoc warnings by adding the missing parameter
> descriptions for @ptdev and @events in panthor_sched_report_fw_events()
> and @ptdev in panthor_sched_report_mmu_fault()
> 
> Warning: drivers/gpu/drm/panthor/panthor_sched.c:1898 function parameter 'ptdev' not described in 'panthor_sched_report_fw_events'
> Warning: drivers/gpu/drm/panthor/panthor_sched.c:1898 function parameter 'events' not described in 'panthor_sched_report_fw_events'
> Warning: drivers/gpu/drm/panthor/panthor_sched.c:2783 function parameter 'ptdev' not described in 'panthor_sched_report_mmu_fault'
> 
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Signed-off-by: Yicong Hui <yiconghui@gmail.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_sched.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index a70f1db0764e..2d6dc5db4148 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -1894,6 +1894,8 @@ static void process_fw_events_work(struct work_struct *work)
>  
>  /**
>   * panthor_sched_report_fw_events() - Report FW events to the scheduler.
> + * @ptdev: Device.
> + * @events: Bitmask of pending FW events to report.
>   */
>  void panthor_sched_report_fw_events(struct panthor_device *ptdev, u32 events)
>  {
> @@ -2779,6 +2781,7 @@ static void panthor_group_start(struct panthor_group *group)
>  
>  /**
>   * panthor_sched_report_mmu_fault() - Report MMU faults to the scheduler.
> + * @ptdev: Device.
>   */
>  void panthor_sched_report_mmu_fault(struct panthor_device *ptdev)
>  {


  reply	other threads:[~2026-04-07  6:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 19:23 [PATCH] drm/panthor: Fix kernel-doc warning in panthor_sched.c Yicong Hui
2026-04-07  6:58 ` Boris Brezillon [this message]
2026-04-08  8:57 ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407085832.51a4d169@fedora \
    --to=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@brighamcampbell.com \
    --cc=skhan@linuxfoundation.org \
    --cc=steven.price@arm.com \
    --cc=yiconghui@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox