From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36D4D3B47C6 for ; Tue, 7 Apr 2026 12:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775565893; cv=none; b=nWNGvuRJtgXZKeKAF2zpkUk/KnbByxvryz1zQnUhKfbI57cwSwl3iV/IEwhjciz4esUZ/m9SaAJfklS5PbuDP+WUOYnv85CtqMK8BG7ahQgpXlhwOalBRAOjbpY9Qtxpy6Q9Nf7H8ueka3dyu8/9A8p0bdRahESzfR9NWGQrwYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775565893; c=relaxed/simple; bh=6vOJo8cFxGIBGsgdZ72PCKdeMVx3dnSGChMlP1LRF/0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OffDwrq0feeuyvq/xrOdledbnbaAHOl3+lq94LfLesfLp1aCPftpQdsBFkKMdhR5ZVSg/ZXVaxtNZbHg0ZHz0megVitNqyM3g69OBe3fdxujEwCIYplOp8x73U5YZH81nisxspKm/D8ruNMntbGwsevi4uv0UprrKEJgXgrDq8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CBBMQ8Yx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A1NYGiD7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CBBMQ8Yx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A1NYGiD7" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376Wj9V3402384 for ; Tue, 7 Apr 2026 12:44:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+McTs62jXEi G+U6yhLRFrie/mtKMh+Q9ylHrEG5OPXc=; b=CBBMQ8YxfOv+T/jzRRSo2B18sd1 m9Wb5pVeCQi6kxLETjsFqcZHFe/DR6BbDk+nLiHhG9LlQ3wPL5w/4nGNGgpo9gWz hv1UeTtbJaoLSZlDCnyQRYSmBRejyqumEgPjHYVHXNOETM+/UdBLsWCg3EonNT1Y 0Imt7UuvQC6MNkcgnoBHxWpr7ybgPCgPYFuIax4tNUqJBcPMXyvqeZcTR9EEaUA5 3HJZ/wMbYetGZ1lUNvs67RVr8Vm9cOXWs0syyhsJCuYUBzxsfjMpX8jNWZD4LfPP yEE1EGrkJZazM35Hw9omJJHdLPPoebNt5SPPmGaniBvGL7q5WmZ4/Z7jVkA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrhtqb6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 12:44:51 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82c9364612fso7255265b3a.2 for ; Tue, 07 Apr 2026 05:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775565890; x=1776170690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+McTs62jXEiG+U6yhLRFrie/mtKMh+Q9ylHrEG5OPXc=; b=A1NYGiD7KmLmZBApR6f1cTYl+8XH3f1PtW5JwJkKBTysVZOPjkjDdQKB87/Yb+cBEz 7GKKKq7JQkWF7gOU+sTmOah0XT2LU8T3VXWyJ3v1Qv4f0Bww6s8JDueo1cTnbyPmpPTo TotlStST8QdG26wT0PHFY34FIPxEDlhSXhOhQWtdVxt+LoP+oKrLBnOP7zhWER2JWGP/ AN8DtMTSv7IOPSDGbaCE2Q51rIXyQDhGELFxOS50TqQvNe1Tex2QilQpMlh5tYC7bE3F iarzaQ8fzUg6DP+BO9STCrbO6TzLdMmvtSxkaVbKmYOTCvjtWiaedLUD/01+EumN7ga+ g5SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775565890; x=1776170690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+McTs62jXEiG+U6yhLRFrie/mtKMh+Q9ylHrEG5OPXc=; b=DHtHz2t5dlq0BLCJMOZhcTRI+nJSZw36aa7CGTxuXGVSHpEWlsiMNRxqjEeZ5XMsD1 DCW1dj/YwvF/DeH4REKPT6BZc0E3VIU0KMIJTOBJf/X2t7XXw3QtqaGoJs1App8VKKVU ZJaW+j36f0e0+Yuv/Hj6sqaRDEOEIDASST925ofwiXF7ukO7jGjUgZ/jKmiQLcGdzS40 9/NOgc1KS1uQhR2XjqNa+dL5LyuqxtKiNc5fd8SIDUC6niHA4y8SD4vp0VDkfk7JEDUU tmlTwzv6/9bzxAMhf7wYC7Rth35L1pN8Y82XYSbcfPKqAQE8Nz1Abmq7OAMewKTSfAxJ Phug== X-Forwarded-Encrypted: i=1; AJvYcCWT9RcSub6v1XyfQ6XOYp8GUFU8lTL4UufpOEuJtp0/oXYmdlqipAjIBcMizsDQbu61ifG82lGH6gnuR5E=@vger.kernel.org X-Gm-Message-State: AOJu0YyUU9LPnzfL9o+ijNsQUNMTpQWNaOJ1JmNAqptXA7+U4raRmffI 44Mf8wYEl4qhknBg+XMvPw6+YAhWqLASBqay3hicQBh3rUOTSToS0j9z387m9314ity7VKOLM03 2+bdExxWShc9V5RGbQUjugvJ73BaMJgUeZGQiElVaC7JS3JXwZ4op/CELVj0Z5pZl8v0= X-Gm-Gg: AeBDietSW0ENsUlbgfs6HFO/484Fl5wLcBxvCn/T0YHj8IqjpkC1LoForDnno8E23nd HXRYweSdydVxmpQKPUt+Hz7a/bbRSJSRmdCR/zUwlYKRP9tp0ixNneF02OO/rAkk45IoOZdwxg4 B/Y+AR6H6BBtld8iptUy6HTM5BbQhIKioAeKU3r/CIkwdqKQEnK0YV5H9TSpvkMcUSWgg8iDKz3 RnxZlgyXNf6N7A2dTocGS6bcGIkJWsPCgGyAZhQPnJFF2zW6aPta2N1EXv2F11wQs9qkThr8MVr sCy97U/+AXeMuVHDeQ1J2im9ufgbjtiLacDyhhmKqoR4JcP5hWjtc8mB2OVSk02LflEXBkonH6c z7czhUQ== X-Received: by 2002:a05:6a00:451b:b0:829:9c5d:4342 with SMTP id d2e1a72fcca58-82d0dbdeb04mr16111008b3a.54.1775565890153; Tue, 07 Apr 2026 05:44:50 -0700 (PDT) X-Received: by 2002:a05:6a00:451b:b0:829:9c5d:4342 with SMTP id d2e1a72fcca58-82d0dbdeb04mr16110973b3a.54.1775565889440; Tue, 07 Apr 2026 05:44:49 -0700 (PDT) Received: from work ([120.60.133.76]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c3ce13sm18262551b3a.38.2026.04.07.05.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 05:44:48 -0700 (PDT) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: mani@kernel.org, kwilczynski@kernel.org, kishon@kernel.org, bhelgaas@google.com Cc: jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com, ntb@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, den@valinux.co.jp, Frank.li@nxp.com, Manivannan Sadhasivam Subject: [PATCH 2/2] PCI: endpoint: pci-epf-ntb: Add check to detect 'db_count' value of 0 Date: Tue, 7 Apr 2026 18:14:21 +0530 Message-ID: <20260407124421.282766-3-mani@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260407124421.282766-1-mani@kernel.org> References: <20260407124421.282766-1-mani@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDExOSBTYWx0ZWRfX193nn9wwFvj9 jsQEROPTn6N9OGcrpRu7QnZMuKXYFS0ErORFafBOz2ELHARmwqZVNSm/fGiEK4WKSZfYhjZRKuP TrXFKNtTV8APr2zUN6Wuh/xKWJRfj4yTs2a/7pxaawY/8bixsY2N0ZW5N8i/cJmdr4F3mR2F7ax 0bK+fWIyFFgmuqmSuFboyu8C5B4jGnWfmhhbq+IXkNSMIxj0c1fYkJBaZD+NrvOOO//ylidVHzd L+IcQX22a/c8xW7aSy9TMe3fEItWcHWFn3k9HDpTG67+zzcX3DSbggNI10X9ddRp/BErt6XUeJY 8tOiW4wLhoKviFBmSe1CL+SzJSPcsyfP0Yx7VocdMN9wUSwyjrpoWnLW8F/djbwBMWUUeuBjgqd FZFJOBbnhI4nMHiie4+MyINcwNWPEA2DDYL8xHNpiP1aJdE5Sid4v4O9foz2Lqb+02sOim/Qxxz KtANN78O9JW0f3ayveQ== X-Proofpoint-GUID: 8iMo5Ak1gyTM_Q1It8i5JuqiWl-6bUx1 X-Authority-Analysis: v=2.4 cv=XPUAjwhE c=1 sm=1 tr=0 ts=69d4fc43 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=yDxY/ZQAnAaCL67VaoekCQ==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=PxpW6Q19wR3HJFGb5M4A:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: 8iMo5Ak1gyTM_Q1It8i5JuqiWl-6bUx1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070119 From: Manivannan Sadhasivam epf_ntb::db_count value should be within 1 to MAX_DB_COUNT. Current code only checks for the upper bound, while the lower bound is unchecked. This can cause a lot of issues in the driver if the user passes 'db_count' as 0. So add a check for 0 also. While at it, remove the redundant 'db_count' assignment. Fixes: 8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality") Signed-off-by: Manivannan Sadhasivam --- drivers/pci/endpoint/functions/pci-epf-ntb.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-ntb.c b/drivers/pci/endpoint/functions/pci-epf-ntb.c index 2bdcc35b652c..7edd177f861f 100644 --- a/drivers/pci/endpoint/functions/pci-epf-ntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-ntb.c @@ -559,12 +559,15 @@ static int epf_ntb_configure_db(struct epf_ntb *ntb, struct pci_epc *epc; int ret; - if (db_count > MAX_DB_COUNT) - return -EINVAL; - ntb_epc = ntb->epc[type]; epc = ntb_epc->epc; + if (!db_count || db_count > MAX_DB_COUNT) { + dev_err(&epc->dev, "DB count %d out of range (1 - %d)\n", + db_count, MAX_DB_COUNT); + return -EINVAL; + } + if (msix) ret = epf_ntb_configure_msix(ntb, type, db_count); else @@ -1297,12 +1300,12 @@ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb, vfunc_no = ntb_epc->vfunc_no; db_count = ntb->db_count; - if (db_count > MAX_DB_COUNT) { - dev_err(dev, "DB count cannot be more than %d\n", MAX_DB_COUNT); + if (!db_count || db_count > MAX_DB_COUNT) { + dev_err(dev, "DB count %d out of range (1 - %d)\n", + db_count, MAX_DB_COUNT); return -EINVAL; } - ntb->db_count = db_count; epc = ntb_epc->epc; if (msi_capable) { -- 2.51.0