* [PATCH] lib/vsprintf: use bool for local decode variable
@ 2026-04-07 18:18 Thorsten Blum
2026-04-07 19:29 ` David Laight
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-04-07 18:18 UTC (permalink / raw)
To: Andrew Morton, Petr Mladek, Steven Rostedt, Andy Shevchenko,
Rasmus Villemoes, Sergey Senozhatsky
Cc: Thorsten Blum, linux-kernel
The local variable 'decode' is only used as a boolean value - change its
data type from int to bool accordingly.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
lib/vsprintf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 800b8ac49f53..9f359b31c8d1 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1107,7 +1107,7 @@ char *resource_string(char *buf, char *end, struct resource *res,
2*RSRC_BUF_SIZE + FLAG_BUF_SIZE + RAW_BUF_SIZE)];
char *p = sym, *pend = sym + sizeof(sym);
- int decode = (fmt[0] == 'R') ? 1 : 0;
+ bool decode = fmt[0] == 'R';
const struct printf_spec *specp;
if (check_pointer(&buf, end, res, spec))
@@ -1132,7 +1132,7 @@ char *resource_string(char *buf, char *end, struct resource *res,
} else {
p = string_nocheck(p, pend, "??? ", str_spec);
specp = &mem_spec;
- decode = 0;
+ decode = false;
}
if (decode && res->flags & IORESOURCE_UNSET) {
p = string_nocheck(p, pend, "size ", str_spec);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] lib/vsprintf: use bool for local decode variable
2026-04-07 18:18 [PATCH] lib/vsprintf: use bool for local decode variable Thorsten Blum
@ 2026-04-07 19:29 ` David Laight
0 siblings, 0 replies; 2+ messages in thread
From: David Laight @ 2026-04-07 19:29 UTC (permalink / raw)
To: Thorsten Blum
Cc: Andrew Morton, Petr Mladek, Steven Rostedt, Andy Shevchenko,
Rasmus Villemoes, Sergey Senozhatsky, linux-kernel
On Tue, 7 Apr 2026 20:18:36 +0200
Thorsten Blum <thorsten.blum@linux.dev> wrote:
> The local variable 'decode' is only used as a boolean value - change its
> data type from int to bool accordingly.
Hopefully the compiler actually does:
int decode = fmt[0];
and then compares against 'R' later on.
But this change ought to make absolutely no difference to the code.
David
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> lib/vsprintf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 800b8ac49f53..9f359b31c8d1 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1107,7 +1107,7 @@ char *resource_string(char *buf, char *end, struct resource *res,
> 2*RSRC_BUF_SIZE + FLAG_BUF_SIZE + RAW_BUF_SIZE)];
>
> char *p = sym, *pend = sym + sizeof(sym);
> - int decode = (fmt[0] == 'R') ? 1 : 0;
> + bool decode = fmt[0] == 'R';
> const struct printf_spec *specp;
>
> if (check_pointer(&buf, end, res, spec))
> @@ -1132,7 +1132,7 @@ char *resource_string(char *buf, char *end, struct resource *res,
> } else {
> p = string_nocheck(p, pend, "??? ", str_spec);
> specp = &mem_spec;
> - decode = 0;
> + decode = false;
> }
> if (decode && res->flags & IORESOURCE_UNSET) {
> p = string_nocheck(p, pend, "size ", str_spec);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-07 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-07 18:18 [PATCH] lib/vsprintf: use bool for local decode variable Thorsten Blum
2026-04-07 19:29 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox