From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE0F37754F for ; Tue, 7 Apr 2026 19:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775590171; cv=none; b=Ov6oys+c6r4rbr2FZOb+8c1uZdJVw/kmAmPAdFZmGgS5xmaQP3vit3tcDEUXtbyMQN2c6RTagjupzBhbo1hoqiccOIWmsVQhjlcfxOCSjhWufhA2/1hKK4gutsVUko4OLuYyKeTuy6G07dJYnSD0HZZ4lM645WWopLt2oMdQRXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775590171; c=relaxed/simple; bh=1WTxB//ckyRlc3X3kYpOzmRm/zZ7RZjxr11GIAHVcNc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YTC6EvWJ6Qaak0dlnZWK9Ib8uW7Tgih6BXsqe3NEA7zVUPs3gGyjDrtxEgR9cjWVwJ12KQDbZX4j68qMuThsppQceVzswJF5qQRdUUuol4x8rtj8nequJfFG19rRrj+OmyGTBi6go2VFOSJ8lXW4H3J2jz3mt0R376f4mrJJuo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MZqOSPZt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MZqOSPZt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso50784615e9.1 for ; Tue, 07 Apr 2026 12:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775590169; x=1776194969; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=B/5BnkD5wMNATjs9x/u+/fkcsiKrrnlSJoevoV9tJxM=; b=MZqOSPZt8laxbLCB+tEWXESJ5OQtwI8N2hRfutUffgCSEPHj+El/G7SqhhudEQFNGa XPpHCJFPKQH2TiCcoTKeTUsLR64fLDAvnlCa9sm13cvC50ig6twNoXLTwAIcQrhPUfly NB11ynhJuVUfCTlzdKQ7LxO47aAfGqAkc1OjM32fxebK2p9AvwJhXNT9US4yFpJagFaV N61+ladRB6AjeAeLHI5WZepzMmTESg5FmphzCCvJ+UH+8B6ZrBQBCLKwlVJjYNKRyd+7 Hb05+SmqfJ68LLSKjPy4ucjRxcdT4gxYJeHDA5p9NpB2v94YTX7bu2vCLIasHpKS4iYO N8fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775590169; x=1776194969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B/5BnkD5wMNATjs9x/u+/fkcsiKrrnlSJoevoV9tJxM=; b=iaY80Gmw+odyi/P0oy5j94zCSGeya0YK7GdjNqhrugiSPbPbJjWKiHR22WmogZLzT6 h8S+sSo8SZf7pWV/iHBtENiaoxA/Xir6gXVK2gNtm4D+/gdbQ61Oapx3Dr/b6IKdrV3I Wn+EoydEe4hGOjNV++FepXu6tqp8VUM2bOECRfTA9shxvIjJS6oHmF2mJsFSEZ0kBRSg 5U6wudhhF/V2WmZtNUR80/JhCGuzX863PWqXBMEWL8gzqqWn4FtDvyAf4Bh9Bl0A1Z+R 9Rm8pZMBIz/Lr2Cgx2HRejkP8o+b+wiYLgFurIZgHvu11wA9Gyye24O94qeduDNHSNdW tQiw== X-Forwarded-Encrypted: i=1; AJvYcCWk6ntEgRvcr5u9hrPT2RPLkWAStTFw6+bEXknZy2/i+FVMnObHVGl5AHB5MR8pXCHp2fobE6zLwUtHe1I=@vger.kernel.org X-Gm-Message-State: AOJu0YxETFY5F/HzrsAn1BRT2+OzbPQkXJ9UV9Aqkouu8uu8yVE9ctkD cMk8YAFW+WexYPj9/ChDNBSTWk9hJZFYwOev9mY2tVb8fzpJ4r7r2n/6uWOvAsZe X-Gm-Gg: AeBDieuQPzf12vh9oNIUJLGrE+zR2P3SqvNXom82Jw70fLiS7YYxbpAQ47y7ySu4Dfl bG/tpP0qw1RZMFhbblsUcDXsXwAE4FxRIY0Sg/KXa8UOKrAUs6KcP4CePOYna2mUXiXeyyHfkQh Lku+OFCLBfOiNeeyiq4PD7fCyHeUz/A39oVB7xYFkpruFHMuBjKJXzqmjZTsamVCHbnmGO6eyxl eZZ+voHvjwx7aN1JhJ05B/kILgbHsqX90EDWsg/9l6tYNwlJS70NJp7Z/dFqTkmBIaJVKufNWV5 WF7nK8IW4eYhjOgRYTBvGxhbPcRQ3D01eSTPNwCO6AlM9SMnr41VKzGZZ2pZefGPeWUHFYHg1in 3KJ/1aNQc6ixPHXH2Ubu5C4DXAFOFyDt694UqVojWY5l3V+OiJeewdaV2YhO0/di6ySXZtXYN9S YTcObmNvuwUhstCHrO/RXbq5MXEqO169GRy2Rui+QlElkxKNKjliKvZlYAfeNc9HDh X-Received: by 2002:a05:600c:8b84:b0:485:364e:9328 with SMTP id 5b1f17b1804b1-4889978c50bmr261015555e9.16.1775590168766; Tue, 07 Apr 2026 12:29:28 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4889cb46adcsm345076845e9.4.2026.04.07.12.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 12:29:28 -0700 (PDT) Date: Tue, 7 Apr 2026 20:29:27 +0100 From: David Laight To: Thorsten Blum Cc: Andrew Morton , Petr Mladek , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/vsprintf: use bool for local decode variable Message-ID: <20260407202927.24d757eb@pumpkin> In-Reply-To: <20260407181835.1053072-2-thorsten.blum@linux.dev> References: <20260407181835.1053072-2-thorsten.blum@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 7 Apr 2026 20:18:36 +0200 Thorsten Blum wrote: > The local variable 'decode' is only used as a boolean value - change its > data type from int to bool accordingly. Hopefully the compiler actually does: int decode = fmt[0]; and then compares against 'R' later on. But this change ought to make absolutely no difference to the code. David > > Signed-off-by: Thorsten Blum > --- > lib/vsprintf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 800b8ac49f53..9f359b31c8d1 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -1107,7 +1107,7 @@ char *resource_string(char *buf, char *end, struct resource *res, > 2*RSRC_BUF_SIZE + FLAG_BUF_SIZE + RAW_BUF_SIZE)]; > > char *p = sym, *pend = sym + sizeof(sym); > - int decode = (fmt[0] == 'R') ? 1 : 0; > + bool decode = fmt[0] == 'R'; > const struct printf_spec *specp; > > if (check_pointer(&buf, end, res, spec)) > @@ -1132,7 +1132,7 @@ char *resource_string(char *buf, char *end, struct resource *res, > } else { > p = string_nocheck(p, pend, "??? ", str_spec); > specp = &mem_spec; > - decode = 0; > + decode = false; > } > if (decode && res->flags & IORESOURCE_UNSET) { > p = string_nocheck(p, pend, "size ", str_spec); >