From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D94E351C0D for ; Wed, 8 Apr 2026 07:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775631683; cv=none; b=Th9+xypQPx5nHkvsF5yKH6RhVPv1285rAoEQ4XUPn76sWViPv2yeliIMn+Xvx3HcbN7hPD28A+w2SBjefB+JlolL7Bx7T6IV/jshMGzOkC1eD+Xy1JFmAQzomIv6QBUZNbPxHfmpVJkFfsg/HjE9ODbM8RJhSwgPhxnCKMw1n8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775631683; c=relaxed/simple; bh=edO3BFPXlea+cqJl8XCSCE52FEybAwQLAS/TDfDiH+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kyC+0FtkA9F20M8pAVY0CnXQVNqbOSCfZc7tAUPYgtx7h6NRpm3DEmV16rX7D+5BbpxsqcA7cRQp7znx+/C2mcdU/qeAtjOcJ1Gb8yCbqFOD7sP47vz3nhSZvC08BKPLvdrsK3nuU2hJi6+Dk+nWVYwoDPT9y98eGU5O1nw5FSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LP1JMrUW; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LP1JMrUW" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-8a4b8c3a30bso76765586d6.3 for ; Wed, 08 Apr 2026 00:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775631681; x=1776236481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KgVbyVFvTMOOobCmboEzJiSzpNTMaTKxGh/qViShvW8=; b=LP1JMrUW5lFqL5C6DxLDla6u4HAe6BzHhP3cZCj2JpxZz2yecROh/yh9vMdHeHrQ2q TO9nJdQzIkDOsGOUJx8cnjEhnglTiU0aFrW1Mi5idI5MAuJW3Xpub+zkzszTA6LOHENg 3HR77i5GO0wuVYVWJHHCVzuIn8IpSH/Ca9UdbN7Df/srFKx/TrLxxd43nR498OxlkQnS IQGSTF+N8uxnWTbgPRA3FtHiiVOxW+A1f+S+zgdJ3K/GUK1wBSHbesZdVpejbKwM9oXy BcPm4yICYFFViX9tEDPYCf6HBWpvWo7Iu6++BSWzWfi7OJD176Grm0tizK5kGsdof+WU ruUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775631681; x=1776236481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KgVbyVFvTMOOobCmboEzJiSzpNTMaTKxGh/qViShvW8=; b=OMp6xzCwG4mgsf61xZA/gsxb7zFz5NREyuIemDvHUYfzgFS+TOHhSA+wI/R4SifpmP IbE1oZO36Uf2DmUhB5YIEkhnr3gVZ6aco6NOnhlm4Uxuxc51ug9dOp+dyaX/84SyRKdL keSeT2H5Y9f/1IgDhFp6hkkviw68Nc3BWeVfRp3ccnMCVzt4mcb78ROzK321FibqHW90 S6mXPgi6//BVTB5iTDOwp6QOCQlg5EHZGwvsY/gc5y6nlCD0zj9p7cqEsfbiilk2z2WZ 173uygQ8IZiIwgShCAavpRLovU08ZUIJQUxny9yRjmk/vmIlFwHsqIilSTgG5066yoXA DgBQ== X-Forwarded-Encrypted: i=1; AJvYcCUOZDIEIzDss04pzV4uJ02/Dxiyb8A3HQ2VHHG4oaS3ZuOp1aZMxVqV0JQDhfvPyUFcJQBDAIDUfVbU94M=@vger.kernel.org X-Gm-Message-State: AOJu0YzejIw5PQcwMmXFkTjamt5spoDUg53k/11/oQ2BfHm+8IQDCZL2 2zRGrFVcpRSofoSt1PUUVWc0TFTZrS5chs1ytNCll5oM9a/w2/J9/MHO X-Gm-Gg: AeBDiesZdLH9NvPw8XKpML8AJS/UJUcxtNY/NKCgrfgN3mFiI/7Yzxt0c2cMmYV5pMs n3sn7GOh9kXynxBLnjHL8EDQxgv+DFgmWHm5KEuzXOpN8oBzW2WFw6YuP8uf4utpo/alQ35vgoK Q9UBQ0Ei2UMRfY580F8sIlHhnIXdB7RTIvczucml54FagXjwSYrKCTqgpi/3yWE21UJI1aZbpIo +tdyM+j15KLUe2aXayUlpfMx7EWhU4W7v7WQ5XFL7Z+M8MYImT1/1/RGWvZzDAvBlNKoKOj+xZb /JSRN+K7wxB/G3LQHWwcuoQAP6WF6F57K5xPL5ud4Kiw3m2VBZHwuM9uNadNFP5uPlhmKJLagsv 3qFmw64L1Kq8XvHfrq9Pjh40aATP9e2TR76RF9n2A+hGcVo+o3gUbDZwLjlXi7pm8diS2/AS5pt 3pHo4E7g4TIMfCfuzzDvEZ0m9Qx2l6zO34mcuaU0QHmuMvkiHZpboXZFkwG+qT+6ncSuTnISXl4 6G9o4hsLuvgkG91Okys2DHvSnM= X-Received: by 2002:a05:6214:c26:b0:8a6:d318:4909 with SMTP id 6a1803df08f44-8a7020bf953mr327652746d6.2.1775631681042; Wed, 08 Apr 2026 00:01:21 -0700 (PDT) Received: from workstation1 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8a596a0a522sm163454596d6.32.2026.04.08.00.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 00:01:20 -0700 (PDT) From: Michael Bommarito To: Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Bommarito , stable@vger.kernel.org Subject: [PATCH v3] um: drivers: call kernel_strrchr() explicitly in cow_user.c Date: Wed, 8 Apr 2026 03:01:02 -0400 Message-ID: <20260408070102.2325572-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407164435.726012-1-michael.bommarito@gmail.com> References: <20260407164435.726012-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Building ARCH=um on glibc >= 2.43 fails: arch/um/drivers/cow_user.c: error: implicit declaration of function 'strrchr' [-Wimplicit-function-declaration] glibc 2.43's C23 const-preserving strrchr() macro does not survive UML's global -Dstrrchr=kernel_strrchr remap from arch/um/Makefile. Call kernel_strrchr() directly in cow_user.c so the source no longer depends on the -D rewrite. Fixes: 2c51a4bc0233 ("um: fix strrchr() problems") Suggested-by: Johannes Berg Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-6 Assisted-by: Codex:gpt-5-4 Signed-off-by: Michael Bommarito --- v2: https://lore.kernel.org/all/20260407181528.879358-1-michael.bommarito@gmail.com/ Changes since v2: trim commit message per review. arch/um/drivers/cow_user.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c index 29b46581ddd1..ec8e6121b402 100644 --- a/arch/um/drivers/cow_user.c +++ b/arch/um/drivers/cow_user.c @@ -15,6 +15,12 @@ #include "cow.h" #include "cow_sys.h" +/* + * arch/um/Makefile remaps strrchr to kernel_strrchr; call the kernel + * name directly to avoid glibc >= 2.43's C23 strrchr macro. + */ +extern char *kernel_strrchr(const char *, int); + #define PATH_LEN_V1 256 /* unsigned time_t works until year 2106 */ @@ -153,7 +159,7 @@ static int absolutize(char *to, int size, char *from) errno); return -1; } - slash = strrchr(from, '/'); + slash = kernel_strrchr(from, '/'); if (slash != NULL) { *slash = '\0'; if (chdir(from)) { -- 2.49.0