From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB65382F12; Wed, 8 Apr 2026 07:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633514; cv=none; b=ScdahO5DohzMbm4GJ4Rmp0DDdRX2EpPIXMvomWJ1N59fdlcJITjkLRS6QZe6IIN4vYQsmxtAVBD8lt/Uu+0QesbMQ3iko3LWrEwSXO+zk5P0uLZI35ef5Ad6v3igTDnj0ufLu+ps0inu2PNfOyPNPS+lBGgFh5gIfPRmRcpLaCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633514; c=relaxed/simple; bh=vWCNuhUoewsighVgd5hZe21pawPiAvd2Jv9BdMisxM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QBZY2HeHMwfFafLqaJegISx5lQDMEIMiXuixd8679rUBOPbu7G96zDW3U1DKQyyl3KlQeIbQCboDwD3ELSQle+tF8k4+5PyDdviyM/d4QYka4uT1Gq1E+7pKItIZNA+Vn8BBCsnrqHoQWrYnQ1wPVLGmK+JbqzX1LF4whvRj9L8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UXBekdhm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UXBekdhm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6084DC19424; Wed, 8 Apr 2026 07:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775633514; bh=vWCNuhUoewsighVgd5hZe21pawPiAvd2Jv9BdMisxM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UXBekdhmLgxImwxlX6K6nA3wZrUX9vr/IOGY+KIF5WJGjCneb8ydzkq/9+uLxwQOh 86W/Z4LqDIgMc5pV86gxHMyLy+QtmvSzaHyvnId7jDTT++7fx8YzBKfDUafLjy0GW/ YhNFUrFk/TfR87viRqkiS5D2YTQlyUeNxuO7/lRdIY0y3z12/8MmBw6UmjL3Mi1CCe QfGxw6yQuXoPQlskJIY7gEXJT9TJBluQeAQRuMlqVuqJjxu62ma2JuvGDwZpdwFjt8 cdlgNer9VvdaJpmmwCJ3uKyPolITXGk6KycoOuIweHtiiAxHVMYdghDhkDInPLLXT5 xyA9SpmKjR35g== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wANOC-000000001Ml-06PW; Wed, 08 Apr 2026 09:31:52 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Marek Vasut , Bartosz Golaszewski , Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Douglas Anderson , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Wenyou Yang Subject: [PATCH v2 6/7] regulator: act8945a: fix OF node reference imbalance Date: Wed, 8 Apr 2026 09:30:54 +0200 Message-ID: <20260408073055.5183-7-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260408073055.5183-1-johan@kernel.org> References: <20260408073055.5183-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: 38c09961048b ("regulator: act8945a: add regulator driver for ACT8945A") Cc: stable@vger.kernel.org # 4.6 Cc: Wenyou Yang Signed-off-by: Johan Hovold --- drivers/regulator/act8945a-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c index 24cbdd833863..5bbe2bce740e 100644 --- a/drivers/regulator/act8945a-regulator.c +++ b/drivers/regulator/act8945a-regulator.c @@ -302,8 +302,9 @@ static int act8945a_pmic_probe(struct platform_device *pdev) num_regulators = ARRAY_SIZE(act8945a_regulators); } + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + config.dev = &pdev->dev; - config.dev->of_node = pdev->dev.parent->of_node; config.driver_data = act8945a; for (i = 0; i < num_regulators; i++) { rdev = devm_regulator_register(&pdev->dev, ®ulators[i], -- 2.52.0