From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4C5383C69; Wed, 8 Apr 2026 07:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633514; cv=none; b=BQbuQEeJRmX6jfgFsSXTP15//ijql/6GLzKnQvJeZHN6Avla6sdw9Jb8j0C/wN1VMZ4OUsnp70PYviwlrBNH4wS4mGsqkR+UHCzl0y9HSRcARB3yF0661ddDv8sDrzP7IfXwF4ly93vzxBO1QrDdO3WAPykWIvs1w76XoQgtwQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633514; c=relaxed/simple; bh=9gM2k/aOqDg3x+DNA75R0DRTcMQqkKPvr6drbsDSsPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mTN/qJFGT+CW4+uSmIbLZ5KfhvPjRzDRk+ivXNM8Rwiwt4YQ9iXwd0DZhaKrZo4LX6yhvVG8lrP9vBMTM98NpyEbYbznq71CMDVmUkzZsW2iEok/suksjw8cevKzpd8Dk2K5lVBFLMdXVLAk5Qxmrm1aqWr3n5nyHurRmEw6dK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fpVtxP6e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fpVtxP6e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6658CC4AF0C; Wed, 8 Apr 2026 07:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775633514; bh=9gM2k/aOqDg3x+DNA75R0DRTcMQqkKPvr6drbsDSsPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fpVtxP6eF/nO7enjxFGimIjmbS1lsPUv8ZyHA80tTsk9Zbb9314Kuuv0UyRazBTNd +awhVjl5vPogYKFy4bWlgtgLAw9Ndi+Rmrmsfts4XUEWZLDLHffh+f518V7ISyd3vC 6XyLM9JN75KsCD2JORqBngvbyQTCF7rxuHmk0OqFVsTWO/erlcDAYHYJit8N9DAYS3 NQo4od7gZFedDPQcM1uB7vQw7hcUj/HIHMY8mvy/LiK4OwsVNwRUekrYrSSdpIYLEY WPvtpgMuXHVnRdSb+dPPMmsFLXp2bc1cQ03VBi8cNIejtU02KDJqUcAAOhfmLLmICA KZEz2XypW8MWw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wANOC-000000001Mn-09pM; Wed, 08 Apr 2026 09:31:52 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Marek Vasut , Bartosz Golaszewski , Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Douglas Anderson , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Marek Vasut Subject: [PATCH v2 7/7] regulator: bd9571mwv: fix OF node reference imbalance Date: Wed, 8 Apr 2026 09:30:55 +0200 Message-ID: <20260408073055.5183-8-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260408073055.5183-1-johan@kernel.org> References: <20260408073055.5183-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: e85c5a153fe2 ("regulator: Add ROHM BD9571MWV-M PMIC regulator driver") Cc: stable@vger.kernel.org # 4.12 Cc: Marek Vasut Signed-off-by: Johan Hovold --- drivers/regulator/bd9571mwv-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c index 209beabb5c37..f4de24a281b1 100644 --- a/drivers/regulator/bd9571mwv-regulator.c +++ b/drivers/regulator/bd9571mwv-regulator.c @@ -287,8 +287,9 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev) platform_set_drvdata(pdev, bdreg); + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + config.dev = &pdev->dev; - config.dev->of_node = pdev->dev.parent->of_node; config.driver_data = bdreg; config.regmap = bdreg->regmap; -- 2.52.0