[PATCH] spi: pl022: enable compile testing

[PATCH] spi: pl022: enable compile testing

[Johan Hovold]

There seems to be nothing preventing this driver from being compile
tested so enable that for wider build coverage.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index c3b2f02f5912..ddd53cb48567 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -866,7 +866,7 @@ config SPI_PIC32_SQI
 
 config SPI_PL022
 	tristate "ARM AMBA PL022 SSP controller"
-	depends on ARM_AMBA
+	depends on ARM_AMBA || COMPILE_TEST
 	default y if ARCH_REALVIEW
 	default y if INTEGRATOR_IMPD1
 	default y if ARCH_VERSATILE
-- 
2.52.0

Re: [PATCH] spi: pl022: enable compile testing

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Wed, Apr 08, 2026 at 10:44:07AM +0200, Johan Hovold wrote:
> There seems to be nothing preventing this driver from being compile
> tested so enable that for wider build coverage.

$ grep amba drivers/spi/spi-pl022.c 
#include <linux/amba/bus.h>
#include <linux/amba/pl022.h>
	struct amba_device		*adev;
static int pl022_probe(struct amba_device *adev, const struct amba_id *id)
	status = amba_request_regions(adev, NULL);
	amba_set_drvdata(adev, pl022);
	amba_release_regions(adev);
pl022_remove(struct amba_device *adev)
	struct pl022 *pl022 = amba_get_drvdata(adev);
	amba_release_regions(adev);
static const struct amba_id pl022_ids[] = {
MODULE_DEVICE_TABLE(amba, pl022_ids);
static struct amba_driver pl022_driver = {
	return amba_driver_register(&pl022_driver);
	amba_driver_unregister(&pl022_driver);

At least amba_request_regions() and amba_release_regions() don't appear
to have stubs for !AMBA?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: pl022: enable compile testing

[Johan Hovold]

[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]

On Wed, Apr 08, 2026 at 12:47:41PM +0100, Mark Brown wrote:
> On Wed, Apr 08, 2026 at 10:44:07AM +0200, Johan Hovold wrote:
> > There seems to be nothing preventing this driver from being compile
> > tested so enable that for wider build coverage.
> 
> $ grep amba drivers/spi/spi-pl022.c 
> #include <linux/amba/bus.h>
> #include <linux/amba/pl022.h>
> 	struct amba_device		*adev;
> static int pl022_probe(struct amba_device *adev, const struct amba_id *id)
> 	status = amba_request_regions(adev, NULL);
> 	amba_set_drvdata(adev, pl022);
> 	amba_release_regions(adev);
> pl022_remove(struct amba_device *adev)
> 	struct pl022 *pl022 = amba_get_drvdata(adev);
> 	amba_release_regions(adev);
> static const struct amba_id pl022_ids[] = {
> MODULE_DEVICE_TABLE(amba, pl022_ids);
> static struct amba_driver pl022_driver = {
> 	return amba_driver_register(&pl022_driver);
> 	amba_driver_unregister(&pl022_driver);
> 
> At least amba_request_regions() and amba_release_regions() don't appear
> to have stubs for !AMBA?

Hmm, it builds here on x86 with gcc (15) both as a module and as
built-in.

It seems the probe function is discarded before linking as the amba
driver struct is never used on !AMBA. It definitely compiles.

$ nm /tmp/kbuild/nu/drivers/spi/spi-pl022.o
0000000000000000 d __exitcall_pl022_exit
0000000000000000 r __initcall__kmod_spi_pl022__527_2185_pl022_init4
0000000000000000 r __mod_device_table__kmod_spi_pl022__amba__pl022_ids
0000000000000000 t pl022_exit
0000000000000000 r pl022_ids
0000000000000000 t pl022_init
                 U __SCK__WARN_trap
0000000000000000 d __UNIQUE_ID_addressable_pl022_init_528
0000000000000008 d __UNIQUE_ID_addressable___SCK__WARN_trap_496.15
000000000000006d r __UNIQUE_ID_modinfo_529
000000000000003b r __UNIQUE_ID_modinfo_530
0000000000000016 r __UNIQUE_ID_modinfo_531
0000000000000000 r __UNIQUE_ID_modinfo_532
0000000000000030 d vendor_arm
0000000000000000 d vendor_lsi
0000000000000020 d vendor_st
0000000000000010 d vendor_st_pl023

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]