From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E196378D98 for ; Wed, 8 Apr 2026 09:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775640956; cv=none; b=oDkszsTVEDKFCYIt0QYJwsoueGEKYVN9gwbUji88V/vIxTwD4mgq8gTmywpPCtvpuM7DgH3LuAu0MyUgcjJRCpbNBhcWjr7L2VPj/EpeCiKcjgc/PqfnkzjB6/JoK29dzwGPI2cIXphcXgZLJkllWZZ94eISdIPlUKSQdnma5LE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775640956; c=relaxed/simple; bh=GchzE1VoV0S3OvcYPkFuFVIj47Oxn3UfFkEtJyWBlKU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TjZbFEwerLT7LdC3LN9xCKNAef3jAaaFK9l75ZwrEOjigBnUjEC8o3KY0CMJ8WOHXb79aHWTMjLUuwZu4DO2iWKKqy6Tu39Wgy/NSAnKp6DuzSglHCtUs/lrDXwDSyvtxgR/S463jjeWHzpR8uSof6kSjK8MY6HQcRLhclk3b5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=VJyeBeG/; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="VJyeBeG/" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775640951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KF+ygKPysPZEijop9aZpkM2S8G/o+N1c3ydLA/xl4hU=; b=VJyeBeG/o3ABOAAOFKj2J05D8RehmzpjrGtOy6/U0W9jkcNrLPOk8vgGXR2EsxoCsDjDGm OOilFkbYXvSsAn/BMUnOXXKwbL2yTN2L6zJyuAl51/nVYTeOxjcELa2OBOZt8h0sDbpBoA g6bpg8/5t6ZLsy2MuLAYOQD700jChjU= From: Ye Liu To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes Cc: Ye Liu , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/khugepaged: use round_{up,down}() for PMD alignment in madvise_collapse() Date: Wed, 8 Apr 2026 17:35:33 +0800 Message-ID: <20260408093534.2373007-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Ye Liu The PMD alignment in madvise_collapse() is currently implemented using open-coded bitmask operations: (start + ~HPAGE_PMD_MASK) & HPAGE_PMD_MASK end & HPAGE_PMD_MASK Replace them with round_up() and round_down(), which express the same alignment semantics more directly and match other PMD-alignment code paths in khugepaged. No functional change intended. Signed-off-by: Ye Liu --- mm/khugepaged.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 1e2bff40d014..80d0b7136b58 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2835,8 +2835,8 @@ int madvise_collapse(struct vm_area_struct *vma, unsigned long start, mmgrab(mm); lru_add_drain_all(); - hstart = (start + ~HPAGE_PMD_MASK) & HPAGE_PMD_MASK; - hend = end & HPAGE_PMD_MASK; + hstart = round_up(start, HPAGE_PMD_SIZE); + hend = round_down(end, HPAGE_PMD_SIZE); for (addr = hstart; addr < hend; addr += HPAGE_PMD_SIZE) { enum scan_result result = SCAN_FAIL; -- 2.43.0