From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F1C3B47FC for ; Wed, 8 Apr 2026 11:28:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775647703; cv=none; b=WnsmsVPZnNupS6h3r+sDWEQKLixPRvhqM5ym8W6jusQmRBloW2gBHp0T0ekzWkFg724tMmYDn6jneCw8eyC9tDcjmxKoW5sOsbfE5OCJBX+sXBi6ujy/Zx+DD/g7uti3jPIGG7NO4fBcCa+Zlo1L91SukKJCzeto918JdaVocrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775647703; c=relaxed/simple; bh=0F44SAnebl+8gDmCL1eC0MPRr12pzPk07RWa11swu+E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FNkn5b78CZFBzbv8ji2lFnWzSFmoh2vywUatZciqY0z00QSBi0WnwhY88NY+IXolFhjElFF3l3TyXS5m6owhzft2X7+3HaxtXRv2CFDkAWongOc5dzHnU/Wg22fVMYoUFq7a3vX6ffKd5VccEJ7yJDOACWrKnTi/awoBeRh4Nyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pYNIKswi; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pYNIKswi" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso48699725e9.3 for ; Wed, 08 Apr 2026 04:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775647700; x=1776252500; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SLFWH+izSAtpskZPsHkGI7pPafV8We6hSzH9Fp0U3iI=; b=pYNIKswi0QevS0jfUqCYSnCYh/DU0Dhj7vgQY9QxJG4Wy6rvcL1+ySZSBYKrnVuMQj nwfy9EH9wEwCv3tdUNH/KBaNN7pRU0i9GBxC4Im9tFkeL4t4MRoVc4771zLCVk1wlwS3 pyR20uce0eNC7H83LRsJdje7Cm3Ar0ZOsqcwSt6XEzyUbwiKQAAJu9w4Syoj00p9Gii0 8puo7lzfzONCIfk+jqwIKEkDMngfHL1c00N2w0pgcpbLFA0vMAz/tMMP0Vf1q9AaZgl7 588TVRjMYRUGzIBH+5prHBCIypcnYqKy+Ir1NP8YpIJBMdkbk2L1oPDb0cZZWPnka9Cc Mugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775647700; x=1776252500; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SLFWH+izSAtpskZPsHkGI7pPafV8We6hSzH9Fp0U3iI=; b=Xn6ksSZrRKswLawUnR0tet4ZUOLjVsO6WzFk2sjajHTz/eCsZLeG71lYy0mCf0w0Hr aIaeUluY2mFjf6ZyjXDDPZz053y9V3PkgG6ffWjDbqQQc6ePhZGH/UW4B3T3WwXrwu1V VQpwY4WTteAO7Kn3lGsCR5ytAhvkKlxUNbpzN2HQ7x25tTPAsEz9/eJGruL7enXVSYuw 9Pk5cPEYxI49rlEljMCGDMHG8Wc3i5cgnaTgzglMWlIunXsg3nfkJgE/gzR6YINzcbaR mL0eudem2NFp/QtcY/Z27mWlkGceHMgiComT1AL9diy8lX0CjxXSL+FGf7R9O7A10Xop GTSQ== X-Forwarded-Encrypted: i=1; AJvYcCUkZaB70xcmZL7dDwwuocjnsSep3HBkj2PTuWC8vWPvpsbwuL0xGiyAS2OQaZOJOwJQf+2pvSYuMJzK7Mk=@vger.kernel.org X-Gm-Message-State: AOJu0YyA8ObK77GcQLbQun5p3T2I0RrBf8KWtJhd/zF5TPh78mwIRItt 2L47EoOtEInfyWZsWgPzQI1lXG6TSTO/zf5XOOfcBCKPU37D2HldWPX/ X-Gm-Gg: AeBDieuZkh8yKyoJHJRflSOlD39Dh4N6nlaojdN9x+5jEdTKVbOHN9YQFEpFVBMH9ev e6m/sL9Yhf5hZjSLcEKXmG8ywsrEZia9xnaLlTenpJkb08C8+h6Vtvm9qjxfcU3hR4l+N0VANw6 IxbMsbeUBB/I69UAvkQHPBUbFK1+hiinz89VhsB8JNxiWBBmXZLPoLH7OUKNO6QOtGeAVhNsFcC Kpc0OLmqhH6zrAmW1kfZj9utrl3Sh/SMUfY0sGfZ7QLBCP8dqcdZ8jr3glNgGsWkfImye+VxMDt Mk3cjrudpQmzcPCHXIISJ4RVUbnO+jdSfD5Z8BhCSFB+74gbbTmNQvNeUYf77l7BaLOjB4gQIoL vgMsoyh8Yl+o/MIqaAuWWLJXBaYTTjKVUHx1s4acfmt1+llgmD4nnjtWvOKYmZ+Omkf3U0EKSBZ rer2YZUOAsFYLJRMPc65nXRpk4kLsCq2FwekhbCV7YaWgxlBxcbK634LTOsb6etTQ= X-Received: by 2002:a05:600c:2d91:b0:488:a2ac:a334 with SMTP id 5b1f17b1804b1-488a2aca406mr127841495e9.3.1775647700406; Wed, 08 Apr 2026 04:28:20 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:d997:3078:a4d3:4f51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4889f6843dfsm424444185e9.12.2026.04.08.04.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 04:28:19 -0700 (PDT) From: Gabriel Rondon To: Greg Kroah-Hartman Cc: Christian Gromm , Parthiban Veerasooran , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: most: video: replace BUG_ON() with pr_warn() in comp_exit() Date: Wed, 8 Apr 2026 12:28:18 +0100 Message-Id: <20260408112818.95174-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace BUG_ON(!list_empty(&video_devices)) with an explicit check and pr_warn() in the module exit function. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). WARN_ON() is also inappropriate here since it crashes the system when panic-on-warn is enabled. Use pr_warn() to log the unexpected condition without any risk of crashing. This is the last remaining BUG_ON() in the staging/most subsystem, following the dim2 series that replaced five BUG_ON() calls. Signed-off-by: Gabriel Rondon --- Changes since v1: - Use pr_warn() instead of WARN_ON() to avoid crash with panic-on-warn (Greg Kroah-Hartman) drivers/staging/most/video/video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 04351f8ccccf..c5425c207552 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -577,7 +577,8 @@ static void __exit comp_exit(void) most_deregister_configfs_subsys(&comp); most_deregister_component(&comp); - BUG_ON(!list_empty(&video_devices)); + if (!list_empty(&video_devices)) + pr_warn("video_devices list not empty on exit\n"); } module_init(comp_init); -- 2.33.0