From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53BA133A717 for ; Wed, 8 Apr 2026 13:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655787; cv=none; b=Q7s704Frc3hddyjJCJXJeR92fcHHZhI1lij/nUoREJkyJ7lqb15fuaS8TqXnkhhw3XH+bkgSZLgwHY3/YCojuwlkKpyN1gcWOXKwFl98U20MHBoXQPWze/6J3N0alJ07oRvMDDiy8gGwwhsZJCSSIAwycqVJlvouZ93BZ2/7FcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655787; c=relaxed/simple; bh=Ip/ecwNubDqLmJMleabmXHAK/8+ZPzST0M2Luh3yUIw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=XKcpAJVo/ET6F3IF3CNCQ5cKljz1NLJT0AdDcgXWRpo0kzYwA0xd9+sPhIDYbWK7pyy7tWRYKSaCpxWaRwPzcPscZgTb+k7Mq0f7AUQ8nJRUe9APXpfkV+b+SN7DDrKmsKUlL4g3IwVXPKsvUIK/PLucaL4jLgk4BB/LnnyFM1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eGxaFk/e; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eGxaFk/e" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-482f454be5bso11115965e9.0 for ; Wed, 08 Apr 2026 06:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775655785; x=1776260585; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qfX6vEPgTKMdUYQyvcdtf1D9EG80EL+3vKPp1rPUYPg=; b=eGxaFk/eyL/BChRfo9uyevKDDIXNUdUV+A8TKzwuTA785aN5l1tXGxvmzjIri/yRmw rsXrY25IPB962lASe906bpa+ybBYTjxUGm/u9/UGIRnX4B8pk/UQSWayXV0tkjsqnqTN g7IK99hTitWDpI0BF6IOxpeQdUp0cdmQopL/PNfn1cJLCZ9WjXSU5BlyE82uLcrI/fOr VuciZ8aVy5JKaaSYxl94UX6jGHRTUA6EBli3zU75isik/IKxmvsP76Q9s1KTgkrbNMlH xBJ+1vlQfvDEU66ZrJLESYj3dI6Flb66703B7NRa0WcVLrG/U9v64B2h30Q+DKtIDtSZ Vnpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775655785; x=1776260585; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qfX6vEPgTKMdUYQyvcdtf1D9EG80EL+3vKPp1rPUYPg=; b=fFwWIKVIkR9/K2X5Qctfpo3+UBWc8hecCOJEC859hk4bxeWA/w+KmTs4Pj36A17jf0 d1Z9DSUwjHLN7uMTFAKmBOvO+TIfP83gtiDo/lDFm2lJURk/aMUT8LJLqZHiyOhKAH9q muckuzATTwxeEnov0l9D+wQalUlSRM6Qx79WXJGMIxMf7A+nsW+49mCw5+OzfIfKxEPo Dslp2tMwYBELa6AV3b6GmwFC2Rz4Om9AUQQKFcZrm+guBR3HcYknVHg/KiVHQQJvMnWv Fugk2BEXZWJOEh0557D+p/Yl+wE297ojiqS6YqqX4wsipdd2tc44Q9Cf/xfdaWqD0XmG 1tWA== X-Forwarded-Encrypted: i=1; AJvYcCWLKxM1t+Kvmnmd+pzzunGJ3FOQIGIBiwtJbzqaD7Hqr8WJ1JcLDK8nw2ohsX+95/H7gXIydUxHpZxiOek=@vger.kernel.org X-Gm-Message-State: AOJu0YyDElqWvb4AXyld/FT5eIXH+mb4PY+TVj0fX5/7vdoyuFbtyxUs ciMp5cFkWYbjNwe3fMZeHPIDukGpEbCY5/uAcbfnknwhITfJzpmgoW47zawR3xMA7e7MIA== X-Gm-Gg: AeBDieuiwsbfk3AIroR0/iaJj8XJC3sZrRiw2qAWea04UI53BiUnX1eXMk7Zaq5CpeY BLc1xiazKkTIn3I55WnZY9p2V2yfbcnwoGOohfATV80V1eFdTTEBMBgMSd64gSM1zdM94T7OSfF tnZNG8IdB3GBzBUZnUvjyK4wQJ8lFNww1iLPQC6unpy//fkzW7NHPcrPNnTmi54yR5TmhXDtaSE JC3Jebmnu3A2olDPvmC23M8cn8znAuGlh4zYxAapuFZOkvpMxdEMy7hkRIUQ35g1qXYNdqaCHGP 2j9Ke6m0pSEeDNxhYM5tIEfOctVxCOgej9KprHtvL9at6G6qo3dfEVnvYruTD+wfnAVv/ugqqWO NsUFLgHQACU7Si/xfdzq3usJOpBZ7doryNqCu6OQcuzVmbPxZ+OOTo2UHBmxoB3iteul2HhbSyg wh8Zgm9TZ3DROIZc3uE+JKxtGh42vpKRz+ngUjQCv9v/qzrgG9ehtc X-Received: by 2002:a05:600c:4f87:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-488994a77b1mr268030125e9.12.1775655784526; Wed, 08 Apr 2026 06:43:04 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:d997:3078:a4d3:4f51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e80a616sm1191538485e9.2.2026.04.08.06.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 06:43:03 -0700 (PDT) From: Gabriel Rondon To: Greg Kroah-Hartman Cc: Christian Gromm , Parthiban Veerasooran , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: most: video: replace BUG_ON() with pr_warn() in comp_exit() Date: Wed, 8 Apr 2026 14:43:01 +0100 Message-Id: <20260408134301.78474-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <2026040838-washbowl-handbrake-ae03@gregkh> References: <2026040838-washbowl-handbrake-ae03@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Wed, Apr 08, 2026 at 01:51:59PM +0200, Greg Kroah-Hartman wrote: > How can this ever happen? Why not fix that to ensure it can never > happen, and then this check can just be removed entirely? Thanks for the review, Greg. I looked at most_deregister_component() in core.c — it already calls disconnect_channel() for every linked channel via bus_for_each_dev(). So the manual cleanup loop in comp_exit() and the comment saying "mostcore currently doesn't call disconnect_channel()" are outdated. For v3 I plan to remove the manual cleanup loop, the stale comment, and the BUG_ON entirely — leaving comp_exit() to just call most_deregister_configfs_subsys() and most_deregister_component(), which already handles the full teardown. Does that match what you had in mind? Gabriel