* [PATCH 2/2] Input: qt1070 - inline i2c_check_functionality check
[not found] <20260408141926.1181389-3-thorsten.blum@linux.dev>
@ 2026-04-08 14:19 ` Thorsten Blum
2026-04-08 14:47 ` [PATCH 1/2] Input: qt1050 " Dmitry Torokhov
1 sibling, 0 replies; 2+ messages in thread
From: Thorsten Blum @ 2026-04-08 14:19 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Thorsten Blum, linux-input, linux-kernel
Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/input/keyboard/qt1070.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
index b3db2c7d0957..b255b997e279 100644
--- a/drivers/input/keyboard/qt1070.c
+++ b/drivers/input/keyboard/qt1070.c
@@ -133,8 +133,7 @@ static int qt1070_probe(struct i2c_client *client)
int i;
int err;
- err = i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE);
- if (!err) {
+ if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE)) {
dev_err(&client->dev, "%s adapter not supported\n",
dev_driver_string(&client->adapter->dev));
return -ENODEV;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Input: qt1050 - inline i2c_check_functionality check
[not found] <20260408141926.1181389-3-thorsten.blum@linux.dev>
2026-04-08 14:19 ` [PATCH 2/2] Input: qt1070 - inline i2c_check_functionality check Thorsten Blum
@ 2026-04-08 14:47 ` Dmitry Torokhov
1 sibling, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-04-08 14:47 UTC (permalink / raw)
To: Thorsten Blum; +Cc: linux-input, linux-kernel
On Wed, Apr 08, 2026 at 04:19:25PM +0200, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied both, thank you.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-08 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260408141926.1181389-3-thorsten.blum@linux.dev>
2026-04-08 14:19 ` [PATCH 2/2] Input: qt1070 - inline i2c_check_functionality check Thorsten Blum
2026-04-08 14:47 ` [PATCH 1/2] Input: qt1050 " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox