From: Cao Ruichuang <create0818@163.com>
To: rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: [PATCH 1/2] tracing: Store trace_marker_raw payload length in events
Date: Wed, 8 Apr 2026 23:32:40 +0800 [thread overview]
Message-ID: <20260408153241.15391-1-create0818@163.com> (raw)
trace_marker_raw currently records its bytes in TRACE_RAW_DATA events,
but the event output path derives the byte count from the padded record
size in the ring buffer. As a result, the printed raw-data payload is
rounded up and small writes do not preserve their true length.
Keep the true payload length in the TRACE_RAW_DATA event itself and use
that field when printing the bytes. This leaves the ring buffer record
size semantics unchanged while letting trace_marker_raw report the exact
payload that was written.
Signed-off-by: Cao Ruichuang <create0818@163.com>
---
kernel/trace/trace.c | 11 ++++++-----
kernel/trace/trace_entries.h | 1 +
kernel/trace/trace_output.c | 4 ++--
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a626211ce..d9cb643b8 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -6906,11 +6906,13 @@ static ssize_t write_raw_marker_to_buffer(struct trace_array *tr,
struct ring_buffer_event *event;
struct trace_buffer *buffer;
struct raw_data_entry *entry;
+ size_t payload_len;
ssize_t written;
size_t size;
/* cnt includes both the entry->id and the data behind it. */
- size = struct_offset(entry, id) + cnt;
+ payload_len = cnt - sizeof(entry->id);
+ size = struct_offset(entry, buf) + payload_len;
buffer = tr->array_buffer.buffer;
@@ -6924,10 +6926,9 @@ static ssize_t write_raw_marker_to_buffer(struct trace_array *tr,
return -EBADF;
entry = ring_buffer_event_data(event);
- unsafe_memcpy(&entry->id, buf, cnt,
- "id and content already reserved on ring buffer"
- "'buf' includes the 'id' and the data."
- "'entry' was allocated with cnt from 'id'.");
+ memcpy(&entry->id, buf, sizeof(entry->id));
+ entry->len = payload_len;
+ memcpy(entry->buf, buf + sizeof(entry->id), payload_len);
written = cnt;
__buffer_unlock_commit(buffer, event);
diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h
index 54417468f..5f867a144 100644
--- a/kernel/trace/trace_entries.h
+++ b/kernel/trace/trace_entries.h
@@ -288,6 +288,7 @@ FTRACE_ENTRY(raw_data, raw_data_entry,
F_STRUCT(
__field( unsigned int, id )
+ __field(unsigned int, len)
__dynamic_array( char, buf )
),
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 1996d7aba..4e1edfa05 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -1817,13 +1817,13 @@ static enum print_line_t trace_raw_data(struct trace_iterator *iter, int flags,
struct trace_event *event)
{
struct raw_data_entry *field;
- int i;
+ unsigned int i;
trace_assign_type(field, iter->ent);
trace_seq_printf(&iter->seq, "# %x buf:", field->id);
- for (i = 0; i < iter->ent_size - offsetof(struct raw_data_entry, buf); i++)
+ for (i = 0; i < field->len; i++)
trace_seq_printf(&iter->seq, " %02x",
(unsigned char)field->buf[i]);
--
2.39.5 (Apple Git-154)
next reply other threads:[~2026-04-08 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:32 Cao Ruichuang [this message]
2026-04-08 15:32 ` [PATCH 2/2] selftests/ftrace: Check exact trace_marker_raw payload lengths Cao Ruichuang
2026-04-08 17:39 ` [PATCH 1/2] tracing: Store trace_marker_raw payload length in events Steven Rostedt
2026-04-09 5:12 ` Cao Ruichuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408153241.15391-1-create0818@163.com \
--to=create0818@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox