From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A03BB34C83C for ; Wed, 8 Apr 2026 16:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775664885; cv=none; b=M2MrPaIxO7Wo4bWRd351O1VWCe/Xd8ZBNcFtb8ovtBOCM7ZyzuHSLVlygg+u909rYLxA5k5798XxvrPtshXg6FSmaCGaTKj+tQOVBGo0BXlaGL++2BrOzLMQVaKcH+AsvDPaxOCGGGckYl19y12yqyQXB4T01RQJ2bBRN7oS1OQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775664885; c=relaxed/simple; bh=HE0L2TlxZki+exNOI5hLEfBmSPglXZVfQqXoDdp0Cow=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YAOzdwfTon6Qkb+E9rcGx/CX3BVU1lWLar2yIovuNBdMSwumJBwfCYiMMXnGeVCe/mrS4NeJoUN4DIV57WZKXEezY5Bxra1VmOTnXF1cVjFMyEY9dcUmR4wHH1U9SGsvM0Lqg7dt4Ya8SUC/kAA4/xLtLBITPr70uBcyl06BrCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MALP3S+N; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MALP3S+N" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8296d553142so3304274b3a.3 for ; Wed, 08 Apr 2026 09:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775664884; x=1776269684; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7YPjAZrC/fQAxlJwQXqKMryLnvq1TdnW5Tuxqia5KaU=; b=MALP3S+NPtmhHfBLK6YKNYPEopxgDOrEcufiRqADJRHPwWDNlknSoHehTKOtQQ/qUH eKLzDhAnD5O3gxfpnp5rEaHET9ibKhjKfe+QYwWWfKGtanFu8pKZgQ25yo69SDuGuTMM s986dYV4FCtiYf4SpbxQ1iVoqtjUNsyOP7lSUbXSZqkK2ghXaK8FLx+B5h/L+E1OGoOF jDQbcJ1gUM6+TIUBycr5sZhco6pLfm6MFTjNyIVjFWVFclzDX5GakRfbYYAl4gdJVkgZ HOBA3CavKQO8a+ESE0GEKrdljA8TOZZaYIX3f6MvDwd9wN6d0cZs1+mxkD+Ew3fPyetR bTVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775664884; x=1776269684; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7YPjAZrC/fQAxlJwQXqKMryLnvq1TdnW5Tuxqia5KaU=; b=WGMg5qP5xd+aeUmsCMYhw5HXQicQIlw5LyOrZUxRbgB4Tp956tb2RskKNLS3xrgWwJ ygexhfA+Q+4b8So8Nc5yxtKQFvv+I/1SBhJ3gvePTBVIhlqaMLyatOZNmGe0vO7KfgcE /+YEuaDWsVgOLXTnS1c8OGLqne2k5OqU9Q2NOzeJnntp1driw8MBgodK96QwK3TvHsIF ktW+zNvbYmeHbo10wkRZ4COAT1mQtM66Wbgik6Bla2esjr8sapaChn/3FAKDKCxvcxJv zOK9HEsJdAovOsxMh6uxJcTFc7G+fK3iLLBv9d25KFus089y2tD+6lviiuShlWNl36yb ZI6A== X-Forwarded-Encrypted: i=1; AJvYcCUSd2Z9HpwMLovjFkLnq2atGlrFnwu+CEm8IJkMOHayWMXi+GKyJ0bWwQUZqxPHhkPyniAivz/h1vNj0N8=@vger.kernel.org X-Gm-Message-State: AOJu0YyMLK1fZKduwSM2R+T+wM12bMgWV+E/+uCZk6XSujwcdCm/mTsT rM5zVeu0QXo0zDHge6tAbphBRDXTElfO7J9HXMUmGcxpjWteS4PeDYu1 X-Gm-Gg: AeBDievN8x2MYOLFD89vK3pUYfj5yKSo6qhVx4Z8psatXKeFvLunS1BiNcSLMVNeo9z Jl6LXJCYFbzPQFH07OFPpy9fqGUXw5Q25mHHpe/9+clYMJmrdOpSXcyieSCaN0z3VKAmW0b6cST HrAl3JbsilrkhZ8bP3NLcVFlW2P2KWO4A6l06YLzh3lYk2OOalJbpnNqdaCViGxUur5sf8Qrwod XuCJrHLaT1KsB7E6dWbXEOmtFuH+b19T7m6hmeHNRlLb1uAIEJahYwAfq0FzQa3ZoctN65alPfm 04iX/dv7z0O3pygP+vGOJ1wqaaXlKi93eXLzOGYCappyAKP3G4awU8U2GBGQ4KSV5rs35RvOHBV 5FzjIOufpohRj3vjj8eroy2sjLV2iKTxsd3f1MHGCP7BWZUU+w68/qGaNNJ9uMZd4FkN9q47lkO X/MHkhBibBJsjNW4k6s+r5gUb9jhzfr22rgXVZxgO7w1TESODTSS+Wt2oiR5MnhxbNm0Xraunik g== X-Received: by 2002:a05:6a00:9151:b0:82d:62ed:b01d with SMTP id d2e1a72fcca58-82d62edb767mr3429681b3a.45.1775664883837; Wed, 08 Apr 2026 09:14:43 -0700 (PDT) Received: from sean-All-Series.. (59-115-195-252.dynamic-ip.hinet.net. [59.115.195.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9ca4efesm21916840b3a.61.2026.04.08.09.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 09:14:43 -0700 (PDT) From: Sean Chang To: trondmy@kernel.org, anna@kernel.org Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v1 2/2] NFS: use unsigned long for req field in nfs_page_class Date: Thu, 9 Apr 2026 00:14:28 +0800 Message-Id: <20260408161428.155169-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408161428.155169-1-seanwascoding@gmail.com> References: <20260408161428.155169-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The nfs_page_class tracepoint used a pointer for the req field. This caused Sparse to complain about dereferencing a pointer marked as __private within the trace ring buffer context. Change the field type to unsigned long to store the address of the request without dereferencing it. Update TP_printk to use 0x%lx for consistent hexadecimal output, allowing for unique identification of requests across the trace log. Signed-off-by: Sean Chang --- fs/nfs/nfstrace.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfstrace.h b/fs/nfs/nfstrace.h index 9f9ce4a565ea..4150bbd99cfa 100644 --- a/fs/nfs/nfstrace.h +++ b/fs/nfs/nfstrace.h @@ -1496,7 +1496,7 @@ DECLARE_EVENT_CLASS(nfs_page_class, __field(dev_t, dev) __field(u32, fhandle) __field(u64, fileid) - __field(const struct nfs_page *__private, req) + __field(unsigned long, req) __field(loff_t, offset) __field(unsigned int, count) __field(unsigned long, flags) @@ -1509,14 +1509,14 @@ DECLARE_EVENT_CLASS(nfs_page_class, __entry->dev = inode->i_sb->s_dev; __entry->fileid = nfsi->fileid; __entry->fhandle = nfs_fhandle_hash(&nfsi->fh); - __entry->req = req; + __entry->req = (unsigned long)req; __entry->offset = req_offset(req); __entry->count = req->wb_bytes; __entry->flags = req->wb_flags; ), TP_printk( - "fileid=%02x:%02x:%llu fhandle=0x%08x req=%p offset=%lld count=%u flags=%s", + "fileid=%02x:%02x:%llu fhandle=0x%08x req=0x%lx offset=%lld count=%u flags=%s", MAJOR(__entry->dev), MINOR(__entry->dev), (unsigned long long)__entry->fileid, __entry->fhandle, __entry->req, __entry->offset, __entry->count, -- 2.34.1